I think I am not passing something through at a vital point, can see my queue, then it comes back corrupt and segaults
ic0n
Is your state of teh art in your packetqueue branch?
rexd666
I had it working nice at ffmpeg cam level then realised when I tested it had to all move up to monitor
ic0n
I'm having an issue where I am modetecting, but when zma starts the event it takes too long before recording starts and of course there is no pre-event frames getting stored, so although the event is 8 seconds long, I only have 3 seconds of video.
I will take a look through and see if I can spot the problem.
rexd666
monitor_packetqueue
let me push it
asker joined the channel
asker
morning
ic0n
why is the audio queue so much smaller? I find that there are a ton more audio packets than video packets...
asker
barjac - looks like apple is approving my apps quickly nowadays - your daughter should have received an email. It may install as a new app - don't know how these betas work. You may have to help her set it up.
rexd666
just default values in a example that was close to what I wanted
at the moment I was just trying to push the packets into the queue in video to get that working before I do the pop
I think it is some scope issue that I can’t remember how I was going to solve
ic0n
Looks like you are using av_packet_ref to get another reference to the data in the packet... but we free that packet... maybe we should be copying the packet instead?
barjac
asker: Thanks - she will probably not look at it until she comes back here on Saturday, so I will do it for her.
asker
cool
BTW, I did want to ask barjac , when you said you sent a "telegram", you didn't actually mean telegram, did you :)
barjac
asker: Hehe no it's a secure private live mail app that works on all devices (including desktops unlike most others) - Google it :)
asker
ah! Well, now I feel outdated!
barjac
asker: It's great for family stuff without all the hassle of 'friends' etc. also carries pictures and sound etc if you want.
asker: Yes - we use it all the time - it installs to user home dir and sits in system tray - just works great :)
ic0n
why are you passing in the queue to CaptureAndRecord? Shouldn't it be a member of the Monitor?
rexd666
The shit I am not good at
To me it had to be passed in for packets to be populated, but also it was originally in there, and I started shifting back to monitor once I worked out that it didn’t survive frame to frame
This was back in May so I have probably forgotten where I was up to
ic0n
we really need to get these coding style updates done
knnniggett
ic0n: have not had time to build & test any pr's recently. Won't have time tonight either. If I don't get to it this week, I should over the weekend.
barjac has quit
barjac joined the channel
rexd666
ic0n: looks like I got as far as adding zm_packetqueue.h to monitor.h, but didn’t create the member, shouldn’t leave shit so long
ic0n
I think this code needs a lot of refactoring.
not yours, but zm in general
rexd666
so I should be able to push packets to monitor->queue from the cameras without passing the queue
ic0n
well in your version, the camera doesn't have a monitor member. But in storageareas it does.
I need to make a PR for you that has my rotation code in it, which includes that (because it gets the rotation setting from the monitor object).
rexd666
Ok so do we just merge storageareas and h264 into a single branch or too many iconnor enhancements to ever get that into master?
I was keeping separate so merge had a chance this year
ic0n
I would love it if we did that.
I don't see how we will ever get anything merged ever again unless we just bite the bullet. The longer we go, the more drastic the changes are.
However, if we could start merging things to master again, I might be inclined to generate some more PRs.
wasutton3 joined the channel
rexd666
I am all for it only thing we have seen is that zones issue so if you and knnniggett can get that sorted and throw out a 1.30.1
then we keep merging and can cherry-ipck and fixes to 1.30.1 if need be
rexd666: I did not intend to create another release in the near future. I don't see it as that big of an issue to justify generating yet another batch of packages
rexd666: Yeah, I need to try harder to delegate some of the work around here
ic0n
knnniggett: I did find another little issue while dealing with the zone thing. People are going to have an error logged when they save a zone and it tries to restart zma.
rexd666
knnniggett: ok I will keep working on the auto build packages stuff so hopefully that presents some light at the end of the tunnel, no need for us to do the repetitive stuff, will keep you in the loop when I get into rpm build
knnniggett
rexd666: There are other variables at play too. Right now, I've got newer versions of ffmpeg & vlc in testing repo for CentOS 7. That requires rebuilding zoneminder, ffmpeg (twice!), vlc, and all their dependencies. It's quite annoying. Until I deploy that and wait and see what issues arise, I can't build a 1.30.1 package
wasutton3
that sounds awful...
shootbird has quit
shootbird joined the channel
Schrottie has quit
knnniggett
gnulnx: any new information pouring into the telemetry server?
gnulnx: was talking with rexd666 and it might be useful to see how many 32bit machines are out there running zoneminder. It would help us chose a realistic EOL date for 32bit hardware