Also the zmupdate issue we had recently with perl versions not seeing 1.27 and 1.29.10x correctly
Arron has quit
Also ic0n had a pita job with cherry picking from master to release branch last time, we need a good way to manage new commits during the release window
knnniggett
rexd666: Yeah, I think you are right with vlc being a potential blocker. We at least need to look into it further. Haven't had an opportunity to look into zmupdate.pl
rexd666
I was playing with a test pl last night and 1.28.108 does not return greater than 1.27
Just need to find why
phroco joined the channel
knnniggett
I think we just need to make sure we pass all values through version->parse() before we do the comparision so the logic should look like version->parse(1.28.108) gt version->parse(1.27)
rexd666
nope the way it parses 1.27 and 1.28.10x is different for that built in function here is the result of Print version->normal v1.28.102 v1.270.0
Important Note: Even if you pass in what looks like a decimal number ("1.2"), a dotted-decimal will be created ("v1.200.0"). To avoid confusion or unintentional errors on older Perls, follow these guidelines:
Always use a dotted-decimal with (at least) three components
As soon as I put 1.27.0 into my test it works with the ge, so missing third component kills this version of version
Arron has quit
iSagitt_ joined the channel
knnniggett
So perhaps we should just append a ".0" if it is missing that part. In hindsight, we should have made the release 1.27.0 instead of 1.27... just something to remember moving forward
rexd666
even better it we prefix the string with v it works it out, but going forward always 3 components is better
YellowGTO has quit
also ge is not the correct operator as this results in it applying it’s own update sql to itself again Upgrading DB to 1.27.0 from 1.27
ok time to go to work but I will PR a fix for zmupdate today