im not sure if that's going to be an issue with a big file tho..
DarkPlayer
learn_more: looks more compact :-). Usually big files like installers just append the data at the end of the PE file and they are not part of any section. Is this data included in the hash?
learn_more
nope
DarkPlayer
it shouldn't be a problem in this case
learn_more
so i can submit this?
DarkPlayer
learn_more: let me quickly run the test on different windows versions
learn_more
patchbot is still taking a nap
DarkPlayer
i have my own vms, since sending everything to the testbot would be too slow sometimes
learn_more
ah
DarkPlayer
learn_more: works on XP, but crashed on Win 7 and 10
learn_more
thats funny
does it also crash without my patch?
DarkPlayer
last successful test is line 266
learn_more
that's nowhere near my test
that is in testInitialize
DarkPlayer
seems so hmm
learn_more
but i said it's funny because i also had that crash on my machine (win7)
but today it works
magic
can you disable test_provider_funcs();
that contains the test that crashes
DarkPlayer
most probably the best idea for now
win 7 works now, but 10 crashes after 779 xD
Barry_Butsers has quit
those tests seem buggy
learn_more
ya
DarkPlayer
just running your test works though :-)
learn_more
that's something
lol
DarkPlayer
it works on XP, 7 and 10 so i think we can safely assume it works on all systems that support these hashes
learn_more
should i upload this new one ?
to bugzilla
DarkPlayer
yes
learn_more
what is your name?
or should i just say DarkPlayer
DarkPlayer
Michael Müller but DarkPlayer is also okay ;-)
learn_more
DP it is then, since my irc client doesnt like your last name