#wine-staging

_Marcus_ back then was writing on ddraw

didn't check if they changed something

DarkPlayer: gpo.zugaina?

yes

but the Transgaiming guys said and showed better code and said they will submit it back

so _Marcus_ stopped

and 1 year later Transgaiming decided to not give the code

you said the showed the code? why not simply take it?

and actively marketed how much better their product is at games than upstream Wine...

DarkPlayer: as in demoing it

and it had Transgaiming copyright

no LGPL

well

puk2: how is that compatible with LGPL2 ?

puk2: i assume it was LGPL2, and just noone bothered to send it upstream

did they compile it as a separate module?

back then Wine was BSD

puk2: if that is the case, then its more a wine problem

well the X variant of that

and Transgaiming abused that

b195a1d6155cac359537ec7a677d6dba9354aab2

puk2: [06wine/master] 02Alexandre Julliard: Changed license to LGPL.

but not because of Transgaiming

that just happened to coincide

aah, those were the days

puk2: i don't know about the situation back then, but that people don't bother to submit their patches is nothing unusual, and also understandable sometimes when taking into account the (missing or not useful) feedback ;)

nah

back then everything went in

even whitespace cleanups

and Wine was waiting on that code

DarkPlayer: so, there is a tool for gentoo, layman, which allows for easy management of overlays. Gentoo.org maintains an xml file with metadata about a number of repositories that have been accepted for inclusion. With layman, once you are in that xml file, you can add the overlay without any extra work. Think of it like the old days where you had to edit your sources.list to include a repo, then

add the ppa, as opposed to just adding the ppa these days. gpo.zugaina firstly mirrors that xml, but additionally makes adds each overlay so it can display their contents on the website. IMO, it's a great thing. Someone will do one of two things, A) look at the ebuild and copy it to a local overlay, B) look at the overlay and see there is nothing but wine there, and realize that it is easier just to

add the overlay, and then voila, new user

^^ tl;dr they mirror all "official" overlays. Good thing.

NP-Hardass: well ppa are still entries in the source.list, the only difference is that there are tools to add and remove them ;-)

puk2: it helped to have a large set of applications that all needed the same patches, that's what brought us together

DarkPlayer: right, well, overlays are included with a variable PORTDIR_OVERLAY which contains a list of paths to overlays, and layman adds and removes items from that list, still same concept

10New Wine Staging bug 136 filed by damianzrb@gmail.com.

04Bug http://bugs.wine-staging.com/show_bug.cgi?id=136 normal, ---, ---, bugs, UNCONFIRMED , Schematic in DipTrace don't want to run

fracting: hehe, that was a very long mail ;) do you mind if we talk about it in here publicly, or do you prefer PM ?

slackner, pm first?

kk

I don't mind you share it privately to others :)

slackner: https://bugs.winehq.org/show_bug.cgi?id=32163#c11 add?

04Bug 32163: normal, P2, ---, wine-bugs, NEW , Adobe Illustrator / Photoshop CS6 wants gdiplus.dll.GdipCreateEffect

the minimal patch

jarkko: yep, looks like a good idea, would you open a patch submission report? i'm still going through the job object patches right now ^^

slackner: done

10New Wine Staging bug 137 filed by jarkko_korpi@hotmail.com.

04Bug http://bugs.wine-staging.com/show_bug.cgi?id=137 normal, ---, ---, bugs, UNCONFIRMED , Slacker request to open this (contains minimal patch) #1

And the winner for the most useless bug report title (including typo for slackners nick) goes to ...

lol

s/goes to/is/

lol

could be easier to find than having prober title

should i open a bug about this too? https://bugs.winehq.org/show_bug.cgi?id=38103

04Bug 38103: normal, P2, ---, wine-bugs, NEW , Process Hacker 2.x needs ntoskrnl.exe.ProbeForRead

it's really simple function and austin has made a prepatch

jarkko: yes, looks also fine, but probably give the bugs a bit more meaningful name ;)

10titan.costa@gmail.com changed the Component on bug 137 from Upstream Bugs to Patch Submission.

04Bug http://bugs.wine-staging.com/show_bug.cgi?id=137 normal, ---, ---, bugs, UNCONFIRMED , Slackner request to open this (contains minimal patch) #1

Hello

gadamopoulos: hiho

DarkPlayer: ^^^

AmineKhaldi_ said that you need me or something like that

;)

they found a bug

"DarkPlayer: AmineKhaldi: it was not the original error i was looking for, but there is still a bug in the reactos patch in case COM was already initialized using a different apartment model"

"DarkPlayer: or more precisely the bug is inside the bug fix you added" (you meaning gadamopoulos here )

oh and what was this patch about?

gadamopoulos: http://code.reactos.org/changelog/reactos?cs=66388

you added the following code:

ret = CoInitialize(NULL);

if (FAILED(ret))

return ret;

hmmm right. The thing is that we decided to do it differently from what wine or windows do ending up needing to create a com object in there

but CoInitialize will fail with RPC_E_CHANGED_MODE if COM was already initialized with a multi-threading apartment

10New Wine Staging bug 138 filed by jarkko_korpi@hotmail.com.

04Bug http://bugs.wine-staging.com/show_bug.cgi?id=138 normal, ---, ---, bugs, UNCONFIRMED , Process Hacker 2.x needs ntoskrnl.exe.ProbeForRead

10New Wine Staging bug 139 filed by jarkko_korpi@hotmail.com.

04Bug http://bugs.wine-staging.com/show_bug.cgi?id=139 normal, ---, ---, bugs, UNCONFIRMED , Process Hacker 2.x needs winsta.dll.WinStationEnumerateW

gadamopoulos: i don't say that the solution is wrong, but it must handle the case that COM was already initialized

I wonder if it is correct to initialize com for multi threaded apartment all the time then

or do we have to check if com is initialized

this will fail if it was already initialized without multi threading

i also came across another minor issue

not directly related to this code

the first stream is supposed to have the id 1 according to the msdn and not 0

same applies to line 48

see https://msdn.microsoft.com/en-us/library/window...

"dwStreamNumber [in]

A handle to the current stream. The first time CopyProgressRoutine is called, the stream number is 1."

I see

I'll look into all of these

gadamopoulos: we can also open bug reports on the reactos bug tracker if you guys prefer ^^

slackner: please do :)

right now I'm talking with too many people and Iam slow to respond :)

slackner: we're in a ros monthly meeting

hence his delay in replies ;)

gadamopoulos: kk, will do that in a couple of minutes, already registered an account earlier

slackner: thanks

AmineKhaldi_: ah xD on IRC or RL?

irc

we do that to regroup and decide on stuff

chan ? xD

private :)

ah, too bad xD

come join us and you'll be there :)

It's a trap!

;)

we publish the minutes though

AmineKhaldi_: working on one huge never-ending project is enough for now i guess xD

slackner: you don't expect a meeting of an open source project to be open?! ;-)

DarkPlayer: lol ;)

it's just to focus without tons of people discussing things, as we'll be the ones that end up doing them :)

the minutes are public so that anyone can see what we said, otherwise we'll spend days in each meeting

we're also open to any points to include in our meetings, from our community

and they see them next meeting minutes

AmineKhaldi_: but it is a password protected channel not one you simply don't have voice rights?

DarkPlayer: as long as people can join they can still try to tell things ... nickchange ;)

lol

we reuse one that the german foundation uses for their formal meetings enforced by law