#wine-staging

DarkPlayer: i tested your large icons patch

works

jarkko: how often do you change your nick?

but the icons arent drawn, toolbar is missing something also the icons your patch draws now bigger. but i quess its another issue

"also the icons your patch draws now bigger" i think this is the expected behavior

that is, but what's the cause that toolbar is missing some content and also the icons that your patch fixes

https://bugs.winehq.org/show_bug.cgi?id=24785 i dont know if this is fixed or not

04Bug 24785: minor, P2, ---, wine-bugs, UNCONFIRMED , Explorer++: tile view doesn't work

i definitely see something change when i use that title

slackner: shutdown deadlock?!?!

ehoover: yes, shutdown deadlock and thread refcounting issues

ehoover: the refcounter got below zero

ehoover: i was hoping that i could ignore this error (that was the reason for the Sleep(...) in my recently submitted patch)

ehoover: but seems like AJ doesn't want me to work around unrelated wine bugs xD

slackner: lol, how long has this bug existed?

ehoover: i guess forever

ehoover: my patch most likely also doesn't fix all the issues .. the wine loader stuff is really messed up

ehoover: reactos has a nice and clean implementation ... but wine? all totally messed up xD

ehoover: i already suggested DarkPlayer that we should compile all libs with mingw, and then replace the wine loader code with code from reactos ^^

slackner: how to find bugs that your patch fixes?

slackner: i found the issue with the shlfileop patch

jarkko: not sure, it could help for apps which hang on shutdown

jarkko: or for apps which unexpectly shutdown

DarkPlayer: what was it ?

slackner: initializing ole using CoInitialize breaks the installation

oh, that means reactos is affected by this bug too, right ?

AmineKhaldi: ^^^

yes

hm, that means we have to implement a progress dialog without using OLE? :(

or find the reason why anno doesn't like ole32

DarkPlayer: well, its weird because you uninitialize again afterwards

not sure how much i can really shrink the patch

maybe related to the apartment model of ole?

i think the installer users multiple threads

ariscop: don't spend too much time with that, we are a staging tree ;) i assume you wanted to submit to us before you do the next upstreaming attempt, right ?

slackner, yeah

either way it's making me clean up a few things

don't know why i did the set info function that way

btw guys i am not able to see a window whenever i use uTorrent

the installer seems to use ole too: err:ole:CoInitializeEx Attempt to change threading model of this apartment from multi-threaded to apartment threaded

shomy: in wine you mean? there are still a couple of opened bug reports, for example https://bugs.winehq.org/show_bug.cgi?id=24946

04Bug 24946: minor, P3, ---, wine-bugs, NEW , uTorrent 2.2.0 hangs on startup

ok ...is there priority on any of these ??

shomy: the bug already exists since a very long time, don't think anyone is working on it atm

shomy: moreover, also not sure if its the same bug you experience, but might be possible

also there is workaround to use another version or native

shomy: again the question: why not use the linux version of it? ;-)

i am trying to test the patch slackner but i have issues getting into steam now

i'm curently using deluge ...but i'm seeing crashes in /var/crash/ ...and i dont like the minimalistic interface of transmission

slackner: argh, it was my mistake :-(

slackner: my anno fix added a return path which didn't call CoUninitialize()

DarkPlayer: ah :/

slackner: though what should we do if the application already initialized ole with a different apartment model?

slackner: check for RPC_E_CHANGED_MODE as return value and reuse the existing one?

well, i assume you know that CoInitialize always increments the refcount

so you could theoretically ignore the return value

ah, you are right, didn't know that

slackner: i got wine to start by copying the native dnsapi.dll into the "c:\windows\system32" folder

shomy: which app do you mean? utorrent ?

yes

shomy: hm, normally wine already has a builtin version of that, but i guess its too buggy to work with utorrent then

it seems so ...

gonna try aactually download something

slackner: btw, there is a reason why we don't see any progress with wine

BOOL WINAPI CopyFileExW(LPCWSTR source, LPCWSTR dest,

LPPROGRESS_ROUTINE progress, LPVOID param,

LPBOOL cancel_ptr, DWORD flags)

slackner: wine ignores the progress argument ;-)

progress routine is ignored ?

ah xD

however, this should be easy to fix since wine already copies the file manually

slackner: it's downloading ..yay

shomy: :)

shomy: you should say something at the bug thread

jarkko: ok what should i say for that bug?

btw i posted a bug on winehq https://bugs.winehq.org/show_bug.cgi?id=37950 ...that one still exists

04Bug 37950: normal, P2, ---, wine-bugs, UNCONFIRMED , Listview in uTorrent 3.4.2 (32-bit) unresponsive when removing torrent

shomy: wine version used, confirm what utorrent you have and explain the workaround

shomy: jarkko: you should create a new bug report when its not already covered by an existing one

and only one problem per workaround

-workaround +bug report

lol

slackner: don't dare to create a workaround that solves more than 1 bug! ;-)

lol

10New Wine Staging bug 133 filed by shomari.sharpe@gmail.com.

04Bug http://bugs.wine-staging.com/show_bug.cgi?id=133 normal, ---, ---, bugs, UNCONFIRMED , uTorrent does not start without native DNSAPI.DLL

slackner: how do i restore the original wine dll ? ...so i need to apt-get --reinstall ??

shomy: no, you only replaced it in the current wineprefix ~/.wine

slackner:gonna put the console log s an attachment to the bug

shomy: did you set dnsapi to native in winecfg?

shomy: just undo that again, then wine will prefer the builtin dll

shomy: (even if c:\windows\system32 still contains the native one)

yes i used winecfg ...after copying the windows dnsapi.dll over the wine version

ok cool

shomy: if possible try to fill out a couple more fields like URL (download link, if available)

shomy: and the version of utorrent

different version could also mean that it doesn't encounter this bug or behaves differently

slackner: just for the fun of it i'm gonna try counter strike again

brb

slacker: no luck with that :(

wine-loader crashes

wine-preloader

it's already detailed in my bug report earlier

shomy: didn't have time to look yet ... but i'm wondering a bit because usually you shouldn't get any core dump

shomy: wine catches all errors, and prints a stack trace instead of showing the full info

slackner, so i've got the patchset, what now?

open a bug or pull request

ariscop: whatever you prefer - a bug report might be easier, especially when we probably might have to rebase them on top of our other staging patches

ariscop: or when we have other comments

they're rebased against the current wine-staging head

ariscop: well, as i said, whatever you prefer ;)

might have to be a pull request, bugzilla is taking a while to send the email

ariscop: which mail do you mean? registration confirmation mails should be send immediately

registration

oh derp, wrong email

hmm which header file should i choose?

Header

WinBase.h (include Windows.h);

FileExtd.h on Windows Server 2003 and Windows XP

winbase or fileextd.h ?

i assume fileextd doesnt exist in wine, right?

then use winbase

yeah, i also just noticed this, so i go for winbase.h ;-)

10New Wine Staging bug 134 filed by ariscop@gmail.com.

04Bug http://bugs.wine-staging.com/show_bug.cgi?id=134 normal, ---, ---, bugs, UNCONFIRMED , server: Implement job objects

ariscop: thx :) just debugging on a different bug, but will start reviewing immediately afterwards and keep you updated

^_^

going to take the bot offline for a few, okay?

NP-Hardass: kk

@quit

[06staging/master] 02Sebastian Lackner: Added patch to fallback to global key state for threads without a queue.

(05https://github.com/wine-compholio/wine-stagin...)

10New Wine Staging bug 135 filed by michael@fds-team.de.

04Bug http://bugs.wine-staging.com/show_bug.cgi?id=135 normal, ---, ---, bugs, CONFIRMED , Implement SetFileInformationByHandle