22:24 PM
glyph
oops sorry I mean, "gotLength"
22:25 PM
_moshez
ok. so I'm assuming that in hCC, I'm doing some sort of incremental MIME parsing and putting the file into the target file?
22:25 PM
glyph
sorry this interface is not super well documented, I always have to read HTTPChannel to remember it, and then I forget parts of it are actually in HTTPChannel
22:25 PM
_moshez: right so that's the second problem, Request.requestReceived calls 'cgi.parse_multipart'
22:26 PM
_moshez
glyph: sounds like that's the part where I steal/borrow bits from django to stream-parse mime?
22:27 PM
lazybear joined the channel
22:27 PM
ok I'm not sure we got into real regrets territory yet, so I'm guessing that's coming up?
22:28 PM
glyph
_moshez: right.
22:28 PM
if you think feed-parsing MIME is easy and fun then great, you're done
22:29 PM
so I doubt you're going to regret this
22:29 PM
moshez joined the channel
22:29 PM
22:29 PM
oh hrm
22:29 PM
maybe you should just work with wsanchez to make that One Hundred Per Cent For Real
22:30 PM
it's not far
22:30 PM
22:33 PM
wsanchez
22:33 PM
But 199 is a subset, me trying to get someone to actually approve something
22:33 PM
runciter
does #181 require twisted depend on tubes?
22:33 PM
is that going to be a blocker?
22:34 PM
wsanchez
181 requires tubes
22:34 PM
glyph
runciter: it requires klein depend on tubes :)
22:34 PM
runciter: I doubt it's going to be much of a blocker
22:34 PM
wsanchez
But it's in Klein right now, not Twisted
22:34 PM
glyph
runciter: there's a point where we need to do a switcheroo
22:35 PM
runciter
glyph: the streaming part is a lie without giving t.w.http.Request a streaming body :(
22:35 PM
wsanchez
It's starting by defining the API
22:35 PM
The implementation underneath can then catch up
22:35 PM
glyph
once the API exists, it will be pretty easy to adjust the implementation in the way I just said
22:35 PM
runciter
wsanchez: yeah, you've done the hardest part :)
22:35 PM
Wulf has quit
22:35 PM
glyph
you just need to create an explicit opt-in API
22:36 PM
wsanchez
runciter: No the hardest part is getting it reviewed ;-)
22:36 PM
runciter
i'm still interested in making a streaming version of t.w.http.Request - that's why i ask
22:36 PM
wsanchez
(To be fair it's been reviewed by a few folks.)
22:37 PM
I want to kill t.w.http.Request (and t.w.server.Request) with a knife while it sleeps
22:37 PM
Instantiating one of those requires a Ph.D. in jank
22:37 PM
runciter
no complaints here
22:42 PM
_moshez
ok cool, I'll try to find some time to look at these things and see if I can help push them forward
22:43 PM
on a personal note, it's so weird for me to have a conversation about http on #twisted :)
22:43 PM
I still remember the days where it was all "#twisted-web is that way"
22:43 PM
I'm an old I guess.
22:44 PM
hopefully that will be useful for WSGI too, and then we can put warehouse behind twisted WSGI :)
22:44 PM
simpson
I remember those days.
22:45 PM
glyph
we just need everyone involved in this conversation (HI SIMPSON) to review one ticket a week :)
22:47 PM
moshez has quit
22:47 PM
simpson
glyph: See, this is why I never remember things. It just causes me to remember how much stuff is on my plate.
22:48 PM
_moshez
ah thursday.
22:48 PM
glyph
_moshez: yeah, twisted.web is gradually getting deprecated :)
22:48 PM
sorry
22:48 PM
#twisted.web
22:48 PM
I mean
22:48 PM
and twisted-web, the mailing list
22:48 PM
foom
You realize that a _literal_decade_ago_, we were all talking about this same damn thing.
22:49 PM
_moshez
foom: twisted prevails
22:49 PM
foom
Or was it a decade and a half.
22:49 PM
Does it? It still can't stream-parse file uploads. :)
22:50 PM
simpson
foom: Further evidence that it's a hard problem, I guess.
22:52 PM
foom
Well, there's tubes now, so that's progress.
22:58 PM
glyph
foom: wsanchez is surprisingly close to done on this PR, even
23:00 PM
foom
"New stream stuff. *THIS* one is good for *sure*."
23:00 PM
23:00 PM
(spoilers: nope)
23:01 PM
simpson
foom: Today I realized that I can *reuse* a stream library for a thing. My elation was nearly palpable.
23:02 PM
kenaan
Tickets pending review:
https://tm.tl/#8159 , #761, #8966 (the0id), #9100, #9101, #9118 (the0id), #4964 (jameshilliard), #9131, #9138, #9143
23:07 PM
worrelsik1 joined the channel
23:09 PM
worrelsik has quit
23:24 PM
rthille-ciena1 joined the channel
23:37 PM
clokep joined the channel
23:38 PM
EACFreddy has quit