#twisted

someting like that

itamarst: awesome, thank you!

iffy: let me know if you have problems/questions

itamarst: will do

hey everyone, i submitted a PR to vertex forever and a half ago... but its been some time and i'd really like to ask for some help on pinpointing how i messed up this addCallback

the PR i mentioned is here: https://github.com/twisted/vertex/pull/39

i can link you the travis build too if youd like to see the specific error :)

feel free to PM me if you dont want to blow up channel, i'd really appreciate the help!

chellygel: blowing up the channel is always encouraged :)

chellygel: so what's going on with the failing tests?

chellygel: ...?

i'm getting "exceptions.AttributeError: 'NoneType' object has no attribute 'addCallback'"

withhhh the test forrr

testChooserGetsThreeChoices

chellygel: it's true! NoneType in fact does not have that type of attribute.

hhahahahaha

yes, so to me i broke down what i was passing through

but i wasnt sure if it was the test that was messed up or my code, but i was more inclined to say it was my code

though we did make a lot of changes so thats why i was a bit lost on it

chellygel: so why don't you walk me through what _you_ think is happening

sure!

so i think it has to do with privateSecret, right? so something with the certificates isn't getting passed around correctly?

i feel bad for person named so ;~;

_addClientService isn't returning the callback thing its expecting so it bombs there-- let me get my debugger running again now! sec

if i say sorry during this conversation, please slap me with a trout

i've typed it 4 times now

so when walking through -- return self.requestCertificateForAddress(fromAddress, password) is whats triggering the code to send the nonetype error

no im wrong, this return svc.authorize(q2q.Q2QAddress(serverDomain, username),

--> 419 privateSecret).addCallback(lambda x: svc)

i remember you and I walking through callbacks together -- but my next step in figuring this all out was to build a baby program to help me play with them more so i could better understand what this is doing

chellygel: let's look at the bottom line of the traceback

ok!

chellygel: we're inside _addClientService, it's complaining about .addCallback not being on some NoneType, which suggests that the result of the expression "svc.authorize(q2q.Q2QAddress(serverDomain, username), privateSecret)" is returning a NoneType, and we expect something with an 'addCallback' method (i.e. a Deferred)

right.

chellygel: which means that somewhere (most likely) there's a 'def authorize(' inside a Service class that is returning None

you are inferring that from the svc.authorize line

"git grep -n 'def authorize('" tells us there is only one such definition in the entire codebase

chellygel: I am indeed.

thanks

chellygel: is it clear _why_ I'm inferring that?

its trying to perform that action and receiving none type -- when it expects the call back method

right.

i havent pulled the au thorize up yet but then i should believe that some inheritance may not be occuring

since that addcallback method isn't found

chellygel: rather than step all the way through authorize, I'm going to skip ahead a little bit :)

and i know thats coming from twisted proper not vertex

chellygel: we know that something has _changed_ in this PR which is causing the failure

right.

chellygel: specifically, we know that something (ultimately called by 'Q2QService.authorize') _used_ to return a Deferred, but now returns None instead.

tracking.

chellygel: I may have to back up and make sure you know this Python thing - the default return value of any method that doesn't explicitly return is None :)

i do understand this!

chellygel: OK cool. The thing to look for is any place a 'return' either turns into a 'return None' or a fall-off-the-end-of-the-function-without-returning in your patch at https://github.com/twisted/vertex/pull/39/files

chellygel: do you see such a thing?

looking

when you say "fall-off-the-end-of-the-function-without-returning"

do you mean not returning at all?

chellygel: yeah.

akin to gotSignResponse?

its doing things but not explicitly returning something

chellygel: Exactly. Except - getSignResponse used to be called '_1', and that didn't return anything previously either.

chellygel: getting warmer thouhg :)

okay but now getsecure connection isn't returningggggggg

as it was before

so it was doing things then... initializing...itself? am i saying words right?

chellygel: 👃👈

TIL you can emoji in irc

oooookayyyy wow

chellygel: only actual emoji though, no cheating like :sparkles: on slack

thank you! this walkthroguh really helped me understand how to look for that better!

lets tinker and try things!

chellygel: ✨🍰✨

chellygel: btw, 'pipsi install em-keyboard' is super handy ;-)

emoji? ahhaa

chellygel: that was 'em sparkes cake sparkles'

hahahhahah wow

chellygel: so you have enough to fix that error now?

thank you glyph ! im onto the next issue!

yes

chellygel: fantastic.

i may not have nailed it 100% but i definitely have a new error thats further down the line about the connections not having any certs that can be used

thank you, again! i have a much better understanding of how to review this now

Looking forward to landing :)

keep seat belts on, turbulence !

haha

glyph i did it -- it not works

it now*

i am still sturggling with the callbacks though. i think i will take some time searching for a good set of examples to play with them

perhaps a tutorial somewhere

if anyone has any recommendations for a good tutorial, let me know -- otherwise im at the hands of google's excellent recommendations haha

chellygel: I remember this https://twistedmatrix.com/documents/current/cor... being helpful :)

Okay! travis is running, i ran trial locally and i think i discovered something else error wise -- but i have to relocate from [friend's coffee house] to [my personal cave]

thank you derwolfe ! i will use this once im set back up!

I'm getting a "Twisted-16.4.0-cp27-none-win_amd64.whl is not a supported wheel on this platform" on a windows 7 machine, but the control painel shows it as 64 bits, anyone has any ideas what can be happening?

Also, I'm in a virtualenv

I thought it was weird that with pip install twisted it was downloading the source distribution, so I tried to download the wheel myself, and this happened

well the code is passing but i have a metric shit ton of pyflakes stuff to fix! wee hahaha

glyph reviewed <https://tm.tl/#8505>; - Build pypy on Travis-Ci with coverage reports (assigned to adiroiban)

glyph reviewed <https://tm.tl/#8764>; - Twisted should be versioned as year.month.patch, not year.release-1.patch (assigned to hawkowl)

so, turns out I was running python 32 bits on windows 64

=(