#twisted

hawkowl submitted <https://tm.tl/#8290>; - build-apidocs script should use the pyOpenSSL and Python intersphinxes (unassigned) for review

Lukasa reviewed <https://tm.tl/#8290>; - build-apidocs script should use the pyOpenSSL and Python intersphinxes (assigned to hawkowl)

Amber Brown (HawkOwl) <hawkowl@atleastfornow.net>; closed <https://tm.tl/#8290>; - build-apidocs script should use the pyOpenSSL and Python intersphinxes

adiroiban reviewed <https://tm.tl/#5812>; - PEP 3105 Make print a function (assigned to rodrigc)

Hi , I am trying to implement bully algorithm, I am using DatagramProtocol . Lets say , I have sent an election message to my peers , and I expect an "I am alive" message . I am doing reactor.callLater(delay,some_function).. So , should I set some flag value when i receive my data and use in my "some_function" ?

is that the right way to go about it ?

rodrigc submitted <https://tm.tl/#5812>; - PEP 3105 Make print a function (assigned to adiroiban) for review

??

Something that annoys me about Twisted - it suppresses errors.

errors and exceptions aren't displayed to the terminal.

toothe: Twisted's default error handler for Deferreds doesn't kick in until the Deferred is GC'd.

Add your own errbacks if you want to get those errors sooner.

GC'd?

Garbage-collected.

ahh.

is that changable, especially in development?

There's nothing builtin, but you could hack on it. I'm not sure what behavior you would want, though.

well, just in development, to see all errors immediately.

Well, that doesn't mesh with Deferred errbacks. A Deferred in an erroring state will run errbacks attached to it.

Sorry, trying to remember how Deferreds work. It's been a while.

hawkowl reviewed <https://tm.tl/#8194>; - Add HTTP/2 implementation of HTTPChannel. (assigned to Lukasa)

toothe: it "suppresses" errors to the same extent that catch does.

toothe IMO It's good practice to add an errback to deferreds (that you receive) in any case, even (or especially) when you're sure nothing can go wrong. Just call addErrback and pass a logging function, if nothing else. I'm talking about the simple case where something returns you a deferred and you don't pass it on to other code.

Can't you use log.err as the errback? ISTR that something like that is available.

(you can, yes)

simpson yes, assuming you're not passing the deferred on to any other code that might also want to add callbacks (because log.err returns None)

unfortunately you can't do that with twisted.logger :(

Okay, so that's the missing piece that I forgot; log.err "caps" the Deferred.

simpson it doesn't really... the deferred can still have things added to it, but after calling log.err the result in the deferred is now None and you're back on the callback chain - probably not very useful. but maybe that's what you meant.

terrycojones: Yeah. No more data, no more useful information other than knowing that the rest of the Deferred has executed.

right

new core task https://tm.tl/#8368 by mesozoic: Deprecated twisted.cred.credentials.UsernameHashedPassword

mesozoic closed <https://tm.tl/#3648>; - twisted.cred.credentials.UsernameHashedPassword doesn't hash password strings when checkPassword

Amber Brown (HawkOwl) <hawkowl@atleastfornow.net>; closed <https://tm.tl/#8336>; - We should have a topfiles checker in tox

def tap(f): def _inner(result, *a, **kw): f(result, *a, **kw); return result;; return _inner

i ended up writing that helper because having a callback only for side-effects was an extremely common pattern

d.addCallback(tap(log.err))

There is an issue for that somewhere.