0:04 AM
kenaan
Tickets pending review:
https://tm.tl/#8894 , #8900, #6800, #8922 (glyph), #8325 (the0id), #8934, #8920
0:22 AM
exarkun joined the channel
0:31 AM
exarkun
Someone who knows about the trac deployment around?
0:39 AM
Okay
0:47 AM
KenaanX joined the channel
0:47 AM
NOTICE: [13twisted] 15exarkun created 06test-trac-short-ticket-references from 06trunk (+0 new commits): 02 https://git.io/v1Wf6
0:47 AM
KenaanX has left the channel
0:47 AM
KenaanX joined the channel
0:47 AM
NOTICE: [13twisted] 15exarkun pushed 1 new commit to 06test-trac-short-ticket-references: 02 https://git.io/v1WfP
0:47 AM
NOTICE: 13twisted/06test-trac-short-ticket-references 14da61218 15Jean-Paul Calderone: Create don't merge
0:47 AM
KenaanX has left the channel
0:50 AM
KenaanX joined the channel
0:50 AM
NOTICE: [13twisted] 15exarkun 04deleted 06test-trac-short-ticket-references at 14da61218: 02 https://git.io/v1Wf5
0:50 AM
KenaanX has left the channel
0:50 AM
exarkun has left the channel
0:54 AM
adiroiban has quit
1:08 AM
runciter joined the channel
1:27 AM
runciter has quit
1:30 AM
runciter joined the channel
1:45 AM
runciter has quit
2:08 AM
rodrigc has quit
2:28 AM
itamar has quit
2:29 AM
KenaanX joined the channel
2:29 AM
NOTICE: [13twisted] 15glyph pushed 1 new commit to 068922-hostname-resolver: 02 https://git.io/v1WLN
2:29 AM
NOTICE: 13twisted/068922-hostname-resolver 14eb3f53a 15Glyph: Merge branch 'trunk' into 8922-hostname-resolver
2:29 AM
KenaanX has left the channel
3:20 AM
hawkowl
glyph oh hey 3.6 passes now :D
3:21 AM
runciter joined the channel
3:32 AM
glyph
hawkowl: i have been waiting... all day... for a single build to finish...
3:32 AM
hawkowl
nice
3:33 AM
glyph so this is why I wanted to have things in buildbot :)
3:33 AM
glyph
hawkowl: Yeah I feel you.
3:33 AM
3:34 AM
runciter
is there any reason not to merge it?
3:34 AM
hawkowl
did we change the merge message?
3:34 AM
runciter
i can't think of one
3:34 AM
hawkowl
i havent fully looked into what jp did
3:34 AM
glyph
hawkowl: exarkun did do a thing
3:34 AM
hawkowl
okay
3:34 AM
so what do i do now?
3:34 AM
glyph
hawkowl: I _think_ it's just 'Fixes: ticket:whatever' now
3:34 AM
hawkowl
okay
3:34 AM
[ticket:1234] or ticket:1234
3:35 AM
glyph
Give that a try and if it doesn't work then ¯\_(ツ)_/¯
3:35 AM
I *think* it's just ticket:1234 but maybe have a look at the actual change?
3:35 AM
hawkowl
uhh
3:35 AM
okay trac changed
3:35 AM
did we upgrade to 1.2 as well?
3:35 AM
kenaan
3:35 AM
glyph
yikes
3:35 AM
I don't think so
3:36 AM
what makes you think that?
3:36 AM
I did ask him to update the wiki page but I think he may not have gotten that message until after he left for the day
3:36 AM
KenaanX joined the channel
3:36 AM
NOTICE: [13twisted] 15hawkowl pushed 1 new commit to 06trunk: 02 https://git.io/v1Wmz
3:36 AM
NOTICE: 13twisted/06trunk 14e48500b 15Amber Brown: Merge 8934-no-mac-travis: Remove mac builds from Travis...
3:36 AM
KenaanX has left the channel
3:36 AM
hawkowl
glyph the css looks a little different :P
3:36 AM
okay ticket: didnt work
3:36 AM
glyph
hawkowl: bummer.
3:36 AM
kenaan
3:37 AM
hawkowl
maybe it is [ticket:8934]
3:37 AM
(that was a manual close)
3:38 AM
glyph
okay gotta head out now
3:38 AM
hawkowl
wow
3:38 AM
the emails are f'd now
3:39 AM
hawkowl goes to pin trac
3:42 AM
runciter
hawkowl: i think the problem is the colon in Fixes: ticket:NNN
3:42 AM
hawkowl
i don't think it's trac style without the sq brackets
3:43 AM
runciter
err maybe Fixes isn't implemented?
3:43 AM
lemme pull down the PR
4:07 AM
mesozoic joined the channel
4:12 AM
hawkowl
its in twisted-trac-plugins
4:15 AM
runciter
yea
4:15 AM
hawkowl: so there's an "envelope" setting which is the wrapper for the "command"
4:16 AM
hawkowl: e.g. commit_ticket_update_envelope = [] means that it's got to be [ticket:XXX] i think
4:16 AM
but
4:16 AM
4:16 AM
hawkowl
right
4:16 AM
cool
4:16 AM
4:17 AM
runciter
hawkowl: yeah but then
4:18 AM
4:18 AM
so i think twisted_trac_plugin's replaces trac's
4:19 AM
hawkowl: now i'm trying to see if "Fixes" ever matches because i don't see a cmd_fixes in there
4:19 AM
but i do see a cmd_ref and cmd_closes
4:19 AM
err cmd_close
4:54 AM
ugh
4:55 AM
hawkowl: ok so after a bit i got the plugin's _parse_message running in a repl and it parsed out the ticket number from the merge commit
4:56 AM
so i have no idea why that didn't close it
4:56 AM
not helpful, i know :(
4:58 AM
stryx` joined the channel
5:01 AM
oberstet__ joined the channel
5:03 AM
mesozoic has quit
5:04 AM
kenaan
Tickets pending review:
https://tm.tl/#8894 , #8900, #6800, #8922 (glyph), #8325 (the0id), #8920
5:10 AM
mesozoic joined the channel
5:39 AM
runciter joined the channel
5:45 AM
KenaanX joined the channel
5:45 AM
NOTICE: [13twisted] 15glyph pushed 1 new commit to 068922-hostname-resolver: 02 https://git.io/v1W3r
5:45 AM
NOTICE: 13twisted/068922-hostname-resolver 144353f1e 15Glyph: Merge branch 'trunk' into 8922-hostname-resolver
5:45 AM
KenaanX has left the channel
5:49 AM
glyph
5:50 AM
Runciter: hawkowl: ...
5:50 AM
It is part of my effort to get IPv6 support for Agent
5:50 AM
But it also just generally makes code using HostnameEndpoint way more testable
5:51 AM
runciter
glyph: i've been following the PR; review no sooner than tomorrow due to active items from my list of things to do
6:19 AM
glyph
runciter: sure :)
6:50 AM
mesozoic has quit
8:17 AM
KenaanX joined the channel
8:17 AM
NOTICE: [13twisted] 15glyph created 067744-unsupported (+3 new commits): 02 https://git.io/v1WnX
8:17 AM
NOTICE: 13twisted/067744-unsupported 14a21da78 15Julian Berman: Merge branch 'trunk' into unsupportedmethod-str-7744...
8:17 AM
NOTICE: 13twisted/067744-unsupported 14f91d912 15Julian Berman: That'll teach me to make changes during merges....
8:17 AM
NOTICE: 13twisted/067744-unsupported 14a2b36c0 15Glyph: Merge branch 'trunk' into unsupportedmethod-str-7744
8:17 AM
KenaanX has left the channel
8:40 AM
evil_gordita joined the channel
9:42 AM
adiroiban joined the channel
10:04 AM
kenaan
Tickets pending review:
https://tm.tl/#8894 , #8900, #6800, #8922 (glyph), #8325 (the0id), #8920
12:37 PM
oberstet__ joined the channel
12:41 PM
itamar joined the channel
13:15 PM
clokep joined the channel
13:16 PM
clokep joined the channel
13:54 PM
stryx` joined the channel
14:23 PM
clokep has quit
15:04 PM
Tickets pending review:
https://tm.tl/#8894 , #8900, #6800, #8922 (glyph), #8325 (the0id), #8920
15:25 PM
mesozoic joined the channel
15:32 PM
adiroiban has quit
15:57 PM
clokep joined the channel
16:16 PM
mesozoic has quit
16:48 PM
stryx` joined the channel
17:38 PM
stryx` joined the channel
17:49 PM
jcline joined the channel
18:04 PM
adiroiban joined the channel
18:58 PM
KenaanX joined the channel
18:58 PM
NOTICE: [13twisted] 15glyph created 068892-conch-docs-existing-conn (+16 new commits): 02 https://git.io/v1WXI
18:58 PM
NOTICE: 13twisted/068892-conch-docs-existing-conn 142f11b94 15Carl Waldbieser: Made it more clear where the existing `connection` parameter comes from.
18:58 PM
NOTICE: 13twisted/068892-conch-docs-existing-conn 14554bf46 15Glyph: Merge branch 'trunk' into conch_docs_existing_conn
18:58 PM
NOTICE: 13twisted/068892-conch-docs-existing-conn 144447d8e 15Glyph: Merge branch 'trunk' into conch_docs_existing_conn
18:58 PM
KenaanX has left the channel
19:33 PM
moshez has quit
19:41 PM
moshez joined the channel
19:43 PM
runciter joined the channel
19:58 PM
moshez has quit
20:04 PM
Tickets pending review:
https://tm.tl/#8894 , #8900, #6800, #8922 (glyph), #8325 (the0id), #8920
20:06 PM
moshez joined the channel
20:37 PM
adiroiban has quit
20:41 PM
adiroiban joined the channel
20:45 PM
adiroiban has quit
21:39 PM
jcline joined the channel
21:53 PM
runciter joined the channel