#twisted-dev

Not sure how review works for klein, but https://github.com/twisted/klein/issues/138

Ah, PRs, yes. Go Github.

modern world and all

eeshangarg: hi!

runciter: Hi! How are you? BTW, Here's the output of the latest command you asked me to run: <http://pastebin.com/kDzH76dP>;

https://paste.pound-python.org/show/I24KfjCi9Ln... (repasted for eeshangarg)

eeshangarg: good, thanks! and thanks for that output

eeshangarg: ah ha

eeshangarg: ensure that your local changes are either committed or stashed, and then do

eeshangarg: git clean -fxd

runciter: Okay, should I run tox again after that?

eeshangarg: yep!

runciter: The tests are running now at least for python 2.7. Is there an all encompassing test command I could run before submitting any PRs in the future

?

runciter: All passed! Yay! Thank you!! :-)

eeshangarg: :)

eeshangarg: i've got to go now - keep me updated via the PR comments!

runciter: Yes, will do! Will start working on this tomorrow after school! Have a great day! :-)

eeshangarg: you too! thanks for all the work and patience

@param reactor: If passed, the L{IReactorFromThreads} / L{IReactorCore} to

be used to coordinate actions on the L{Team} itself. Otherwise, a

L{LockWorker} will be used.

from twisted._threads._pool

in fact, there is no reactor parameter so passing it would be impossible

I can't tell if that's a documentation bug or an actual code bug

idnar: ops

idnar: oops

glyph maybe over here

glyph okay so i need to land the incremental one so i can do 16.5

new core enhancement https://tm.tl/#8852 by hawkowl: Move twisted.python._dist3 into _setup