Title: Prepare an upstream migen/misoc for merging into litex · GitHub (at gist.github.com)
cr1901_modern
mithro: Okay, this makes me feel _much_ better. I have no idea how/why it works, but clearly you put thought into it.
mithro
cr1901_modern: The aim there is to try and get LiteX / migen+misoc closer together again
cr1901_modern
mithro: So my intent was to at the very least make litex PRs for the two platforms I added to migen/misoc since I started my current round of PRs. >>
if you decide to run this script later, would the end merge of my two PRs be equivalent as if I never bothered sending the PRs at all?
(and just let your script add the new platforms instead)
Easier q: Should I just keep making PRs to migen/misoc and let your script handle merging in changes? Or should I make equivalent PRs for each migen/misoc feature I need to get tinyfpga running?
(Some PRs I made to migen/misoc are irrelevant to litex)
cr1901_modern is afk for a bit
mithro
cr1901_modern: Could you get stuff into LiteX sooner rather than later?
FelixVi
mithro: is it OK to ask you a question or two about targets in litex? I'm trying to port Saturn to litex so that we can work on that directly
I'll see if I can figure this out - mimasv2 didn't complain about this
cr1901_modern stares at Felix
cr1901_modern
(11:03:16 PM) FelixVi: doh - I think it's the 'c' which needs to be "C"
(10:59:16 PM) cr1901_modern: It's BaseSoC* I think
:P
FelixVi
well, point is that it works now ;)
skay_ joined the channel
cr1901_modern
FelixVi: I am not exactly positive on "length = *flashbase++;" and why it's written like that <-- flash image is supposed to embed the length of the image
as well as a checksum
FelixVi
I think it takes the length from the first object at the base pointer and increments it by 1
then takes the crc from there
but why it's written like that is a mystery to me
cr1901_modern
B/c it works :P
skay_ is now known as skay
FelixVi
you need to know the operator priority to figure out what it does
skay is now known as Guest57653
so IMO writing it in explicit notation makes it easier to read
cr1901_modern
++ has low priority. It's one of the last things done
FelixVi
but either way, it does not find a valid length, so I assume we're not actually reading from flash :P
cr1901_modern
Did you update the flash to use spiflash1x?
FelixVi
when it's on the right yes, but I think on the left it would get resolved before dereferencing
either way, the fact that we talk about it means the notation is not readable
unless the mantra is to minimize lines in the code
cr1901_modern
*b++ = *a++ is a common memcpy idiom
but that's not really important
FelixVi
agreed
cr1901_modern
I want to know whether you changed the spiflash to use 1x
FelixVi
spi_flash.SpiFlashSingle is what I use
but we get hung up on serial configuration as of now
cr1901_modern
please show me your code
FelixVi
hold on - is it more convenient for you to work on misoc or litex?