hey there, anybody here aware why ForceNew is set to true for security_groups in builtin/providers/aws/resource_aws_instance.go ?
( I do not want TF to recreate an instance just to update (a) security group(s) )
luminous
ojongerius: I said the same today
I think you can override that
but I forget the details I am thinking of
kkvlk joined the channel
kkvlk has quit
jrnt30 joined the channel
nathanleclaire has quit
codepwnie has quit
PaulCapestany has quit
rbowlby has quit
codepwnie joined the channel
PaulCapestany joined the channel
codepwnie has quit
codepwnie joined the channel
niemeyer has quit
codepwnie has quit
svij_ has quit
tphummel has quit
andrewwatson joined the channel
kkvlk joined the channel
kkvlk has quit
svij_ joined the channel
knuckolls joined the channel
ojongerius
luminous: I did some digging, and is currently needed, but AFAICS it is no longer needed. Removing it does require to call ModifyInstanceAttribute, instead of relying on the resource recreation to take care of things. Should not be hard to change, I might have a crack at it, if time permits.
'I did some digging, and is currently needed, but AFAICS it is no longer needed.' I meant to say, one can change security groups on running instances, but removing 'ForceNew' will not automagically work.
knuckolls has quit
knuckolls joined the channel
rmenn joined the channel
pmoust joined the channel
kkvlk joined the channel
kkvlk has quit
andrewwatson has quit
knuckolls joined the channel
kkvlk joined the channel
kkvlk has quit
rbowlby joined the channel
platonic has quit
a_ro joined the channel
-it does after applying my patch, but I'll have to polish it a bit, before it's PR ready
rbowlby has quit
pmoust has quit
pmoust joined the channel
platonic joined the channel
platonic has quit
mosheroperandi has quit
kkvlk joined the channel
kkvlk has quit
pmoust has quit
pmoust joined the channel
pmoust_ joined the channel
pmoust has quit
svanharmelen
luminous: guess your right about that one… For AWS this (setting the name) is kind of nasty, but that is because of how the AWS API works…
Most other resources (e.g. CloudStack and Google Compute instances, Heroku apps, DigitalOcean droplets) just have a `name` argument to set the name…
rmenn has quit
rmenn joined the channel
pmoust joined the channel
pmoust__ joined the channel
pmoust_ has quit
pmoust has quit
platonic joined the channel
pmoust__ has quit
pmoust joined the channel
kkvlk joined the channel
kkvlk has quit
pmoust has quit
pmoust joined the channel
pmoust has quit
luminous
svanharmelen: nasty is a great name for the AWS api..
I am grateful terraform is taming it for me
platonic joined the channel
platonic has quit
rmenn
Greetings, i see eu-central-1 in aws/config.go but i still see the "Not a valid region: eu-central-1" error, anyone have an idea why this is?
luminous
rmenn: are you using master or release?
rmenn
the release
luminous
rmenn: maybe if you run the latest code from git you will see that work
rmenn
oh really? i was thinking since it was in master it was on the 0.3.5 uild
ah
i see its there only on 0.3.6
my bad
kkvlk joined the channel
rmenn has quit
pmoust joined the channel
kkvlk joined the channel
kkvlk has quit
codepwnie joined the channel
codepwnie has quit
platonic joined the channel
pmoust has quit
pmoust joined the channel
niemeyer joined the channel
andrewwatson joined the channel
catsby joined the channel
platonic joined the channel
platonic has quit
dq86 joined the channel
tennis joined the channel
kkvlk joined the channel
tennis has quit
tennis joined the channel
tennis has quit
kkvlk has quit
tennis joined the channel
tennis has quit
tennis joined the channel
pmoust has quit
pmoust joined the channel
kkvlk joined the channel
skyraider joined the channel
pmoust_ joined the channel
jrnt30 joined the channel
tphummel joined the channel
kkvlk has quit
kkvlk joined the channel
mikedillion joined the channel
mikedillion has quit
rmenn joined the channel
rmenn has quit
rmenn joined the channel
rmenn has quit
rmenn joined the channel
rmenn has quit
rmenn joined the channel
@luminous thanks man, i got something working with the build from master