if looks good on travis, can i merge in the Node stuff? I also have io.js stuff implemented as well
hamiltont
i’ll look at it one more time, one sec
yea, this LGTM
Cool that you didn’t have to touch anything inside of toolset/
ping me when express passes and I’ll merge
ebramanti
word
nothing in toolset necessary
won't be for io.js either
hamiltont: we've gone golden
hamiltont
merged
good work
ebramanti
thanks!
FWBM-bot
[FrameworkBenchmarks] hamiltont pushed 31 new commits to master: http://git.io/vfrjH
FrameworkBenchmarks/master 204f306 Edward Bramanti: Update Koa and fix response headers
FrameworkBenchmarks/master 03c1b81 Edward Bramanti: Updated hapi to 8.4, modules to latest.
FrameworkBenchmarks/master 5a2a675 Edward Bramanti: Switched to sequelize for Node ORM.
hamiltont
Can’t wait for continuous benchmarking to be onelin
I’d love to see what performance difference that PR causes
ebramanti
yeah, no joke the performance should be night and day
the framework updates alone
hapi 7 versions, express 1 version
and the new ORM
hamiltont
Kind of wish there was some metric to calculate impact of commits
funny how like 15 commits can have huge impact
So my thoughts for continuous are to try and re-run historical commits if there is extra horsepower available
meaning we’d get data on performance for all commits in history
and then I could calculate an “impact” score for each contributor
ebramanti
how do we do continuous benchmarking?
hamiltont
that measures how much their commits improved performacne :-P
I’m setting it up, slowly
ebramanti
need some servers
hamiltont
Yea, nbd
That’s problem 2
ebramanti
im about to PR io.js support
finished it up in like 30 minutes this PM
hamiltont
and much easier to solve if you’ve got a system setup that’s ready to use them
Great great
FWBM-bot
[FrameworkBenchmarks] ebramanti-techempower opened pull request #1577: Io.js support for Node frameworks (master...add-iojs-support) http://git.io/vfovy
hamiltont
ebramanti: LGTM, added a few requests for metadata modifications but the code is fine
If you have time to dump in the metadata changes before leaving for the weekend then I can keep an eye on the PR and merge before monday if it goes green
if not someone will just get to it mon
ebramanti
yeah, im about to head out
let's get to that monday then
ebramanti has quit
FWBM-bot
[FrameworkBenchmarks] hamiltont deleted silex-raw-720 at a0db1ca: http://git.io/vfotF
[FrameworkBenchmarks] hamiltont deleted revert-1311-master at 8bf14c0: http://git.io/vfoqu
[FrameworkBenchmarks] hamiltont opened pull request #1578: Add digitalocean to vagrant setup (master...vagrant-add-digitalocean) http://git.io/vfooo