[FrameworkBenchmarks] snoyberg opened pull request #1086: Updates to Yesod and WAI (master...master) http://git.io/3VFzAw
alex-techempower has quit
77CAAIKF2 joined the channel
[FrameworkBenchmarks] msmith-techempower closed pull request #788: fix(Yesod): Resolve dependencies and change executable filename in cabal... (master...master) http://git.io/mF-kUQ
[FrameworkBenchmarks] msmith-techempower pushed 6 new commits to master: http://git.io/XgPRhg
FrameworkBenchmarks/master d647df3 Michael Snoyman: Some Yesod cleanup/optimization...
FrameworkBenchmarks/master 1ce2175 Michael Snoyman: Use stylish-haskell on yesod.hs
FrameworkBenchmarks/master 47ba68e Michael Snoyman: Reduce library dependencies in yesod
GHellings
:-/ According to travis about half or more of these tests don't pass. All I did was update the PHP version, but tests across all languages are failing miserably
TE-msmith
that was happening before
if you update anything outside of the frameworks/ dir, travis runs all the tests
you can test your changes specifically by commenting out all the travis lines except that ones that interest you (just remember to uncomment those lines on your last commit to the PR)
anyway - that travis run was only run against wai/yesod (you can tell by the duration; anything less than 10m means that the test spun up, decided it didn't need to be run, and returned a success value; this allows us to see rather quickly whether a pull request breaks anything)
GHellings
I figured something must be cached in there. Nice.
TE-msmith
as I mentioned before, if you have files that changed beneath the frameworks dir and that's it, it will attempt to ONLY run those tests
from that one i linked, all the files edited were either under Frameworks/Wai or Frameworks/Yesod
so when travis kicked off, those were the only two that took the time to verify, all the others "succeeded"
when you eventually create your pull request, mind that if you have changed anything outside of the frameworks dir (say, in the setup dir) then ALL the tests will get kicked off on travis
this is a problem because many of them are failing and it will take 24hours to run
GHellings
Yep, which is what I had to do in order to update the base version of PHP that gets run
Lots of those tests are failing out of the box anyway
TE-msmith
yeah
the PHP tests are all failing, and I have no idea why (though, I haven't spent any time looking into php specifically)
GHellings
For me, upwards of 75% of all tests in all languages fail in some capacity.
also, these were after ashneider fixed (attempted to fix) the postgresql bugs; there is currently a problem with the install script keeping postgresql from being installed/configured correctly, so any test relying on that fails
GHellings
That could be a major source of pain for the PHP tests. What's the problem with postgres install?
I did notice some issues in my work where postgres was puking because the install was assuming 9.1 instead of 9.3
Or maybe vice-versa
TE-msmith
yeah, i'm not recalling specifically
the installation is expecting 9.3 on ubuntu14 as a minimum... i think
and travis currently only supports ubuntu12 and therefore postgresql 9.1
so there might be a problem there
GHellings
I ran into that same problem when I was testing
TE-msmith
oh actually
i'm looking at the logs on travis right now and it's using postgresql 9.3
so I think that issue is resolved, but we still have a stale build using the broken postgresql setup