let's not simply disable it - can we improve the situation so that its job reports pass because there is nothing to run?
that way, if they add a mono thing to their benchmark_config in the future, the current one will still "pass" because there is nothing to run, but the mono build will still try and run
(at some future date when we are running all the tests of a given dir)
hamiltont_
Perhaps. Can it run on linux?
I think that's why it errored
Not because of mysql
Yea, it has no test taht can run standalone on linux
So travis can't help us here
TE-msmith
right
but right now, run-tests actively fails because the test it's trying to run specifies "OS=windows" and our OS is set (by default) to linux
what if we changed it to have an exit code of 0 in that case - nothing was run so nothing failed
that would allow HttpListener to, in the future, have an additional test where it runs on Mono and specifies linux as the os
hamiltont_
Oh hmm
I see your point
Sure
Although
perhaps it's better to add it back into travis if linux support is added
because if I add it in now...
it's going to waste time and resources for every build
launching a new VM, just to return pass
Seems an easy thing to not forget to add - when someone puts in a PR to add linux support and travis doesn't run, that's a pretty good reminder to add it to the .travis.yml file
TE-msmith
I'm confused
hamiltont_
Letting HttpListener run on Travis is basically a big waste of time and compute resources
TE-msmith
"big"?
basically, you're saying that HttpListener simply won't have a travis job
hamiltont_
lookat at an extra 30 seconds to 5 minutes (depending on travis' speed) for that HttpListener job
we are looking at an extra*
TE-msmith
and if in the future a mono test is added, it will be on the head of whoever is handling pull requests to know and add the travis job, but only for the mono test
but I think that time spent in the general case for the tradeoff of needing less hand-holding (and edge-cases) during merging pull request is a good trade-off
okay - but what do we do after we implement "run all tests for this directory"?
and HttpListener has a mono test
hamiltont_
Just add that one line?
TE-msmith
but the windows test will fail
like it did 10m ago
hamiltont_
Nope
TE-msmith
and we will have to add in the logic I mentioned about "if benchmark_config.os != host.os, pass" anyway