#solum

but then we have to tell users that they cannot create lp with the name 'no-languagepack'

yes

to be honest, I don't think any one names their languagepack as no-languagepack

other option is, let's keep the current code for now and file an improvement bug

agree that why would anyone name their lp as 'no-languagepack'

or, let me see if I can introduce a separate flag

if it turns out that that is too much of effort/change then we can keep the current approach

thoughts?

probably it may not be big thing in terms of code change perspective, but it seems introducing another flag makes the app file size to increase

in my view, more fields in app file means more complexity

as much possible, let's keep the app file small

in that case lets go with the current approach, I can add a check in lp create to not allow lps with names 'true' and 'false'

what say?

that's fine

when I was reviewing the code, I was confused because of false

after reviewing the client code, I realized that we are passing false as a languagepack name

so I thought, people just reading the server code may run into same confusion

since we have cli patch and service patch linked together here, quickly I was able to realize what is going on

ah I see

but if you are just looking at the server side code, languagepack name as 'false' would most likely confuse.. may be it may not be that big of an issue

Vijendar Komalla proposed openstack/python-solumclient: Donot allow uppercase letters in app name https://review.openstack.org/312686

devdatta-kulkarni proposed openstack/solum: Add checks to delete app artifacts from appropriate backends https://review.openstack.org/312695

Swati Dewan proposed openstack/solum-dashboard: Get the solum-horizon plugin working again https://review.openstack.org/289021

Vijendar Komalla proposed openstack/solum: Make sure app name contains valid characters https://review.openstack.org/312708

devkulkarni: hey! finally passed the jenkins gates :D

pt_15: cool.. what was the change that you had to do?

pt_15: will review the code soon

devkulkarni: i hadn't kept the comments after each line in the requirements, and for the hacking line, had to change the version

devkulkarni: ok, cool! :)

Vijendar Komalla proposed openstack/solum: Make sure app name contains valid characters https://review.openstack.org/312708

Vijendar Komalla proposed openstack/python-solumclient: Do not allow uppercase letters in app name https://review.openstack.org/312686

Vijendar Komalla proposed openstack/python-solumclient: Do not allow uppercase letters in app name https://review.openstack.org/312686

Vijendar Komalla proposed openstack/solum: Do not allow uppercase letters in LP name https://review.openstack.org/312729

pt_15: still around?

Vijendar Komalla proposed openstack/solum: change workflow status from READY to DEPLOYMENT_COMPLETE https://review.openstack.org/312763

Vijendar Komalla proposed openstack/solum: change workflow status from READY to DEPLOYMENT_COMPLETE https://review.openstack.org/312763

vijendar: you might also want to push a patch that updates the documentation

vijendar: http://docs.openstack.org/developer/solum/getti...

will be inconsistent after above patch is merged

devkulkarni:good point. sure. will do that.

devkulkarni: quick question. is this documentation located in the same repo as code or in different repo

btw, looking at the documentation, the section on 'App configuration and environment variables' also need to be updated with the correct structure/format of the parameter files

its in our solum repo

in docs

devkulkarni: ok. thanks. will do that as well

may be you want to update the documentation to change READY to DEPLOYMENT_COMPLETE in same patch as above

and a separate patch to update the structure of the parameter file in the 'App configuration and environment variables' section

makes sense. will update the patch

sounds good

will update the patch

cool

brb

Vijendar Komalla proposed openstack/solum: change workflow status from READY to DEPLOYMENT_COMPLETE https://review.openstack.org/312763