#solum

devkulkarni: I removed my −1, but keep in mind a −1 isn't a blocker (unless its from Jenkins of course). I can't −2 anything from solum ;)

randallburt: thanks :) .. about -1 .. it was important to me that you are on-board irrespective of whether it is -1 or -2 as you had done the initial patch

devkulkarni: gotcha. Unfortunately I don't think I'll have time to do a thorough test, so I just removed my -1

randallburt: I see. I will test it again before submitting another patch (will also remove that one assert)

k

devkulkarni1: hey!

pt_15: hi

i looked at your review on the patch, but I'm not sure I completely understood what you were trying to say regarding the created_at field coming from the solum-api

pt_15: solum's api side should be setting the created_at field when an app is created. Ideally we should add it to the app database table.. I was under the impression that we have it in that table. But I just checked, it is not there. So the second approximate approach is to set these field in the controller layer of solum. We are currently doing this for assembly (https://github.com/openstack/solum/blob/master/...

so we could do something similar for app

assuming that we make that change on the solum service side, then your cli patch will only have to read off that field from the app object that we receive back in line 852 of your cli patch

ohh ok, alright

so you could submit a patch for solum service to add 'created_at' similar to what is currently done for assembly

hmm, ok, i think i got it

i'll try doing that and will get back to you in case i have any more doubts

:)

pt_15: sounds good

pt_15: your devstack is still not working, right?

yeah, still not working :(

ok, and the last error was this: http://paste.openstack.org/show/475225/

yeah

devkulkarni1: how do I submit a patch in solum as well as python-solumclient for one bug?

pt_15: best is to make a separate bug in solum and refer to that in the commit message for the solum patch

you can create solum bug here: https://bugs.launchpad.net/solum/

provide a good description and assign it to yourself

ok, alright :)

randallburt: I re-verifed. If some exception is raised from within solum, pecan sets response.status_code to 500 and the wrapper translates the exception message as intended. And for actions that don't lead to any exceptions, the api log does not contain a exception line (which is what my patch is fixing).

devkulkarni1: excellent!

devkulkarni1: also, can I submit a patch in python-solumclient before the one in solum gets merged, since it depends on that?

pt_15: good point. we should get your solum patch merged first; if you submit next version of the python-solumclient patch, then mark it as 'Work-in-progress (WIP)' by selecting the appropriate radio button on the review. that way, we won't merge this patch before the patch on the service side is merged.

oh ok, cool :)

devdatta-kulkarni proposed openstack/solum: Fixing bug in wsme_pecan exception wrapper https://review.openstack.org/230115

pt_15: once you create the bug, could you share the link with me here

pt_15: good bug description.. nice

devkulkarni1: thanks :)

Swati Dewan proposed openstack/solum: Added created_at attribute on creation of an app https://review.openstack.org/231146

Swati Dewan proposed openstack/python-solumclient: Added created_at in the output of solum app cmds https://review.openstack.org/230692

Swati Dewan proposed openstack/python-solumclient: Added created_at in the output of solum app cmds https://review.openstack.org/230692

devdatta-kulkarni proposed openstack/solum: Fixing devstack setup https://review.openstack.org/230222

devdatta-kulkarni proposed openstack/solum: Updating docs to reflect introduction of app https://review.openstack.org/230628

devkulkarni: hey, so what should I do now while waiting for reviews on my patches?

pt_15: try to get your devstack environment working..

I am trying a few things, but you might also keep on trying

google around

try to get a feel for what is devstack, how it works, etc.

we need you to have a working devstack environment

you can also look through solum bug list

you won't be able to triage them without a devstack environment

but you will still be able to start understanding current issues

devkulkarni: ok, great, i'll google around and also take a look at the solum bug list :)

and sorry for the late reply