`WebDriverException: Message: Parameter 'duration' was not a positive integer`
lucast
ha
that's strange since it's supposed to be multiplied...
kpschmid_
simonstewart: barancev: The custom RemoteWebElement class "wraps" calls to findElement to find an element that could exist in a nested frame(s)
barancev
kpschmid_: you walk deep through all nested frames and their subframes and loko for elements with the given locator?
*look
lucast
ah that's a bug...
kpschmid_
barancev: correct
barancev
kpschmid_: well, give me some time, on Monday I hope to create a wrapper around public API that implements this feature
kpschmid_
barancev: Did you look at my gist?
niQo has quit
barancev
kpschmid_: yes, I just wanted to clarify the intention
kpschmid_
barancev: This approach of overriding JsonToWebElementConverter.newRemoteWebElement() has worked very well for us for several years
barancev
because you also told about "gui maps", it's a different feature
simonstewart looks at ProtocolConverterTest
simonstewart weeps a little
kpschmid_
barancev: Ignore the guimap stuff, not looking for a "new" feature, just have the override working again
barancev
kpschmid_: simonstewart is working on the fix :)
kpschmid_: but I'm going to suggest you an alternatve solution based on public API
kpschmid_
barancev: I'm a little confused as to how overriding JsonToWebElementConverter.newRemoteWebElement() is not "public"?
barancev
it's protected, at least :)))
kpschmid_
It *was* changed to private in 3.4.0 and then changed back to protected in 3.5.x
barancev
hope simonstewart fill fix it
simonstewart
Working on it
barancev
but I'd suggest to deprecate it and remove soon :)
kpschmid_
simonstewart: barancev: understand
barancev
it was a *bad* idea to implement this injection hook
kpschmid_
barancev: Unfortunately, the person that implemented our framework leveraged it dating back to 2.x and looks like some extensive refactoring to "un-do" this ditty
Selenium-Github
[13selenium] 15natelowry opened pull request #4624: fix typo in docs for driverExecutableFileName (06master...06patch-1) 02https://git.io/v5RU0
barancev
kpschmid_: I mean us, selenium devs, bad idea to provide this hook, to make it available to end users
lucast
apailthorp-sl: it appears there's lots of multiplying going on in the python bindings... which is why you're probably seeing it sit there for a long time
errant_rider has quit
Selenium-Github
[13selenium] 15shs96c pushed 2 new commits to 06master: 02https://git.io/v5RTv
13selenium/06master 14d80f86d 15Simon Stewart: Revivify the ProtocolConverterTest
13selenium/06master 14c8f6bf9 15Simon Stewart: Move element converter so it's only used in RemoteWebDriver...
apailthorp-sl
@lucast strangeness abounds, getting hangs in places I don't think much is going on in. Not feeling warm and fuzzy about geckodriver.
simonstewart
barancev: I bet it made sense at the time
barancev
sure, all decisions have resons
lucast
the pause issue would be python's fault (at least until i diagnose it further)
apailthorp-sl
going to let this thing sit while I go get a burrito. Maybe it will throw a useful error if I wait long enough and spin in my chair three times.
adamp joined the channel
simonstewart
Pushed the fix
adamp
Hi, does anyone know if it's possible to reconnect to a previously existing remote webdriver session?
I've been looking in the group and a lot of googling but I can't get a straight answer
kpschmid_
simonstewart: Thank you
js-sl
adamp, I don't remember if it was you or someone else, but yes it's technically possible (I don't remember how) but it's not advisable to do AFAIK.
adamp
ok, I've been able to get it working with the python bindings by setting driver.session_id however in the java world the set session functions are protected - so yeah it doesn't look like they're meant to be exposed
simonstewart
adamp: if you know the session id it's possible
adamp
yeah I have the session id, that's easily available. I'm just not able to use it to force a remote webdriver to latch onto the existing session. Are there any java api examples out there does anyone know?
I can see there's a setSessionId function: setSessionId(String) - Method in class org.openqa.selenium.remote.RemoteWebDriver
but it's protected not public
lucast
apailthorp-sl: i'm not getting any hanging issues that you were
what version of geckodriver do you have?
apailthorp-sl
@lucast 0.18
64 bit on Ubuntu
cristi joined the channel
lucast
same here
apailthorp-sl
not consistent, hung near the end of test suite before lunch, now hung at start. If I break and restart betting I will get another example, but different.
maeriens-sl has quit
simonstewart
I wonder if it's safe to turn the AlertsTest back on