#readthedocs

hello, I am looking for the wipe button but can't see it (https://docs.readthedocs.io/en/latest/builds.ht...)

I have a project that's broken because it pulls a python 3.5 version that < 3.5.3 and it uses aiohttp that requires 3.5.3+

I guess rtd has 3.5.3+ since aiohttp is built there? just a guess

oh mmm. looks like adding .readthedocs.yml

does the trick. sorry for the noise

Hi Everyone, something changed about 3 days ago that is causing build failures in projects that have submodules loaded. It says "One or more submodule URLs are not valid." we use relative submodule URL paths to clone. has some kind of check been put in place that no longer allows relative URLs?

here's an example https://readthedocs.org/projects/opendaylight/b...

the logs don't really tell very much and it appears like it successfully cloned ....

Hi, OPNFV docs builds are failing with "One or more submodule URLs are not valid" - https://readthedocs.org/projects/opnfvdocsdemo/...

this is something we deployed last week

probably best to open a ticket about it

Will do. Thanks agj!

the cause is you have submodules somewhere on your tree that aren't passing our validation

we're shooting for a deploy today though, so hopefully can squeeze a fix in

agj: https://github.com/rtfd/readthedocs.org/issues/...

bramwelt: the problem is due to the fact that you have/had(?) relative path submodules, those are now disallowed

we get this through gitpython though, something might not be detected here correctly

agj: We can't actually fix that though. The relative paths are set by Gerrit...

agj: And git-submodule supports relative path submodules.

we don't though

any idea why those are relative?

ie - not a full url?

this doesn't seem like it should be working at all

bramwelt: not all of your submodules are relative urls

ie - docs/submodules/clover

agj: The url is relative to the superprojects origin.

agj: For example with clover, opnfvdocs origin is https://gerrit.opnfv.org/gerrit/opnfvdocs.git, clover's url is '../clover' which translates to https://gerrit.opnfv.org/gerrit/clover

agj: It all was working up till aboug 3 days ago.

for clover, the submodule points to a full url, not a relative path

Ah, sorry clover is a bad example then.

at least this is the parsing i'm seeing through gitpython

`../armband` for example then

but yeah, there are others like that -- but i didn't think that would work

It does. :)

okay yes, we should pump the brakes on our validation there

git states the behavior you're mentioning and not the behavior we don't want here (being able to set a submodule up a path from your repo on disk)