#readthedocs

/

      • RTDGitHubBot joined the channel
      • NOTICE: [readthedocs.org] agjohnson created add-project-container-image (+1 new commit): http://git.io/vsFYO
      • NOTICE: readthedocs.org/add-project-container-image 277e9c0 Anthony Johnson: Add per-project, admin-only container image configuration...
      • RTDGitHubBot has left the channel
      • RTDGitHubBot joined the channel
      • NOTICE: [readthedocs.org] agjohnson pushed 1 new commit to lint-raise-profile: http://git.io/vsFH7
      • NOTICE: readthedocs.org/lint-raise-profile 7efda25 Anthony Johnson: Bump minimum docstring length on constructs to 20 lines...
      • RTDGitHubBot has left the channel
      • RTDGitHubBot joined the channel
      • NOTICE: [readthedocs.org] agjohnson deleted remove-project-artifacts-from-all-web at fa95102: http://git.io/vsF58
      • RTDGitHubBot has left the channel
      • f10w has quit
      • f10w joined the channel
      • RTDGitHubBot joined the channel
      • NOTICE: [readthedocs.org] ericholscher pushed 1 new commit to master: http://git.io/vsbqo
      • NOTICE: readthedocs.org/master 4a53579 Eric Holscher: Merge pull request #1596 from rtfd/add-project-container-image...
      • RTDGitHubBot has left the channel
      • RTDGitHubBot joined the channel
      • NOTICE: [readthedocs.org] ericholscher pushed 1 new commit to master: http://git.io/vsbqH
      • NOTICE: readthedocs.org/master 3747975 Eric Holscher: Merge pull request #1580 from rtfd/lint-project...
      • RTDGitHubBot has left the channel
      • RTDGitHubBot joined the channel
      • NOTICE: [readthedocs.org] ericholscher pushed 1 new commit to master: http://git.io/vsb38
      • NOTICE: readthedocs.org/master 0b012cd Eric Holscher: Remove duplicate dnspython req. Fix #1593
      • RTDGitHubBot has left the channel
      • RTDGitHubBot joined the channel
      • NOTICE: [readthedocs.org] ericholscher pushed 1 new commit to master: http://git.io/vsbGR
      • NOTICE: readthedocs.org/master 1c1b2ab Eric Holscher: Merge pull request #1582 from rtfd/document-setup-install-with-requirements-file...
      • RTDGitHubBot has left the channel
      • keimlink joined the channel
      • gregmuellegger joined the channel
      • gregmuellegger has quit
      • gregmuellegger joined the channel
      • RTDGitHubBot joined the channel
      • NOTICE: [readthedocs.org] ericholscher created dont-support-readme-copy (+1 new commit): http://git.io/vsbVV
      • NOTICE: readthedocs.org/dont-support-readme-copy f93f3e8 Eric Holscher: Delete logic that copies README....
      • RTDGitHubBot has left the channel
      • RTDGitHubBot joined the channel
      • NOTICE: [readthedocs.org] ericholscher pushed 2 new commits to dont-support-readme-copy: http://git.io/vsbri
      • NOTICE: readthedocs.org/dont-support-readme-copy 0479644 Eric Holscher: Support setting master_doc based on index file
      • NOTICE: readthedocs.org/dont-support-readme-copy d7fe1d9 Eric Holscher: Return 'index' properly when it exists
      • RTDGitHubBot has left the channel
      • RTDGitHubBot joined the channel
      • NOTICE: [readthedocs.org] ericholscher pushed 1 new commit to dont-support-readme-copy: http://git.io/vsbPx
      • NOTICE: readthedocs.org/dont-support-readme-copy a7e7ad3 Eric Holscher: Clean up conf.py.conf file
      • RTDGitHubBot has left the channel
      • RTDGitHubBot joined the channel
      • NOTICE: [readthedocs.org] ericholscher pushed 1 new commit to dont-support-readme-copy: http://git.io/vsbX3
      • NOTICE: readthedocs.org/dont-support-readme-copy 5385f2f Eric Holscher: Add comment
      • RTDGitHubBot has left the channel
      • c74d3 joined the channel
      • e9t__ joined the channel
      • sebbu has quit
      • e9t__ is now known as e9t_
      • adamdangoor has quit
      • adamdang_ joined the channel
      • adamdang_ has quit
      • jodal joined the channel
      • keimlink has quit
      • ericholscher joined the channel
      • keimlink joined the channel
      • keimlink has quit
      • gregmuellegger has quit
      • adamdangoor joined the channel
      • keimlink joined the channel
      • sebbu joined the channel
      • sebbu joined the channel
      • kuldeepdhaka has quit
      • ojii joined the channel
      • ojii has quit
      • untitaker joined the channel
      • armenzg joined the channel
      • ojii joined the channel
      • blazar joined the channel
      • takotuesday joined the channel
      • blazar has quit
      • takotuesday
        Hey guys, I was just looking into how the downloads on the downloads page are sourced and I came accross what looks like a duplication of code: https://gitlab.factset.com/analytics-infrastruc... and https://gitlab.factset.com/analytics-infrastruc.... Im curious if there was a design decision to have both Projects and
      • Versions have a get_downloads method, when they appear to do the same thing. Is this something that might could use refactoring?
      • blazar joined the channel
      • keimlink has quit
      • RTDGitHubBot joined the channel
      • NOTICE: [readthedocs.org] agjohnson pushed 6 new commits to master: http://git.io/vsxd9
      • NOTICE: readthedocs.org/master f93f3e8 Eric Holscher: Delete logic that copies README....
      • NOTICE: readthedocs.org/master 0479644 Eric Holscher: Support setting master_doc based on index file
      • NOTICE: readthedocs.org/master d7fe1d9 Eric Holscher: Return 'index' properly when it exists
      • RTDGitHubBot has left the channel
      • RTDGitHubBot joined the channel
      • NOTICE: [readthedocs.org] agjohnson pushed 1 new commit to docker-fix-mounts: http://git.io/vspYA
      • NOTICE: readthedocs.org/docker-fix-mounts 1f1bf20 Anthony Johnson: Prefix sphinx doc_builder constants
      • RTDGitHubBot has left the channel
      • hey agj, I was just looking into how the downloads on the downloads page are sourced and I came accross what looks like a duplication of code: https://gitlab.factset.com/analytics-infrastruc... and https://gitlab.factset.com/analytics-infrastruc.... Im curious if there was a design decision to have both Projects and
      • Versions have a get_downloads method, when they appear to do the same thing. Is this something that might could use refactoring?
      • agj
        quite possibly, there is a lot of logic in project/versions that needs refactor
      • i can't see you links though
      • i'd bring it up on the issue tracker for discussion, and link to our source
      • takotuesday
        ack
      • let me send you the right links :)
      • https://github.com/rtfd/readthedocs.org/blob/ma...
      • sounds good
      • I wanted to check before filing an issue, thanks for the feedback agj
      • agj
        yeah, that can likely be refactored, I'm not sure if there is any reason for the split, or what pretty does in the Version.get_downloads
      • takotuesday
        yeah it looks like pretty just checks for uppercase strings of PDF, EPUB, etc
      • its odd
      • issue created though https://github.com/rtfd/readthedocs.org/issues/...
      • RTDGitHubBot joined the channel
      • NOTICE: [readthedocs.org] agjohnson pushed 1 new commit to vendor-bundle-fix: http://git.io/vspwU
      • NOTICE: readthedocs.org/vendor-bundle-fix 26f27dd Anthony Johnson: Prefix application bundles with application name...
      • RTDGitHubBot has left the channel
      • RTDGitHubBot joined the channel
      • NOTICE: [readthedocs.org] agjohnson force-pushed docker-fix-mounts from 1f1bf20 to e810dde: http://git.io/vspP8
      • NOTICE: readthedocs.org/docker-fix-mounts 648915d Anthony Johnson: Add mount for missing template path in docker container creation...
      • NOTICE: readthedocs.org/docker-fix-mounts e810dde Anthony Johnson: Prefix sphinx doc_builder constants
      • RTDGitHubBot has left the channel
      • armenzg has quit
      • RTDGitHubBot joined the channel
      • NOTICE: [readthedocs.org] agjohnson pushed 1 new commit to master: http://git.io/vshJZ
      • NOTICE: readthedocs.org/master 1410bd2 Anthony: Merge pull request #1587 from rtfd/docker-fix-mounts...
      • RTDGitHubBot has left the channel
      • c74d3 has quit
      • c74d joined the channel
      • keimlink joined the channel
      • adamdangoor has quit
      • blazar has quit
      • adamdangoor joined the channel
      • ojii has quit
      • takotuesday has quit