considering adding it to that file usually means work for me... and I don't use dash
x58
I liked Dash at one point, but then it became nasty shareware that didn't work right on the docsets I was already using.
raydeo
RELEASING.txt is a one-man affiar generally
github joined the channel
github
[pyramid] stevepiercy pushed 2 new commits to 1.6-branch: http://git.io/vBRNE
pyramid/1.6-branch 3bf245b Steve Piercy: backport master to 1.6-branch
pyramid/1.6-branch ab49af1 Steve Piercy: Merge pull request #2153 from stevepiercy/1.6-branch...
github has left the channel
stevepiercy
ok, i wasn't super excited about it myself, i'll close the PR
raydeo
ah fun... damn I don't like a lot of our tests
there's such an anti-integration testing stigma in our official projects
I feel like any time I get into them and look at the tests there's so much mocked out that it's hard to tell what's going on
like earlier this week when I got into pyramid_nacl_session and the tests weren't even using nacl's SecretBox
x58
lol
raydeo
or now in pyramid_tm where I write literally one integration tests that tries the tm on a real request and it fails immediately on pyramid 1.2/1.3, despite lots of tests testing the feature that fails because just too much is mocked out
x58
Remember that fix I was trying to make where I was complaining about the tests not actually testing a code path?
raydeo
yeah
x58
That's cause so much was mocked out that it was incidentally testing it.
But in a way that didn't properly test that the functionality was correct
it just happened to hit the code path and thus be covered.
raydeo
yeah not shipping a single integration test is a big no no to me
I agree using unit tests for all the corner cases is great... but you've gotta make sure the damn thing actually works
x58
So would pyramid_tm even work on 1.3?
raydeo
not atm!
well
x58
I'm surprised we haven't had any complaints about it.
raydeo
it's supposed to work on 1.3, dunno what's going on
but it's definitely broken on 1.2
despite us having tox explicitly test against 1.2 ;-)
x58
special.
raydeo
but it also seems like the request property isn't working on 1.3 :(
honestly not sure why 1.3 is broken atm
skalfyfan has quit
set_request_property seems to not be working or something
x58
How are your getting your request object
?
raydeo
webtest
router
x58
Gotcha.
raydeo
test is literally just sending a request into a dummy app