I've given up reading it after 20 mins, SignedCookieSessionFactory seems to be ok, that big red warning is a bit too much possibly. as read in the discussion, CSRF shouldn't be a problem if it's in a cookie
[pyramid] stevepiercy pushed 2 new commits to 1.5-branch: http://git.io/vlPze
pyramid/1.5-branch d88b3fa Steve Piercy: minor grammar, fix .rst markup, rewrap to 79 columns...
pyramid/1.5-branch 06587db Steve Piercy: Merge pull request #2074 from stevepiercy/1.5-branch...
github has left the channel
tisto has quit
tomeff has quit
tomeff_ is now known as tomeff
Loetkolben joined the channel
atomekk joined the channel
atomekk joined the channel
areski joined the channel
porkpie has quit
mr_jolly joined the channel
tisto joined the channel
Charlie_X
Ergo: nice
stevepie_
morning
mr_jolly has quit
[d__d] has quit
-- BotBot disconnected, possible missing messages --
[d__d] joined the channel
NOTICE: [freenode-info] channel trolls and no channel staff around to help? please check with freenode support: http://freenode.net/faq.shtml#gettinghelp
Specifically, it seems to me that to enable overriding settings further (by user code) we _should_ call .commit() at the end of this method witch is opposite of what's stated in these comments.
"(...) the following registrations should be treated as analogues of methods called by the user after configurator construction" If so then shouldn't we call submit() to give a chance to override those? If we do not call commit() that further registrations would "compete" with default ones thus creating conflicts instead of overriding default registrations.
What am I missing here?
utek joined the channel
hyperknot joined the channel
Zart
to override user stuff with user stuff you should commit() in-between
see lines 385-385?
*385-386
if there were no self.commit(), then calling config.add_view(... Exception) would result in conflict
or you had to call config.commit() right after constructing it
mr_jolly has quit
tomeff has quit
Arfrever joined the channel
pdobrogost
Zart: Ok, but what's different about the rest of calls that commit is not called "for them"?
tisto joined the channel
sakal joined the channel
Zart
those are provided by user itself
tomeff joined the channel
exceptionresponse_view is added by framework, while other stuff is taken from Configurator constructor arguments
you are not expected to register same stuff twice 8)
plamut has quit
ie, you'll get conflict if you try to add something you already provided to configurator
Zart: Do you have idea why code at the end of comment https://github.com/Kotti/Kotti/issues/475#issue... does not trigger "pyramid.exceptions.ConfigurationError: "<path-to-override>/locale" is not a directory" error?