rmohr: re kubevirt/cluster/vm-template-fedora.yaml... why "cores: ${{CPU_CORES}}" and "memory: ${{MEMORY}}" are defined with double curly braces when we are not expecting them to be expanded by json subtree.
rmohr: the same question applies to the other two example templates
rmohr
gszasz: I am not sure I can follow
so there are parameters with that name in the template defined
they have these names
the curly braces thell the openshift where to insert them in the tempalte
gszasz
rmohr: there are two way how to define parameter expansion in OpenShift Templates. ${PARAMETER} expands by value (similarly to e.g. bash
rmohr: and ${{PARAMETER}} can be expanded by Json string that defines whole subtree
rmohr
gszasz: ah yes. Has no impact here but should be ${} and not ${{}} good catch
gszasz
rmohr: it does not limit functionality of the template, but it's just confusing
rmohr: can I open anouther PR that fixes it?
rmohr
gszasz: yes please
rmohr is now known as rmohr_lunch
Humble joined the channel
mskrivanek is now known as mskrivanek_away
jniederm_ joined the channel
mkletzan has quit
alukiano has quit
jsuchane has quit
jsuchane joined the channel
alukiano joined the channel
what-a-bot joined the channel
NOTICE: [kubevirt] rmohr pushed 2 new commits to master: https://git.io/vhOyV
NOTICE: kubevirt/master c00e662 Roman Mohr: Move interface-model annotation to annotations...
NOTICE: kubevirt/master 7776ee9 Roman Mohr: Merge pull request #1088 from rmohr/fix-interface-model...
what-a-bot has left the channel
alukiano has quit
what-a-bot joined the channel
NOTICE: [kubevirt] cynepco3hahue opened pull request #1090: Really fix virt-handler test (master...really_fix_virt_handler_test) https://git.io/vhO91
what-a-bot has left the channel
rmohr_lunch is now known as rmohr
alukiano joined the channel
what-a-bot joined the channel
NOTICE: [kubevirt.github.io] scollier pushed 3 new commits to master: https://git.io/vhOQq
NOTICE: kubevirt.github.io/master 1643d4c eldanhildesheim: blog preview html break - fix
NOTICE: kubevirt.github.io/master bbefe1b eldanhildesheim: Adding Pagging for blogs....
NOTICE: kubevirt.github.io/master 4738d93 Scott Collier: Merge pull request #33 from eldan/master...
what-a-bot has left the channel
trown|outtypewww is now known as trown
what-a-bot joined the channel
NOTICE: [kubevirt.github.io] scollier force-pushed master from 4738d93 to 41ed77b: https://git.io/vdgbh