#kubevirt

hello

rmohr: ping re test automation for creating OVM from template via oc command

gszasz: hi

rmohr: hi, I have a question regarding the template being processed by oc command. sgott suggested that it should be created from object to avoid having actual template yaml/json file as a dependency for the test

ah yes, and now you can't find an object, gszasz right?

rmohr: what looks logical to me is to derive a struct from v1.VirtualMachine and then use MarshalJSON to generate template.json file, that can be passed to oc process command as argument.

gszasz: we could also be more agressive and copy the template struct from the openshift codebase

gszasz: then you can send the object with the generic reset client (part of the client we use in the code)

gszasz: https://github.com/openshift/origin/blob/master...

rmohr: my first idea was just having a constant string containing the JSON code (originally I used yaml, after I realized that 'oc process' can parse json as well, that is far more convenient for string variable).

gszasz: my feeling is that it would be better to copy the structs for not-processed templates from there

gszasz: easier to maintain

gszasz: whatever we copy there will always work, since these structs are already "v1" in origin which means that that structure will be supported forever

rmohr: makes sense

gszasz: as a side effecgt we can then also generate our template examples! :)

rmohr: sure :) over last week I used just template yaml from the cluster directory (as I was doing during manual testing) until sgott suggested that test should be as much independent from external files as possible

rmohr: so you suggest to copy-paste Template struct from the openshift's template/types.go into kubvirt's api/v1/types.go

gszasz: right now we only need it for testing. I would prefer /tests/types.go (where the tests are)

rmohr: right, so we will not mess up with actual v1/types.go just to have one functional test. Makes sense.

rmohr: thankk you

lbednar, hi

pkliczew: hi

lbednar, the way we generate kubevirt client seems to be not perfect

lbednar, I opened https://github.com/kubevirt/client-python/issue...

lbednar, once I made changes described in the issue the code works as expected

lbednar, I am using kubevirt deployed on openshift

lbednar, this is something which blocks my work with virt-who so it would be great to have the update soon

pkliczew: thanks for pointing it out, I can take a look .

lbednar, great, thank you!

lbednar, I will continue with my hacked version but to merge it we would need something working

pkliczew: I see

lbednar, here is one more: https://github.com/kubevirt/client-python/issue...

lbednar, did anyone used it before?

pkliczew: see https://github.com/kubevirt/kubevirt/pull/963#i...

lbednar, cool

pkliczew: you can use that call with '_0' suffix

lbednar, this exactly what I am doing :)

lbednar, this could be server side https://github.com/kubevirt/client-python/issue...

lbednar, I opened it to investigate