alukiano, any reservations about merging subresource api?
pkotas is now known as pkotas|gone
jsuchane has quit
jsuchane joined the channel
alukiano
vossel, I think we can merge it, see my comment
vossel
alukiano, alrighty, i'll push the button :D thanks for the review
alukiano
vossel, hh ok
what-a-bot joined the channel
NOTICE: [kubevirt] davidvossel pushed 34 new commits to master: https://git.io/vx2A9
NOTICE: kubevirt/master 846d431 David Vossel: re-introduce virt-api component for subresources...
NOTICE: kubevirt/master d1ef263 David Vossel: Add client/server mutual authentication...
NOTICE: kubevirt/master 3223d04 David Vossel: virt-api should only serve subresource endpoints...
what-a-bot has left the channel
dougbtv has quit
what-a-bot joined the channel
NOTICE: [kubevirt] vladikr closed pull request #846: Filter pod route destined to default gateway (master...filter-gateway-dst-route) https://git.io/vxuWI
what-a-bot has left the channel
vossel, by the merge process, how does it works, do we need approval of two maintainers or one is enough?
vossel, it the reason why I did not merged your PR :)
edwardh1 has quit
vossel
alukiano, ideally we get two eyes on big patches. i felt confident about that subresource patch because i know roman browsed through it as well
alukiano
vossel, ok thx
vossel
i think a single ack by a maintainer on smaller patches is usually fine
alukiano, one problem we have right now is maintainer confidence in test results. I think we're more hesitant to merge because it takes some detailed investigation into the jenkins test failures to be confident the new patch didn't cause a new failure
i know we're working to improve that
alukiano
vossel, agree and openshift make it more complicated:(
vossel
yep, we'll get there :) this functional test stuff is worth it.
jsuchane has quit
jsuchane joined the channel
mzamazal has quit
fromani has quit
marst has quit
marst joined the channel
bkorren has quit
edwardh joined the channel
vatsal has quit
mskrivanek is now known as mskrivanek_away
vatsal joined the channel
jberkus joined the channel
alukiano has quit
biakymet has quit
marst has quit
sbonazzo has quit
ihrachys joined the channel
marst joined the channel
ihrachys_ joined the channel
mskrivanek_away is now known as mskrivanek
jsuchane has quit
gszasz has quit
gbenhaim has quit
mskrivanek is now known as mskrivanek_away
bkorren joined the channel
biakymet joined the channel
biakymet has quit
vladikr has quit
bkorren has quit
lbednar has quit
vladikr joined the channel
sreichar has quit
spr joined the channel
sanjayu joined the channel
jsuchane joined the channel
what-a-bot joined the channel
NOTICE: [kubevirt] davidvossel opened pull request #849: Fix ovm functional test race condition (master...ovm_func_test_fix) https://git.io/vxaMV