#kubevirt

phoracek, we'll be late

fabiand: all good

hey

weekly is strating right now

pkotas, joining?

fabiand: yes here

+1

I'll ask you for an update ;)

vladikr, hey, so here was my thought on the domain xml wiht regards to network

one sec. looking for line numbers as a reference

vossel, ok :)

vladikr, ok, so is it possible to make all the domain xml changes here, https://github.com/davidvossel/kubevirt/blob/ac...

and then make the pre-start hook just setup the environment for whatever is in the domain xml at that point?

looking

basically, domain xml gets network parts during the conversion from VM -> DOmain xml... then later on the hook sets up the environment to reflect what we'd need for the domain xml to actually work

vossel, that's a bit tricky, manly because I know the mac address of the container later in the process

ah, i see

i need to look at your patch

sure

vladikr, ah okay I think i've got it now

you're going to have to set the domain xml again in the prestart hook i think

i'm looking for an example. i had to do that for something else too

vossel, yeah, I do it now in my offline changes

vossel, we could also let networking and storage to update its changes with with updateDeviceFlags(xml) , but the pre-start hook should pass the virConn

or just call dom, err = util.SetDomainSpec(l.virConn, vm, domain.Spec)

if err != nil {

return nil, err

}

regardless, after the pre-start hook run

vladikr, how about this then

the domain spec can get altered in the hook, and the resulting domain is returned from the hook function. in SyncVM where we call the hook, we set the resulting domain spec after the hook function completes

so, we'll just always call SetDomainSpec after the hook on the resulting domain spec

vossel, yeah, sounds good

i can make that change now. I'm rebasing

great!

you'll get it for free when you update

awesome, okay i'll ping you when it goes in

vossel, one other thing I was worried about it how will we handle the defaults in the hook

vossel, but maybe there is a simple way, I just didn't get to it yet

s/it/is

vladikr, i'm not sure I follow the problem there

vossel, I mean, for example, when I set the network xml in the hook, I need to take the correct device defaults into an account

vladikr, okay, i pushed the changes and rebased that branch to the latest master

anything you do to the domain in the hook should now get applied in libvirt right afterwards

you also have access to the fedora disk. look at cluster/vm-fedora.yaml for an example of how to deploy it

vossel, great! thanks, I'll rebase and will give it a try