#kiwiirc

/

      • prawnsalad
        there was a setting that disabled building PRs from forks
      • which is just silly
      • NucWin
        :)
      • i should switch to pull/number format
      • easier to split
      • zoologist has quit
      • gaybox_34415 joined the channel
      • gaybox_34415 has quit
      • Guest47 has quit
      • Guest47 joined the channel
      • Beerbarian has quit
      • Beerbarian joined the channel
      • htietze joined the channel
      • kiwi-n25 joined the channel
      • kiwi-n25 has quit
      • tyzoid: you here?
      • tyzoid
        Yeah, what's up?
      • NucWin
      • jenni
        [ kiwiirc ]
      • NucWin
        issues/154
      • kiwi.state.setting('buffers.formatting_blacklist', ['*']) <--- in console will disable *test*
      • not sure if there is going to be any side effects though
      • tyzoid
        hmm, the '*' chars didn't do anything even before setting that state.
      • NucWin
        rofl it was working fine in dev
      • tyzoid
        NucWin: My main concern is I quite like the backtick substitution, but I'm not fond of the asterisk of underscore substitution.
      • prawnsalad
        youve got is blacklisted by default by the looks of it
      • tyzoid
        I was hoping for a way to disable the latter two while keeping the first.
      • NucWin
        argh i some how broke it when i stash saved and change branch
      • tyzoid
        NucWin: But that seems to be the right idea. Then theoretically, only a settings toggle needs to be added to trigger the addition/removal of the blacklist char.
      • NucWin: Also, the asterisks seem to have been changed to bold, not italic...
      • prawnsalad
        were going to creeate an "advanced" settings table that lsits every setting possible, each one letting you change as needed
      • tyzoid
        (if I disable the asterisk from the blacklist)
      • prawnsalad
        but that type of thing wont have a UI option since its so specific
      • tyzoid
        prawnsalad: How 'bout an about:config like firefox has?
      • prawnsalad
        exactly like that. a table of all options
      • tyzoid
        instant search through that would be nice.
      • seems like Array.prototype.filter is finally getting enough mainstream support.
      • I missed using that at my last job, since we still supported ie<9, and I didn't want to complicate everything with a bunch of polyfills in a legacy application.
      • prawnsalad
        implementation is a minor detail for the time, but yea
      • tyzoid
        prawnsalad: We were still using jQuery 1.2 :/
      • htietze has quit
      • htietze joined the channel
      • Beerbarian has quit
      • prawnsalad
        tyzoid: heh, nothing wrong with jquery for older browser support
      • tyzoid
        but a 11 year old jquery?
      • Talk about old, that was released before I started programming.
      • NucWin
        think its fixed now if you reload
      • tyzoid
        and I've been going at it for a decade :P
      • NucWin
        had put [ '*' ] in state.js to initially test
      • tyzoid
        NucWin: Yeah, that fixes it, but why did '*' go from italics to bold?
      • NucWin
        oh is that back
      • what was you blocking?
      • tyzoid
        ?
      • I wasn't blocking anything. *test* yields bold on the test system.
      • Previously yielded italics.
      • by previously, I mean in previous versions.
      • NucWin
        i think thats the way it is on master
      • prawnsalad
        bold here. and im using a month old version of kiwi
      • the_cia joined the channel
      • the_cia
        *test*
      • *test*
      • tyzoid
        NucWin, prawnsalad: https://znc.tyzoid.com/webchat/ . Select ZNC, user+pass 'test', and network 'freenode'
      • jenni
        [ kiwiirc ]
      • tyzoid
        I haven't yet had a chance to upgrade to the new release
      • so this is still the old kiwi irc
      • prawnsalad
        old as in what version?
      • the_cia
        *test*
      • NucWin
        time to update it and switch to my znc welcome screen :P
      • tyzoid
        I intend to
      • prawnsalad
        guess i should probably look over that extar formatting and compare with others. make sure its all in sync
      • tyzoid
        Old as in before kiwiirc-ng, iirc
      • prawnsalad
        nah thats definately kiwi next
      • tyzoid
        from october of last year
      • might've been the september release
      • prawnsalad
        ah
      • NucWin
        i did have to change the behaviour slightly before when it was extras false it was only advancing pos by 1 casuing it to match twice for ** now it advances token.length as it does when its extras: true
      • Beerbarian joined the channel
      • tyzoid
        idk. I seem to have gotten the nickname 'bug magent' from my coworkers here, though :P
      • NucWin
        tyzoid there was a fix not so long back that made scrollback load a whole lot faster
      • tyzoid
        I don't even think this does scrollback...
      • NucWin
        it not using znc?
      • tyzoid
        It is.
      • prawnsalad
        znc buffer scrollback
      • + nicklists
      • NucWin
        ^^^
      • prawnsalad
        huge performance gains since then
      • tyzoid
        Are you talking about the message log loaded on join?
      • NucWin
        yes
      • tyzoid
        ah
      • NucWin
        now much much faster
      • tyzoid
        I was thinking you were talking about being able to load past messages just by scrolling.
      • (Though, that'd be a cool feature, if it were possible)
      • prawnsalad
        it is. and kiwi supports that. znc module coming up ;)
      • tyzoid is looking forward to that.
      • NucWin: im not understanding your logic for the token parser changes
      • specifically jumping forward by token elngth when extras is disabled
      • NucWin
      • jenni
        [ added formatting_blacklist option to MessageFormatter.js · ItsOnlyBinary/kiwiirc@0ede391 · GitHub ]
      • tyzoid
        NucWin: Found a bug. See the test chat.
      • prawnsalad
        yes that
      • tyzoid
        prawnsalad: Is what I did just a demo of what you were saying?
      • If so, that'd be pretty funny
      • actually, I think it's unrelated
      • prawnsalad
        i was only saying i dont understand why the change was made
      • NucWin
        because when you disabled ** it was they getting matched as *
      • they = then
      • prawnsalad
        ahh gotcha, so '**word**', char1 gets skipped as ** is disabled, then char2 gets matched again as token *
      • ok, makes sense
      • worth adding a comment to explain that there
      • took so long to that parser easy(ish) to follow heh
      • i was playing around with native ios/android dev by re-using all the exiting kiwi js libs. managed to get all the irc + message formatting building the native UI simply reusing what we already have
      • feels good.