#hypothes.is

<nick> @seanh, @robertknight: #2686 bisects to https://github.com/hypothesis/h/commit/9081c931...

<nick> if either of you have bandwidth to look into this I'd really appreciate it, as it appears we have other issues (see #lounge)

<seanh> I'll look into #2686, it'll give me a break from refactoring hundreds of lines of tests over nad over

<seanh> robertknight: About https://github.com/hypothesis/h/issues/2686 , you can create an annotation when not signed in?

<nick> @seanh: I had the same confusion. Just make an annotation. It'll pop up a thing saying "you must be signed in to create an annotation"

<nick> then sign in

<nick> then fill in the text and save the annotation

<seanh> Yep, got it

<seanh> *Wow*

hi, hypothepeeps :)

how's things?

robertknight: still down to google-hang any time you like

<lenazun> hypothepeeps <3

seems like you're way up to speed on so much, though.

<judell> robertknight is a fountain of goodness!

yeah, seems that way :)

<seanh> The _Post_ dropdown also seems to be broken in the case of an annotation that was created while not logged in

<seanh> It ends up saying _Only Me_ even though the annotation might actually be public

<seanh> This is a rough fix for #2686: https://github.com/hypothesis/h/pull/2687

<seanh> Can tidy it up tomorrow, I'm off for dinner now

<robertknight> tilgovi - I'm sure we'll find a time to catch up. There is a lot that would be useful to learn about the history of Annotator etc

<seanh> The code in annotation.coffee, and the way we allow invalid annotations to be created when not signed in, is pretty horrible. Also the fact that we rely on the client to send valid annotations to the server. The client was sending completely invalid annotation permissions, and the server was just happily saving this and then crashing all over the place as long as that invalid annotation remained in the search index

hypothesis/h#8861 (github-2686-fix-invalid-permissions-when-creating-annotations-when-signed-out - 9403f5f : Sean Hammond): The build passed.

Change view : https://github.com/hypothesis/h/commit/9403f5f4...

Build details : https://travis-ci.org/hypothesis/h/builds/87979232

<seanh> I think you can create annotations that anyone (even not signed in) can delete (although if they click the button the server will crash); or alternatively you can create annotations that no one can delete; and annotations that just make the server crash on page load. Fun

hypothesis/h#8865 (v0.7.10 - 6172ee4 : Nick Stenning): The build passed.

Change view : https://github.com/hypothesis/h/compare/v0.7.10

Build details : https://travis-ci.org/hypothesis/h/builds/87994849

<dwhly> Casual observation today: the interface *seems* to be much faster, particularly in the /stream when conducting a new search “user:dwhly". Not sure why. The whole screen seems to just render much more quickly.

<robertknight> nick: So I'm looking through the search change. Looks sensible. As you mentioned, there are two versions of encodeUri{Segment,Query}() and the one that at first sight I'd expect ngResource to be using is correct

<judell> "two versions of encodeUri{Segment,Query}() " so it's a coinflip between a broken one and a proper one?

<robertknight> Ah, what I mean is it doesn't do what you might expect from skimming the code. The change on our end looks fine - just getting my head around what happened upstream.

<robertknight> Oh, I see. So the URL template passed to `$resource()` is encoded using one `encodeUriQuery` implementation specific to ngResource but the parameters that are passed when invoking `SomeResource.$action` are encoded using the default `encodeUriQuery()` implementation which does not encode semicolons.

<robertknight> nick: So might be worth adding a reference to the GitHub issues in the code comments, otherwise LGTM .