<seanh> tilgovi: Thanks, that's helpful. So as long as our two login forms are still working I can refactor that code as I please - there's no other functionality that I'm not aware of
<seanh> I actually quite like view classes in Pyramid the way they're shown in the Pyramid docs - simply as a way to group related view callables together under a class name, and use @view_defaults to avoid some duplication
<seanh> In other words merely as a readability aid, not actually using any of the features of Python classes such as inheritance
vannevar
deploy started: groupsimpl (0000000..f98af11) on dokku.hypothes.is
<seanh> nick: Is the h in a dokku instance installed in a virtualenv? I'm trying to do _ssh mailto:dokku@dokku.hypothes.is|dokku@dokku.hypothes.is run groupsimpl hypothesis admin seanh conf/development.ini_ and getting _ImportError: No module named pyramid_debugtoolbar_, but _ssh mailto:dokku@dokku.hypothes.is|dokku@dokku.hypothes.is run groupsimpl 'pip install pyramid_debugtoolbar'_ (although it runs and installs the package successfully) doesn't help
travis-ci joined the channel
travis-ci
hypothesis/h#7274 (master - ea2c6ca : Randall Leeds): The build was broken.
<seanh> I ended up just showing Conor screenshots so it was fine
<tilgovi> later
<seanh> So a user visits a group's page and they're asked to login in order to join the group
<seanh> Let's say they don't have an account yet
<seanh> So they follow the link to the (new, standalone) login page, register
<seanh> But then they need to get an activation link in their email
<seanh> So my question is at what point do we redirect them back to the groups page that sent them, so they can get the button to join?
<seanh> Do we make the activation link such that after successful activation it redirects them to the group's page?
<seanh> Currently on prod the activation link redirects to the https://hypothes.is/ front page and the user is _not_ logged in
<seanh> :(
<seanh> But I guess that an activation link with a redirect to the group's page is the right flow? Or we just expect the user to activate their account and login and then load the group's page again? They won't have it open in a tab anymore, since in that tab they clicked a link to get to the login/register page. Unless we make that link open in a new tab
<seanh> Ugh, we also don't know if they have installed the bookmarklet or extension yet
<seanh> In conor's new activation flow diagrams, he has them clicking on the activation link in the email and going to a welcome page where the main call to action is to install the extension. It seems what we kind of want in an onboarding-via-group-invite flow is a page that calls them to install the extension and also to join the group which they were invited to in the first place
<seanh> I guess we assume that if they register a new account rather than logging in to an existing one, then we can assume they haven't installed the extension yet
<seanh> Maybe a simpler solution is just to have the login page open in a new tab so that they still have the group's page open in the first tab. Then after registering, activating and logging in we can just expect them to refresh that tab. We can put a message in the page to tell them that. Then later we can make it auto-refresh. Then even later we can design a proper flow for it
<seanh> It's a shame though because if they already have an account but just aren't logged-in then there's a simple flow inside one tab: link to login page, login, redirect back to group page. Although that does require us to refactor the login page code. But also, people who already have an account but aren't logged-in to it are probably a corner-case, the main uses cases are probably already logged in and don't have an account yet
<seanh> So if all the group page is gonna do now is have a link to the login page that opens in a new tab, then we don't need to refactor the login code to support custom redirect URLs
<seanh> I can stop working on that
soundobj has quit
<conor> What does “groups page” refer to? Is it the document where people are annotating or is it a specific group profile page on Hypothesis?
<conor> In a perfect world the user would hit join > be prompted to sign up > receive an activation email > click it, be sent to a simple getting started page where they are already logged in > once they install the extension they are redirected to the group page.
<conor> If they have tried to join the page from clicking a link in the side bar (because it was a proxy link or embed) they should simply hit join > be prompted to sign up > receive an activation email > link sends them to a proxy of the page where they hit join
<conor> I mean, I think. Perhaps some of these things have already been discussed during the prototyping/decision phase but I’m not aware of that stuff
<seanh> conor: It's a specific page for the group on Hypothesis. A URL like http://hypothes.is//groups/xKkqeD/radiohead-fans. It is not so much a "groups profile page" at the moment though, just a page for joining the group (if you haven't already) or getting the link to give to other peope to join the group (if you are already a member)
<seanh> (It's the page I added screenshots of to the Trello card)
<conor> okay, so it’s where the “share group” link takes them?
<seanh> Yes
<seanh> I think the flow you suggested sounds right, but I also think we probably want to punt on that right now and do something simpler like just opening the login page in a new tab maybe
<conor> Perhaps we can improve that page a bit then. If we can render the urls and annotations that are associated with the group then it can become even more useful once you have activated your account. We could make all the links go through the proxy and then just send them an email later with instructions on the different modes
<seanh> I'm not sure if this was realised and discussed in the prototyping phase to be honest, there's nothing about it on the Trello card I have, I may dig around on the dokku prototype and also go looking for google docs
<seanh> Yeah I assume in the future we're gonna improve that page to become more of a groups profile page. But not for this first pass
<conor> okay, simplest thing for the first pass is open it in another tab. I’ll start to look at how we need to do this for release though soon
<seanh> Right, so you're saying that (after getting a group link invite and possibly logging in and registering) they would end up at a group's page that shows links to documents the group has annotated etc, and they are all Via links so they don't need the extension. Then later they get an email telling them about the extension
<seanh> Ok, new tab it is for now
<conor> perhaps. for now though _new tab_ allows us to keep moving.
<conor> better to have something rather than nothing
<conor> I’ll create a document soon that looks at these different flows and then we can build against that
<seanh> Just remember there are (at least) four different flows for a user who gets a group invite link: 1. They are already logged-in and a member of the group 2. They are already logged in 3. They are not logged in, but they do have an account and they log in to it when asked 4. They don't have an account yet, and they register one when asked
<seanh> And in the design so far we don't control that initial invite email. It's just a link which they expect some user to have emailed or IM'd to them
<conor> ok
<seanh> So much hidden complexity, but I'm glad we're making so much progress mapping it out already
<conor> think we just need a picture we can all point at - chat is a bit too abstract
<conor> _onwards!_
<seanh> Pictures++
travis-ci joined the channel
travis-ci
hypothesis/h#7284 (show-orphans - 47cb067 : Randall Leeds): The build failed.