NOTICE: [h] seanh force-pushed building-chrome-extension-docs from c8474f7 to b5554b9: https://github.com/hypothesis/h/commits/building-chrome-extension-docs
NOTICE: h/building-chrome-extension-docs b5554b9 Sean Hammond: Add docs for building the Chrome extension
GitHub87 has left the channel
vannevar
deploy started: stage (a9ebaaf..06278fb) on ip-10-222-217-195.us-west-1.compute.internal
seanh
nickstenn: Yeah, AttributeError
nickstenn
so possibly change the gunicorn PR to check for that rather than _sslwrap
seanh
That fix seems good to me, I'll resubmit
nickstenn
either way, I think tilgovi will want to check that one because I don't have a debian machine running <2.7.9 to test on
GitHub157 joined the channel
NOTICE: [h] seanh created 2273-gunicorn-ssl-crash-2 (+1 new commit): https://github.com/hypothesis/h/commit/7094a495653f
NOTICE: h/2273-gunicorn-ssl-crash-2 7094a49 Sean Hammond: Fix a gunicorn/gevent SSL crash on Python 2.7.6...
GitHub157 has left the channel
seanh
nickstenn: Yeah, and I don't have whatever he's using either (Python 2.7.9 on Debian I guess), so let's wait for him
Alright, I'm stepping out to do a bit of food shopping. Back before 1830.
shepazu joined the channel
shepazu has quit
tilgovi joined the channel
vannevar
tilgovi: nickstenn said at 2015-06-03T00:45:15.924Z: I've pushed a branch to fix-logout that removes ProfileController's dependency on horus. I'll sort the AuthController in the morning.
seanh
nickstenn: I may as well take a look now, context switching away from the Chrome extension anyway
woah joined the channel
woah has quit
travis-ci joined the channel
travis-ci
hypothesis/h#6508 (building-chrome-extension-docs - b5554b9 : Sean Hammond): The build has errored.
To what extent do we want to preserve backwards compatibility of the search API endpoint's params?
It'd be a lot easier if I could just take the documented params https://h.readthedocs.org/en/latest/api.html#ge... and just make sure those still work as they did before, rather than figure out all the other undocumented possibilities
tilgovi
seanh: tough call
if it's undocumented and it's not going to break a feature that's visually apparent in our existing clients, that might be a good threshold for removal
weigh that against the pain of deprecating and keepnig it for a cycle
kfogel has quit
seanh
It's not so much that I'm gonna remove things deliberately
Just that I'm refactoring that code and I might break things without noticing
I'll try to add tests for all the documented and/or obvious or important params
GitHub188 joined the channel
NOTICE: [h] nickstenning pushed 1 new commit to dehorusify-profilecontroller: https://github.com/hypothesis/h/commit/4beb481fa4dd6faf425113306ba98a9737a648d7
NOTICE: h/dehorusify-profilecontroller 4beb481 Nick Stenning: Minor cleanups in h.accounts.test.views_test...
GitHub188 has left the channel
GitHub113 joined the channel
NOTICE: [h] tilgovi pushed 1 new commit to master: https://github.com/hypothesis/h/commit/d99a3ed442ab72f8508c9ae21b8affeb65b091ec