#hypothes.is

aron_: alright, no worries

i'll push it up to stage and see how it goes

yay, random angular issues that don't throw any errors

yay!

nickstenn you resolve the issue?

i'm not entirely sure

because I can't replicate it

every so often when I click "edit" on an annotation the edit form is mangled

it's ok though

because I have another issue that I can replicate

the expand/collapse plus/minus icon doesn't work

in the sidebar only, apparently

ah

no, i'm not sure what's going wrong there

there's a whole host of issues, both behavioural and display

such as the fact that "n replies ... reply, share, edit, delete" is highlighted on hover over the right-hand part of the annotation

but not when you hover over "n replies"

ahhhh

this is the good old digest bullshit again

the plus/minus button does work if you then mouseover something else

the n-replies hover state is an issue with the n replies being outside of the annotation

it's in the thread, which is the element that wraps ti

but then negatively positioned to look like it's inside it obvs

yeah, i know, I've looked at that one befor

*before

what do you mean by mangled by the way?

aron_: i'll see if I can screencap it

aron_: https://i.imgur.com/OSf2KWp.png

Does that have any math in it?

nope

here's the rendered state at that point: https://gist.github.com/nickstenning/59fc7525d3...

i can't give you instructions on how to replicate that other than try editing an annotation a few times...

Ah it's an edit

Something is whack with the permissions on that branch, I cant edit annotations I've created

Oh, I can but I have to trigger a digest :(

aron_: just got your reply

aron_, nickstenning: Are you trying to edit an annotation in a dokku instance?

ujvari yes

ujvari: it's stage.hypothes.is

hmm

dwhly: sorry it wasn't very interesting

aron_: one notable feature of the above screenshot is that the annotation in question is collapsed

so all of this might be related

nickstenn oh haha

on dokku we have a known issue that if you create an annotation with a dokku instance you cannot edit it using an another dokku instance

how's the de-forjing going?

er...

de-dorking

lol

merging

i mean, it wasn't collapsed when i clicked "edit," otherwise there wouldn't have been an "edit" to click

Hey shep

shepazu: good thanks -- we now don't have our own fork of Annotator any more

which is great :)

nickstenn right, and I don't think you can collapse the editor

Oh I see

yay

shepazu: we do still have some monkeypatches and plenty still to do, but we're in a much better position than we were for upstream contributions

aron_: ahhh i think i can replicate this, and I think it is all related

click just a pixel or two to the left of the "edit" icon, and then click on the edit icon

and I would guess it's that the first click triggers a collapse event which doesn't happen because of the digest bug

which in turn wouldn't happen if the "n replies" link weren't positioned in such a stupid way

if you could let me know if you see the same thing I'll take a look at fixing it after lunch

k

nickstenn: yup I can replicate that

aron_: what was the test username you created for checking fabian's problem

i want to compare his and your user accounts

aron.test

cheers

aron_: well that's weird

I can't see what's happening to fabian either, but I can replicate it with his account

multiple reset tokens?

hypothesis/h#4643 (1537-analyse-uri-field - 3b14258 : Gergely Ujvari): The build passed.

Change view : https://github.com/hypothesis/h/commit/3b142582...

Build details : http://travis-ci.org/hypothesis/h/builds/49468743

pushing a debug branch to staging FYI

nickstenn: About the username

you should check this part of the code: https://github.com/hypothesis/h/blob/master/h/a...

ujvari: yep! thanks.

tilgovi: you around?

yeah

nickstenn: pong

so, we apparently normalise usernames with dots in them on lookup

yes

but we don't (or at least didn't) do that when they were created

which is a bit of a bummer

to say the least

I don't fully understand what you mean, but I intuitively understand and was already guessing it was related to the dots

I haven't looked at the code to understand why it's a problem

it's a problem if we have two users in our database called 'foobar' and 'foo.bar'

I would have thought it didn't matter which way it was in the DB because I thought the lookup was agnostic to dots.

that _would_ be a problem indeed!

which is the case

Ugh

which is why i was going to ask

what was the motivation for attempting to normalise dots in the first place?

I don't know how that could be possible given that the registration should do a lookup to determine if it's in use already, and the lookup ignores the dots

Unless it's an old registration

well I suspect once upon a time it didn't

that was done via the PHP on the homepage

yes, it looks like it could well be

well, damn :)

but we might well have plenty of those

we might well have no conflicts other than this person

we should check

in which case we can just fix it by hand and move on

I'm assuming this person is the same person using both usernames?

as far as motivation, I don't know. I did it on a whim.

tilgovi: i'll have a look