May your commits be accepted and your merges conflict-free
_smf_
Thanks - life begins today EyePulp (I'm 40)
EyePulp
_smf_: Looking back wistfully from my advanced years (3 more than yours) I can say... I'm so, so sorry.
=) cheers!
_smf_
Hahahaha
baudehlo: I think I've found a bug in outbound, but I'm not 100% sure as I'm on a really old version.
But looking at the current code; it looks mostly the same.
baudehlo
Cool.
_smf_
If I kill a Haraka child, then it doesn't pick up the queue files of the old PID that died and the queued message count in the master is then wrong.
And the messages don't get retried.
Do you have any recollection of hitting this problem before?
baudehlo
Nope.
I thought that was handled though.
I remember writing code specifically to deal with that.
_smf_
Yeah - me too.
It works if I restart Haraka completely.
Just not if I deliberately kill a child.
baudehlo
It's server.js:cluster_exit_listener
Maybe the exit code logic in there stops it from working?
_smf_
baudehlo: yeah; I'm looking at that now. My other theory is it's a race condition - the new worker isn't listening on the socket when we send the command to load the queue files of the old PID.
SynchroM joined the channel
baudehlo
But it's not a socket is it? I thought it was just an open FD and using send_fd.
Anyway, I'd start with the simple version first and try that.
_smf_
baudehlo: Ok - fixed. It was a bug in my old version. The pid was being pulled from the filename using regexp and then being compared using === against the pid that was passed over the socket. It didn't match because of the string to int.
baudehlo
hah
_smf_
It on my list to upgrade to the latest and greatest now the pool bugs have been fixed.
It's going to be a heck of a job as I've got 65 plugins plus a load of additional things loaded by core.
baudehlo
But I don't recall breaking much API-wise.
But I also have no idea how far behind you are.
_smf_
2.7.3 - so miles.
baudehlo
Jesus, someone is asking me about GDPR and Emailitin.com - holy fuck that directive is a nightmare.
_smf_
Yeah ...
baudehlo
I mean I'm tempted to just say I can't do business with EU members because of it.
Because frankly for the $10k a year it brings in, it isn't worth the hassle to deal with.
_smf_
baudehlo: *nod* - I'm hoping it's one of the first things we ditch post-brexit.
Then again - you're in Canada, so why do you care about GDPR?
Unless I'm completely missing something - you don't have to abide by GDPR unless your company and servers are based in the EU
baudehlo
_smf_: apparently we do.
> The territorial scope of the GDPR is not limited to organizations that have a physical presence in the EU or that are actively targeting customers or users located within the EU. As noted above, regardless of the physical location, the GDPR will apply to businesses that are processing personal data of individuals who are in the EU and where the processing activities are related to: (i) offering goods or services to
an individual in the EU (including goods and services offered at no charge); or (ii) monitoring (e.g., internet tracking and profiling) the behaviour of individuals that occurs in the EU.
_smf_
baudehlo: surely that requires a bilateral deal with lots of countries? Otherwise how are they going to enforce it?
baudehlo
I have no idea. But there's loads of articles on the web about it, and a discussion group with our local CTO group.
Like I said: nightmare.
knutix joined the channel
SynchroM has quit
GitHubBot
[13Haraka] 15luto opened pull request #2360: fix crash when client disconnects during qmail-queue (06master...062359-qmail-queue-crash) 02https://github.com/haraka/Haraka/pull/2360