#haraka

Hey, there was an issue a while back regarding a callback already being called?

does anyone remember which one it was?

Looks like you found it.

Let me know if I can help any with it. It's going to be really hard to track down, but there's some good info in that ticket.

Yeah

I'm looking at every case of callback

it's why I ALWAYS add returns so that it's clear that the function ends at this place

but that's my personal style

Going to have to pull out the whiteboard for this

Yeah returns are good.

Put in that code on that ticket that logs where the previous call occurred from, that should help.

This is somehow related to pools, as it started after I added the pool code.

I think it's caused by hmail.discard

line 591 in finish_processing_mail

there are logs of discards

it looks like there might be a case where it could do discard TWICE

which runes next_cb

runs*

591 in hmail.js*

I remember why I stopped using callbacks

:(

Hah.

But even with promises we'd have to complete them in the right places.

And we'd end up completing them twice, which is the same problem.

that's true

but it just seems easier to manage

and much more visible

For me at the very least haha

well, suck it up, princess ;)

:P

You may be right about the pools

It happened right after a `release_client`

I look like a conspiracy theorist atm trying to debug this

with my whiteboard and sticky notes

[13Haraka] 15msimerson pushed 1 new commit to 06master: 02https://github.com/haraka/Haraka/commit/6d626...

13Haraka/06master 146d626c9 15Matt Simerson: daemon cwd (#2126)...

baudehlo, _smf_, can you guys create a `hacktoberfest` label? I want to start attracting people to contribute