#grpc

ejona: ping?

lukaszx0: I'm around.

git st

lol, sorry

# On branch master

ejona: I've finished UNIMPLEMENTED logic but do you have anything against merging current PR

and I'll create separate for UNIMPLEMENTED?

lukaszx0: I think that sounds fine. Tests were failing due to checkstyle.

ejona: yes, this `git st` was me pushing updates to fix that :) should be green now

lukaszx0: Excellent. And Windows CI has built, so looks good.

and half of travis is green already, too

TRAVIS STARTED BUILDING ALREADY!! <mind blown>

middle of the night in EU, after work hours on both coasts in US

queues are empty ;)

lukaszx0: I'm used to the queues being hours long...

We have OSX/iOS to blame. Travis doesn't support caching.

yeah, I think force-pushes also might be contributing to that

and I'm also one to blame

We'd honestly also prefer to run the tests serially instead of recompiling for the three sets of tests.

That contributes some, but small commits pushed one minute after another don't help, and those are common on main grpc repo.

lukaszx0: Hmm... the "Confirm squash and merge" button seems to change the commit subject.

Except it didn't do that for me in an earlier test...

O.o

weird

if you're talking about my PR, there's also 1 commit

so...

I'm not sure if you've seen, but it also changes the author date. Which I understand, but makes me less comfortable for some reason.

hm, yeah I understand

at least it retains the author! :D

It'd better! I don't want people coming to me asking how things work!

wat

All checks have passed - 6 successful checks

Yay!

We're trying to kill the new flaky tests, too, btw. We kill them, then new ones come :(

lukaszx0: Merged.

Great, thank you!

there you go

ejona: yeah, flaky tests are the worst. I'd love to help but I think I'm still lacking knowledge on internals to be helpful.

lukaszx0: How are you liking modifying the codegen :).

Somebody has to!

It's not bad to be honest

given the fact that those are my first line of cpp that I've ever written :P

lines*

:-D

seriously :)

I'm glad you found your way around. I'd also say it's not too bad. Codegen is required to be a little annoying by its very nature, though.

there's one small inconvenience - every time I change cpp code I need to `rm -rf compiler/build`

also applies to changing protos

Yeah, I've been wanting to fix the gradle tasks to have proper dependencies

I must be doing something wrong

I'm not sure what's missing now.

I'll do `gradle clean build'

I was doing `rm -rf compiler/build && ./gradlew java_pluginExecutable test`

Do you do "up + enter" or "!rm" or search history?

(I assume you don't type that in every time)

up+enter or ctr+r "test"

if it wasn't the last command

nah :P

Luckily, that's the only part of the codebase I find myself needing to do that.

Oh, I run from within the compiler directory, and it will only build the compiler.

If I'm not within the compiler directory I'll do grpc-compiler:build

yeah, I'm also running from within `compiler/`

ohhh I see what you're saying

And I also use this alias:

if I'm in `compiler` I can do clean and it'll clean only compiler

alias gradle='"$(git rev-parse --show-toplevel)/gradlew"'

nice!

Still has the "you must clean" gotcha, but much more memorable commands

yeah, definitely - thanks

Ok man, I think I should head out to bed

it's pretty late here ;)

I think I have some warnings re generic on my PR, will look into that tomorrow

meanwhile you can review it and Carl will probably have opinnions

Sounds good. I'm looking at it now. Please go to bed, your code and head will thank you :)

Hah, that's true!

Later :)

Good night!

Hello my name is Nikhil, I already sent a proposal for HPACK compression efficiency evaluation. And I want to know what kind of preparation should I need for this project

niks_: I'm not sure, and most of the team hasn't started work yet.

but what skills should I need to develop for this project ?

Taking a look at HPACK would be a good first step. I guess also try to build grpc.

but how ? please give me some source for that

For which?

how to get detail about HPACK and how to grpc

HPACK specification is at http://httpwg.org/specs/rfc7541.html

how to build grpc ?

For building, look at INSTALL.md

You don't need to know every detail about HPACK at this point, but it would be good to get a rough idea of how it operates.

ok. Thank you very much. :-)

Sure.