#gocd

65 character limit on the Admin email!!

we use Victorops which provides an auto-generated email endpoint that can exceed 65 chars, depending on your routing key

tedbot: yuck!

(re: the limit)

filing a bug

or maybe submit a PR...hmmm

arvindsv: thanks, but the fix should really be in the Server Conf page itself

":maxLength -> 64"

esp since that issue was opened in Nov 2014

makes it an easy PR :)

PR inbound

Sorry, was away. Yes, it should be an easy fix.

arvindsv: https://github.com/gocd/gocd/pull/2269

tedbot: Merged.

oh wow, awesome...ha, I was just writing the test for it b/c I forgot to include one :)

I know. :) I wanted to see if something fails, quick.

If you finish the test, please submit another PR. I'll close the issue once that is done.

sure thing...I'll finish it up now

I'm building it locally and taking a look at it, but there are no real restrictions from the config XML side as well, so I think it should be ok (removal of unnecessary restriction from the client side).

btw, what version of RSpec is used? 3.1+?

I don't think so. https://github.com/gocd/gocd/blob/master/server...

Wait. Let me get you the command that should make it easy for you to run this.

ok, thanks...that'll affect the test syntax

Assuming you've done a: ./bn cruise:prepare, this should work:

cd server; rake --rakefile server/run_rspec_tests.rake spec_file[spec/views/admin/server/index_html_spec.rb]

nice, thanks

arvindsv: alright, looks good: https://github.com/gocd/gocd/pull/2270/files

Can you change this as well? https://github.com/gocd/gocd/blob/520cb050903d7...

yes indeed

update coming...I made the mistake of clearing my Maven cache, so I'm busy downloading the internet at the moment

:)

The test failed, when I ran it locally: https://gist.github.com/arvindsv/bf4d75838ff99f...

ah, let me update my deps

I guess the best you can check is that the selector for it has the max length set to 254.

Though I'm not sure what value that test will have.

It's not like we have decided it should be 254 and nothing else, and if someone changes it, it should fail. Right?

well, I'm fine not adding one in with your blessing...I just didn't want to be too presumptuous submitting a PR w/no test

In this case, I don't see any value in repeating that information again in the test. I like to test behavior or facts, and not declarations like this.

ok then, sounds good

Otherwise, we're testing the tag library.

thanks for fast-tracking that PR

You're welcome.

If you can change the from as well, I'll accept that too.

The other one, I mean.

yeah, doing that now

Done: https://github.com/gocd/gocd/pull/2271

Merged. Thanks again!

awesome, thanks to you too