#django

.template_name

in what way was a template not defined?

mar77i: why do you need .template_name?

what is the preferred way to sanitize user input in Django ?

template_name is only used if you set one. otherwise a template name is derived by get_template_names() (which is the whole point of that method)

apollo13: the plan was to use the automatic .template_names everyhwere.

the automatic template name for a createview would be something like app/modelname_form.html (based on apollo13's mention of the suffix) I think, so ... you can that?

kezabelle: yeah, but createview doesn't get a template name from get_template_names(), because self.object is None there and the model would be in self.form.model

it's just inconsequential.

... so set the model on the view

mar77i: you'd set the model on the view class

dodobas: Sanitizing input is not the best way to look at the problem, really – it's better to ensure that you properly render any unsafe values on the output in a way that makes sense for that particular output.

that's what I'm doing. it just confused me because the way I was reading the code up to that point suggested that for form-like views the model was available through self.form.model.

dodobas: santizing in what way?

only that it's being missed out by get_template_names()...

dodobas: Unless, of course, you're talking about validation of user input, which is a different thing. :)

is there ever a self.form?

look, the fact is that SingleObjectTemplateResponseMixin is not written with edit.py in mind, and that's an oversight.

why is that an oversight?

it's already generic to a single-object, and derives its templates from that

kezabelle: it's a 7years old project that is abusing mark_safe/safe to render chunks of templates and JS, so ... it's not perfect

because all other edit.py views are perfectly fine not specifying a model because there's self.object, which get_template_names() takes care of.

koniiiik: yeah, validation also works

only createview doesn't, and hence needs a model and it really took me a long time to figure out why the view wasn't configured correctly (missing a model, and therefore missing a template name).

just want to stop saving junk in the database, which might render somewhere ... :)

dodobas: bleach for HTML, probably.

no one wants to crate a company named `<script>alert('XSS attack!');</script>` until they do :)

bleach is nice.

mar77i: So what you mean is that you'd like for ModelFormMixin.get_template_names to also include a fallback in case there's no model defined directly on the view class, but there is a form_class, and it happens to be a ModelForm, to use the model from that as the model class?

koniiiik: you understood the problem, but I think you're also touching the topic of it being a bit contrived. I think for ModelFormViews there might be a second subclass of SingleObjectTemplateResponseMixin, or even a simple @property model(): return self.form_class.model, as I suggested earlier.

mar77i: The property thing does not sound like a particularly good idea, since model is already used as the class attribute that you as the user override to configure the form class.

I mean the view class.

Dang. Too sleepy.

yes, but overriding it wouldn't actually do anything. it just wouldn't be needed.

again why do you not want to specify model at the view?

mar77i: but then you can't automatically generate a modelform, because to do so depends on the model, which depends on the form_class, which depends on the model

hmm. interesting. so therefore the CreateView example includes a model, while the FormView example doesn't. https://docs.djangoproject.com/en/2.1/ref/class...

because a FormView doesn't have anything to do with it being a ModelForm

FormView is for generic forms, not necessarily for ModelForms.

https://ccbv.co.uk/projects/Django/2.0/django.v... -- you *need* the model in order to generate a ModelForm in CreateView...

Unless it's already set as cls.form_class, though.

I think I transitioned from one to the other without reading further. Okay, I probably shouldn't expect django to cater my bad reading habits.

https://pastebin.com/raw/ub2j50zd what does this ModuleNotFoundError exception means in the context of Django test execution?

Please do not use pastebin.com as instructed in the topic.

Katharsis: its an ImportError subclass, so it means it couldn't locate your urlconf

which one? the main urls.py?

maybe? could be any of them tbh

but probably your main one would be a good place to start debugging

I have demo project without custom apps with Django admin panel only

https://dpaste.de/qRs0 urls.py

whats your tests_settings look like?

... and whatever runtests.py does, I guess

kezabelle: from .settings import * and custom DATABASES

Katharsis: can you show us runtests.py?

did you know that there is a band called Django Django, #artrock ? :)

sure

moldy: https://github.com/django/django/blob/stable/1....

yeah, comes up frequently when I type django/django into my address bar before the autofill to master turns up :\

Katharsis: ehm... you copied that file into your project?

Katharsis: that file is for running django's internal tests, not for running your own tests.

Katharsis: what happens when you run `./manage.py test --settings=demo_app.tests_settings`?

I want to run these tests for my custom django backend which is a copy of PostgreSQL DB backend

ahh

Ran 0 tests in 0.000s

OK

well, that runtests quite clearly includes a urlconf of "urls", and there's a urls.py next to it, so I'm guessing you don't have that ...

i'm not familiar with django's internal test suite, but it wouldn't surprise if you have to run runtests.py from a specific location

moldy: yeah, `cd tests; runtests.py`

How do I implement multiple tokens per user authentication in djangorestframework