it can wait, or maybe I can DM you on twitter. I just did a bit of benchmarking of your protobuf package vs that one I mentioned a month ago or so, and was hoping you could take a look to make sure my results seem resonable
mafintosh: really I just didn't want to post them as an issue and have it open to people's typical "your benchmark is wrong for this reason" before getting a second set of knowledgeable eyes
mafintosh
notwes: let me try and run it
ogd: "Mr. Ogden"
ogd
:P
notwes has quit
shibacomputer joined the channel
dat-gitter-bot
(wesleytodd) Mafintosh: thanks!! Again, no rush
substack
nice
shibacom_ has quit
mafintosh
@wesleytodd you have a mistake in the bench
@wesleytodd you need to call .finish() on all your protobufjs encodes. otherwise you arent testing serialization
dat-gitter-bot
(wesleytodd) Hahah. I knew I must have missed something. I accidentally removed that during a refactor
(wesleytodd) My original test had much closer results and then I changed stuff and they were suddenly much further apart
andrenarchy has quit
mafintosh
@wesleytodd fyi for cases where you *really* care about perf i use the buf argument to protocol-buffers .encode(msg, buf) and encode into a preallocated buffer
eases gc + gives you a boost as it then does zero allocs per encode
notwes joined the channel
notwes
mafintosh: awesome suggestions! I will update with that, thanks!
ogd
mafintosh: does dat-next-next still rabin? should we turn that off for now?
mafintosh: or put it behind a flag
mafintosh
ogd: i turned it off for now in next-next
having a flag to re-enable it sgtm though
ogd
mafintosh: cool
pfrazee
why is it disabled?
lgierth
have you had good experience with rabin, dedup-wise?
pfrazee has quit
notwes has quit
pfrazee joined the channel
ogd
pfrazee: lgierth we have been benchmarking stuff and rabin is a big bottleneck right now, it's causing imports to be slower than network transfers without it would be. so we decided to turn it off by default in the cli but leave it in the code, and add it in based on smarter heuristics in the future
pfrazee
ogd: does turning it off just result in fixed-size chunks?
ogd
pfrazee: yep
pfrazee
ogd: ok cool
lgierth
yeah it's been slower than fixed-size chunks in ipfs too
did you see any gains in deduplication though? in ipfs it has been slighty better, and slightly worse, depending on the settings
better=more dedup
but always slower
pfrazee
is rabin only run on initial write, or is it run during verification of a file too during replication?
ogd
only when files are read
not metadata
pfrazee
yeah. Well I wonder if the dedup gains are more than the fingerprinting cost
ogd
lgierth: we cant answer that scientifically yet cause we dont have enough dats out there in the wild, which was another factor as to turning it off for now
fast dat = more users
lgierth
word :>
we've only run small-scale benchmarks so don't have a definitive answer either