16:57 PM
tycho
?
16:57 PM
JamesTait has quit
16:57 PM
bearbin
I'm using the exact same compile script on my old buildserver and the build works 0.0
16:57 PM
JamesTait joined the channel
16:58 PM
only change is the debian verison
16:58 PM
LO1ZB
I just removed the check if it is able to find %VS120COMNTOOLS%
16:59 PM
tycho
No idea. Try turning on verbose makefiles and looking at the mbedtls cflags.
17:00 PM
bearbin
how might I do that
17:01 PM
LO1ZB
any idea how to test without filling jenkins with failed builds?
17:01 PM
bearbin
no idea. The failed builds don't really affect anything, just mess up the history, anyway.
17:02 PM
LO1ZB
I opend %VS120COMNTOOLS% with the explorrer and it worked
17:03 PM
so, I removed the check if its there
17:07 PM
I'll try reinstalling the windows sdk
17:37 PM
LO1ZB has quit
17:38 PM
LO1ZB joined the channel
17:48 PM
JamesTait has quit
18:00 PM
bearbin has quit
18:10 PM
rincewind1
hm, is there a need for a server with a bit of storage and high speed connection?
18:16 PM
tycho
@bearbin, whats the traffic like for your build server?
18:17 PM
Because I did some rough estimates and put them into the S3 price calculator, and it says 10 cents a month, if we use travis's build artifacts system.
18:17 PM
For hosting the downloads.
18:18 PM
Not 10 cents 91 cents, because amazon hides things.
18:18 PM
rincewind1
how much traffic do you produce?
18:19 PM
tycho
Thats for an estimate of 1000 downloads a mounth.
18:22 PM
Even just moving over the x64 Linux builds to Travis/S3 would reduce the load on bearbins server.
18:25 PM
rincewind1
hm, how complicated is that? I could help maybe
18:26 PM
tycho
I just want to make sure of the estimates first, so I'd like to know from bearbin.
18:26 PM
rincewind1
k
18:27 PM
tycho
We'd need to set up an AWS account, add some lines to our .travis.yml, then point the build links at S3 rather than bearbins build server.
18:28 PM
We'd probably want to add settings to S3 to automaticly retire builds once they reach a certian age, to avoid storing too much data.
19:35 PM
SphinxC0re joined the channel
19:35 PM
LO1ZB
hello SphinxC0re
19:36 PM
tycho_ joined the channel
19:36 PM
tycho has quit
19:38 PM
SphinxC0re
Hi LO1ZB
19:39 PM
LO1ZB
do you know stuff and thinks about msbuild SphinxC0re?
19:39 PM
SphinxC0re
msbuild?
19:39 PM
LO1ZB
thats a no?
19:40 PM
SphinxC0re
yes :P
19:40 PM
LO1ZB
ok :<
19:41 PM
gh-informant
[MCServer] worktycho closed pull request #2034: Moved BroadcastChunkData over to cBroadcaster (master...BroadcastRefactor2)
http://git.io/vTv8e
19:41 PM
LO1ZB
the problem is, that I'm getting that error when I try to add my pc as slave to travis
19:42 PM
"Cannot determine the location of the VS Common Tools folder."
19:42 PM
tycho_
What user is Jenkins running as>
19:42 PM
?
19:42 PM
It may be using different env vars from your desktop session
19:43 PM
LO1ZB
it runs as a windoes servise
19:43 PM
windows service*
19:43 PM
tycho_
That might have something to do with it.
19:43 PM
Go into the edit system enviromental variables window.
19:44 PM
LO1ZB
ok sec
19:44 PM
tycho_
and check the vars there
19:44 PM
LO1ZB
VS120COMNTOOLS = C:\Program Files (x86)\Microsoft Visual Studio 12.0\Common7\Tools\
19:45 PM
tycho_
And thats in system env vars. not user env vars.
19:45 PM
LO1ZB
yes
19:45 PM
tycho_
Then the only thing I can think of is WoW.
19:45 PM
Is Jenkins a 32 bit process?
19:45 PM
LO1ZB
running from the start menu does work
19:46 PM
java
19:46 PM
tycho_
Might be permissions.
19:46 PM
LO1ZB
thats a java app
19:47 PM
tycho_
So its probably not WoW. program files shouldn't have permissions issues.
19:47 PM
I can't think of anything.
19:48 PM
LO1ZB
the app is inside C:\Jenkins
19:48 PM
tycho_
Whats the permissions on that?
19:48 PM
Is it owned by your account?
19:48 PM
LO1ZB
open to everyone
19:48 PM
cmake works
19:48 PM
tycho_
Write to everyone?
19:48 PM
LO1ZB
yes
19:49 PM
tycho_
Can't think of anything else.
19:49 PM
LO1ZB
thats a problem with the configuration of visual c
19:49 PM
by default the start menu leads to C:\Program Files (x86)\Microsoft Visual Studio 11.0\Common7\Tools\
19:50 PM
I dono have visual studio 11 installed
19:51 PM
I did some modifications to vcvars32.bat but I cannot test if it works atm
19:56 PM
gv1222 has quit
20:02 PM
gv1222 joined the channel
20:09 PM
tycho_
We really need to reduce dependecies on cWorld
20:10 PM
Changing ChunkSender.h is aan indirect dependecy of everything through cWorld
20:10 PM
SphinxC0re
I agree
20:11 PM
tycho_
I'm doing what I can, but everyone needs to commit to it.
20:11 PM
Fixing the god objects is far more important than the name chnange in my opinion.
20:12 PM
cWorld, cChunk, cChunkMap, cClientHandle are the worst, in that order.
20:12 PM
LO1ZB
is the forum only 4 me slow?
20:13 PM
tycho_
I'm not seeing anything.
20:14 PM
LO1ZB
it sometimes takes 10+ sec to load
20:21 PM
tycho_
going down the rabbit hole.
20:21 PM
SphinxC0re
to bed?
20:22 PM
tycho_
No, Fixing one thing involves fixing another first.
20:22 PM
Which leads to another issue which leads to another.
20:23 PM
In this cas, Fixing ChunkSending, has led me to memory ownership of cLightingThread Callbacks.
20:33 PM
LO1ZB
sounds complicated. o.o
20:34 PM
SphinxC0re
I'm sure it isn't for tycho_
20:34 PM
tycho_
LightingThread required that the callback was owned by the caller.
20:34 PM
I'm simplifing it so that LightingThread owns it.
20:35 PM
SphinxC0re
20:36 PM
LO1ZB
all I know is that it generates a few chunk befor it crashed
20:36 PM
if that helps
20:37 PM
SphinxC0re
I already knew that :)
20:37 PM
tycho_
I'm not sure, which verify is it hitting?
20:38 PM
I understand the lighting stuff.
20:38 PM
But those multithreaded bugs usually involve rediculus interactions.
20:38 PM
The one I had with entitys not getting destroyed took several days to fix, with a reliable way of generating them.
20:40 PM
SphinxC0re
LightningThread.cpp line 345
20:42 PM
tycho_
Just a few quick checks.
20:42 PM
You're sure the chunks are loaded?
20:44 PM
SphinxC0re
I'm using the HOOK_CHUNK_GENERATING. I don't know if they are loaded. I don't think so. But I should be able to change the generating chunk. Also I should be able to query chunks fo regenerating
20:44 PM
tycho_
Are you triggering the lighting you're self?
20:45 PM
SphinxC0re
No. why should I? I don't even know how this is possible
20:46 PM
tycho_
Ok, then its probably curruption, in which case the problem is much earlier than the verify
20:46 PM
Have you tried running under valgrind?
20:46 PM
SphinxC0re
No
20:46 PM
Valgrind searches for memory leaks
20:46 PM
tycho_
Valgrind serches for memory leaks and memory curruption.
20:47 PM
SphinxC0re
Okay
20:47 PM
I'll try
20:47 PM
tycho_
The only two tools when fighting this sort of bugs are valgrind, and adding lots more asserts.
20:48 PM
SphinxC0re
the server still doesn't compile on my machine though
20:48 PM
gcc 5.1
20:49 PM
tycho_
PR 2153 has the fix, but theres another issue I'm not sure about.
20:50 PM
SphinxC0re
build on 2153 failde
20:50 PM
tycho_
Yas, theres something else in the update thats interfering
20:50 PM
We might have to update SQLite
20:51 PM
But as a temporary fix, if you delete everything below line 46 in lib/SQLiteCPP/include/SQLiteCpp/Exception.h
20:51 PM
Then it will compile in gcc 5
20:52 PM
LO1ZB
I dono know if it is important, it only crashed in release mode, not in debug mode
20:53 PM
gh-informant
20:53 PM
MCServer/comparators acfb4d0 Tiger Wang: Test
20:53 PM
tycho_
Then its allmost certianly curruption.
20:54 PM
LO1ZB
the visual studio debugger also gives no information besides the stacktrace
20:55 PM
tycho_
Curroption. Are you on Linux or Windows?
20:55 PM
LO1ZB
I'm on windows
20:55 PM
SphinxC0re
Linux
20:56 PM
tycho_
Its different options for Linux and WIndows
20:57 PM
LO1ZB
has "_Reserved = 3" any meaning?
20:57 PM
tycho_
On Windows, if you go into setflags and add /GS on line 63 in generates binaries with more stack curruption checks
20:58 PM
@LO1ZB What context? Its UB in C and C++
20:58 PM
LO1ZB
visual studio's auto and local window when debugging shows that
20:59 PM
tycho_
I have no Idea.
20:59 PM
LO1ZB
ok
20:59 PM
where is that setflags?
21:00 PM
tycho_
SetFlags.cmake in the rrot dir
21:01 PM
@SphinxC0re on Linux if you go to line 109 and add -fstack-protector-all -fsanitize=address it adds similar protections.
21:03 PM
LO1ZB
I'm re-running cmake....
21:05 PM
compiling
21:06 PM
tycho_
I'm not making any promoses about the flag, just that it can help detect some forms of memory curroption.
21:06 PM
LO1ZB
ok
21:07 PM
wait.. 312 chunks/s o.o
21:08 PM
I run it to create the setting.ini
21:08 PM
tycho_
Debug mode is slow.