#cuberite

/

      • tycho
        ?
      • JamesTait has quit
      • bearbin
        I'm using the exact same compile script on my old buildserver and the build works 0.0
      • JamesTait joined the channel
      • only change is the debian verison
      • LO1ZB
        I just removed the check if it is able to find %VS120COMNTOOLS%
      • tycho
        No idea. Try turning on verbose makefiles and looking at the mbedtls cflags.
      • bearbin
        how might I do that
      • LO1ZB
        any idea how to test without filling jenkins with failed builds?
      • bearbin
        no idea. The failed builds don't really affect anything, just mess up the history, anyway.
      • LO1ZB
        I opend %VS120COMNTOOLS% with the explorrer and it worked
      • so, I removed the check if its there
      • I'll try reinstalling the windows sdk
      • LO1ZB has quit
      • LO1ZB joined the channel
      • JamesTait has quit
      • bearbin has quit
      • rincewind1
        hm, is there a need for a server with a bit of storage and high speed connection?
      • tycho
        @bearbin, whats the traffic like for your build server?
      • Because I did some rough estimates and put them into the S3 price calculator, and it says 10 cents a month, if we use travis's build artifacts system.
      • For hosting the downloads.
      • Not 10 cents 91 cents, because amazon hides things.
      • rincewind1
        how much traffic do you produce?
      • tycho
        Thats for an estimate of 1000 downloads a mounth.
      • Even just moving over the x64 Linux builds to Travis/S3 would reduce the load on bearbins server.
      • rincewind1
        hm, how complicated is that? I could help maybe
      • tycho
        I just want to make sure of the estimates first, so I'd like to know from bearbin.
      • rincewind1
        k
      • tycho
        We'd need to set up an AWS account, add some lines to our .travis.yml, then point the build links at S3 rather than bearbins build server.
      • We'd probably want to add settings to S3 to automaticly retire builds once they reach a certian age, to avoid storing too much data.
      • SphinxC0re joined the channel
      • LO1ZB
        hello SphinxC0re
      • tycho_ joined the channel
      • tycho has quit
      • SphinxC0re
        Hi LO1ZB
      • LO1ZB
        do you know stuff and thinks about msbuild SphinxC0re?
      • SphinxC0re
        msbuild?
      • LO1ZB
        thats a no?
      • SphinxC0re
        yes :P
      • LO1ZB
        ok :<
      • gh-informant
        [MCServer] worktycho closed pull request #2034: Moved BroadcastChunkData over to cBroadcaster (master...BroadcastRefactor2) http://git.io/vTv8e
      • LO1ZB
        the problem is, that I'm getting that error when I try to add my pc as slave to travis
      • "Cannot determine the location of the VS Common Tools folder."
      • tycho_
        What user is Jenkins running as>
      • ?
      • It may be using different env vars from your desktop session
      • LO1ZB
        it runs as a windoes servise
      • windows service*
      • tycho_
        That might have something to do with it.
      • Go into the edit system enviromental variables window.
      • LO1ZB
        ok sec
      • tycho_
        and check the vars there
      • LO1ZB
        VS120COMNTOOLS = C:\Program Files (x86)\Microsoft Visual Studio 12.0\Common7\Tools\
      • tycho_
        And thats in system env vars. not user env vars.
      • LO1ZB
        yes
      • tycho_
        Then the only thing I can think of is WoW.
      • Is Jenkins a 32 bit process?
      • LO1ZB
        running from the start menu does work
      • java
      • tycho_
        Might be permissions.
      • LO1ZB
        thats a java app
      • tycho_
        So its probably not WoW. program files shouldn't have permissions issues.
      • I can't think of anything.
      • LO1ZB
        the app is inside C:\Jenkins
      • tycho_
        Whats the permissions on that?
      • Is it owned by your account?
      • LO1ZB
        open to everyone
      • cmake works
      • tycho_
        Write to everyone?
      • LO1ZB
        yes
      • tycho_
        Can't think of anything else.
      • LO1ZB
        thats a problem with the configuration of visual c
      • by default the start menu leads to C:\Program Files (x86)\Microsoft Visual Studio 11.0\Common7\Tools\
      • I dono have visual studio 11 installed
      • I did some modifications to vcvars32.bat but I cannot test if it works atm
      • gv1222 has quit
      • gv1222 joined the channel
      • tycho_
        We really need to reduce dependecies on cWorld
      • Changing ChunkSender.h is aan indirect dependecy of everything through cWorld
      • SphinxC0re
        I agree
      • tycho_
        I'm doing what I can, but everyone needs to commit to it.
      • Fixing the god objects is far more important than the name chnange in my opinion.
      • cWorld, cChunk, cChunkMap, cClientHandle are the worst, in that order.
      • LO1ZB
        is the forum only 4 me slow?
      • tycho_
        I'm not seeing anything.
      • LO1ZB
        it sometimes takes 10+ sec to load
      • tycho_
        going down the rabbit hole.
      • SphinxC0re
        to bed?
      • tycho_
        No, Fixing one thing involves fixing another first.
      • Which leads to another issue which leads to another.
      • In this cas, Fixing ChunkSending, has led me to memory ownership of cLightingThread Callbacks.
      • LO1ZB
        sounds complicated. o.o
      • SphinxC0re
        I'm sure it isn't for tycho_
      • tycho_
        LightingThread required that the callback was owned by the caller.
      • I'm simplifing it so that LightingThread owns it.
      • SphinxC0re
        btw, tycho_ do you have an idea how to fix this issue: http://forum.mc-server.org/showthread.php?tid=1...
      • LO1ZB
        all I know is that it generates a few chunk befor it crashed
      • if that helps
      • SphinxC0re
        I already knew that :)
      • tycho_
        I'm not sure, which verify is it hitting?
      • I understand the lighting stuff.
      • But those multithreaded bugs usually involve rediculus interactions.
      • The one I had with entitys not getting destroyed took several days to fix, with a reliable way of generating them.
      • SphinxC0re
        LightningThread.cpp line 345
      • tycho_
        Just a few quick checks.
      • You're sure the chunks are loaded?
      • SphinxC0re
        I'm using the HOOK_CHUNK_GENERATING. I don't know if they are loaded. I don't think so. But I should be able to change the generating chunk. Also I should be able to query chunks fo regenerating
      • tycho_
        Are you triggering the lighting you're self?
      • SphinxC0re
        No. why should I? I don't even know how this is possible
      • tycho_
        Ok, then its probably curruption, in which case the problem is much earlier than the verify
      • Have you tried running under valgrind?
      • SphinxC0re
        No
      • Valgrind searches for memory leaks
      • tycho_
        Valgrind serches for memory leaks and memory curruption.
      • SphinxC0re
        Okay
      • I'll try
      • tycho_
        The only two tools when fighting this sort of bugs are valgrind, and adding lots more asserts.
      • SphinxC0re
        the server still doesn't compile on my machine though
      • gcc 5.1
      • tycho_
        PR 2153 has the fix, but theres another issue I'm not sure about.
      • SphinxC0re
        build on 2153 failde
      • tycho_
        Yas, theres something else in the update thats interfering
      • We might have to update SQLite
      • But as a temporary fix, if you delete everything below line 46 in lib/SQLiteCPP/include/SQLiteCpp/Exception.h
      • Then it will compile in gcc 5
      • LO1ZB
        I dono know if it is important, it only crashed in release mode, not in debug mode
      • gh-informant
        [MCServer] tigerw pushed 1 new commit to comparators: http://git.io/vkuGm
      • MCServer/comparators acfb4d0 Tiger Wang: Test
      • tycho_
        Then its allmost certianly curruption.
      • LO1ZB
        the visual studio debugger also gives no information besides the stacktrace
      • tycho_
        Curroption. Are you on Linux or Windows?
      • LO1ZB
        I'm on windows
      • SphinxC0re
        Linux
      • tycho_
        Its different options for Linux and WIndows
      • LO1ZB
        has "_Reserved = 3" any meaning?
      • tycho_
        On Windows, if you go into setflags and add /GS on line 63 in generates binaries with more stack curruption checks
      • @LO1ZB What context? Its UB in C and C++
      • LO1ZB
        visual studio's auto and local window when debugging shows that
      • tycho_
        I have no Idea.
      • LO1ZB
        ok
      • where is that setflags?
      • tycho_
        SetFlags.cmake in the rrot dir
      • @SphinxC0re on Linux if you go to line 109 and add -fstack-protector-all -fsanitize=address it adds similar protections.
      • LO1ZB
        I'm re-running cmake....
      • compiling
      • tycho_
        I'm not making any promoses about the flag, just that it can help detect some forms of memory curroption.
      • LO1ZB
        ok
      • wait.. 312 chunks/s o.o
      • I run it to create the setting.ini
      • tycho_
        Debug mode is slow.