6:00 AM
ibloat joined the channel
8:35 AM
gh-informant
8:35 AM
MCServer/GrownBiomes 7d08d34 Mattes D: Removed too advanced C++11 features....
8:49 AM
8:49 AM
MCServer/GrownBiomes a068ebf Mattes D: cIntGen: Added a virtual destructor.
10:08 AM
Ambushed01 joined the channel
10:09 AM
Ambushed01
@archshift how can i remove files from pull request?
16:00 PM
hanabi joined the channel
16:21 PM
hanabi has quit
16:22 PM
Heey bearbin
16:22 PM
bearbin
hey
16:22 PM
Ambushed01
I have question about github
16:22 PM
bearbin
ok
16:22 PM
Ambushed01
=D
16:23 PM
I have to remove 3 files from my PR
16:23 PM
but i dont know how
16:23 PM
bearbin
ok
16:23 PM
do you have the git cli installeD?
16:23 PM
or are you using the GH web interface?
16:23 PM
Ambushed01
i have windows github
16:23 PM
bearbin
ok. I don't know exactly for that.
16:24 PM
But you should be able to delete some files, commit the changes, and then push them up.
16:24 PM
That will remove the files.
16:24 PM
Ambushed01
ok, because i reopened my PR
16:24 PM
i got 2 new programs to test .css usage and compressors
16:25 PM
i tested with 500 rows .css file, it makes loading .css 5~20ms faster when compressed
16:35 PM
@bearbin, @archshift:
16:35 PM
Input 4163 bytes
16:35 PM
Output 2993 bytes
16:35 PM
You Save 39.09%
16:35 PM
This is done by compressing css file
16:36 PM
bearbin
that's good
16:36 PM
but make sure to have the uncompressed source files in the repo also - they're much easier to edit.
16:37 PM
Ambushed01
i will be making a uncompressed later
16:37 PM
first need to make this pull request complete
16:38 PM
then i will add a package for webadmin (Raw)
16:38 PM
jan64 joined the channel
16:39 PM
login file has been changed @ PR
16:39 PM
time to check the style.css now
16:40 PM
Is it possible to compress .lue and .html also ?
16:40 PM
Sorry .lua *
16:46 PM
gh-informant
16:46 PM
MCServer/master 11a80b5 Alexander Harkness: Pocess?
16:46 PM
16:46 PM
MCServer/master cbb6371 Alexander Harkness: Fixed typo.
16:47 PM
bearbin
.lua is not sent to the client, it is parsed and processed by the server.
16:47 PM
HTML can be minified like CSS.
16:48 PM
Ambushed01
ok
16:50 PM
jan64
actually, you could minify lua
16:50 PM
and, it would speed up parsing of the scripts
16:51 PM
although, the gain would be measured in something along the lines of 1/1e5 s
16:51 PM
Ambushed01
gain would be minimal i guess
16:51 PM
althrough .css and .html compression makes a huge difference in time loading a website
16:52 PM
if compression is 39% css takes along ~20ms
16:53 PM
style.css: Input 7542 bytes, Output 5905 bytes, You Save 27.72%
16:58 PM
@bearbin whats the mc-team branding name ?
16:58 PM
bearbin
wat?
16:59 PM
Ambushed01
Archshift told me
16:59 PM
To change the "Copyright" For webadmin
16:59 PM
bearbin
Copyright MCServer Contributors perhaps?
17:00 PM
Ambushed01
Copyright © <a href="http://www.mc-server.org" target="_blank">MCServer Team</a> 2014.
17:00 PM
this is what he wanted
17:00 PM
But i think he wants me to remove "FusionCare Web Developement" Also
17:01 PM
bearbin
But a copyright notice isn't really necessary. Copyright is there by default, so no need to say that there is.
17:01 PM
Ambushed01
My intention is not to stop by 1 PR
17:01 PM
But to keep improving the WebAdmin, Core and other plugin's web parts
17:01 PM
bearbin
I would prefer that "FusionCare web development" wasn't there, but it's not really a big issue
17:02 PM
Ambushed01
I can remove it
17:03 PM
bearbin
BTW, does "FusionCare Web Development" have a website?
17:03 PM
Ambushed01
17:03 PM
still building, waiting for scripter to finish his part on multi-domain php cross network
17:04 PM
bearbin
cool
17:07 PM
Ambushed01
we are going to make a cross network website for web developement, gaming and support centers
17:11 PM
gh-informant
17:11 PM
17:11 PM
MCServer/warningfixes 8a443c0 Alexander Harkness: Test warning fix.
17:14 PM
Ambushed01
both .css files have been cleaned and compressed succesfull. Change added to github
17:25 PM
you think ppl will be complaining if i compress the html and css files ?
17:27 PM
jan64
if you make the uncompressed ones avialable, i doubt it.
17:31 PM
bearbin
Yeah.
17:32 PM
Ambushed01
i always have the uncompressed ones
17:32 PM
bearbin
Having compressed ones as the only ones in the repo is unaccepable, but having both is fine.
17:32 PM
Ambushed01
as i sayd, people need have few moments for me to upload that PR after this PR is finished
17:32 PM
would take max 30min to make it available
17:33 PM
^.^
17:46 PM
@bearbin have more commits to place on my github PR ?
17:50 PM
Im still not sure about this licence shit. Since i re-created the forum template. I could change it anyways to other codes if needed
17:50 PM
I thought might be handy to use almost same css pattern
17:57 PM
jan64
license?
17:57 PM
unless you copied the css/html you don't have to worry about any licenses.
17:58 PM
and, if you want to copyright it or whatever, why bother?
17:58 PM
bearbin
If you copied any non-trivial element, then you do have to worry. And design is protected under laws very similar to copyright too.
17:59 PM
jan64: For open source projects, it's very important to assign the correct license to your copyright. If you don't then other people could be unable to use it, distribute it or modify it, all essential things for projects like MCS.
17:59 PM
jan64
i mean, just release it under same one as the mcserver itself.
18:00 PM
bearbin
You might not be able to - because the template was CC-BY-SA it means that you have to use the same license if you copy it
18:01 PM
jan64
did he copy it? to me, it looks more like a full rewrite.
18:01 PM
Ambushed01
it is a full re-write
18:01 PM
from scratch with the css and html "viewed" not copy pasted
18:02 PM
thats why i had the file's "Temp.html" from old designs
18:02 PM
bearbin
IANAL, but using the same exact colour values and things might be covered. But it's easiest just to say code is CC-BY-SA and be done with it.
18:03 PM
jan64
change them by a 3 and be done with it. :}
18:03 PM
*-a
18:03 PM
Ambushed01
lol
18:09 PM
gh-informant
18:09 PM
MCServer/warningfixes c0a9a83 Alexander Harkness: Actually fixed the warning.
18:19 PM
Ambushed01
Website van de Theme creator bestaat niet eens meer
18:19 PM
Lolz
18:20 PM
Website from the theme creator "Justin S" doesn't even exist anymore...
18:21 PM
@bearbin can send me a link for the licence the forum design is under?
18:22 PM
and how to add it to my creation
18:25 PM
bearbin
just put a header at the top of the source code saying "Copyright Justin S and MCServer Team, licensed under CC-BY-SA 3.0
18:29 PM
Ambushed01
thats all ?
18:29 PM
O.o
18:32 PM
Done
18:32 PM
login.css, style.css, login_template.html, template.lua
18:33 PM
thats only files i have been re-writing that are public
19:14 PM
jan64_ joined the channel
19:17 PM
jan64 has quit
19:50 PM
gh-informant
19:50 PM
MCServer/warningfixes 6e21897 Alexander Harkness: Fixed remaining warnings.
19:52 PM
19:52 PM
MCServer/warningfixes 0cdf262 Alexander Harkness: Fix missing biomes in enum.
19:53 PM
19:53 PM
MCServer/warningfixes 59ca542 Alexander Harkness: Another switch.
20:05 PM
20:05 PM
MCServer/warningfixes 7de8757 Alexander Harkness: Fixed more warnings....
20:08 PM
[MCServer] bearbin opened pull request #1573: Fixed some more warnings. (master...warningfixes)
http://git.io/Q2pARg
20:17 PM
20:17 PM
MCServer/warningfixes b67eb21 Alexander Harkness: Another one.#
21:34 PM
21:34 PM
MCServer/warningfixes a4932bb Alexander Harkness: CheckBasicStyle'd
21:38 PM
21:38 PM
MCServer/warningfixes dbe7c8b Alexander Harkness: Comment alignment.
21:56 PM
archshift
Ambushed01: why are you compressing the CSS?
21:57 PM
bearbin: design isn't protected under copyright, it's protected under patents :P
21:57 PM
and patents for software are very difficult to come by, and aren't automatic
21:58 PM
bearbin
but it does cover the code required to generate the design
21:58 PM
archshift
yes
21:58 PM
if he copied and pasted anything, chances are he needs to add the proper license
21:58 PM
bearbin
21:59 PM
archshift
ah, that's UK stuff
21:59 PM
silly US
21:59 PM
*UK
22:03 PM
gh-informant
22:03 PM
MCServer/warningfixes 2323430 Alexander Harkness: Fixed compile (typos).
22:25 PM
Ambushed01
ok guys
22:26 PM
I already added licence like bearbin told me ?
22:26 PM
im compressing to increase speed
22:26 PM
i will be releasing uncompressed after this pull request is done
22:26 PM
archshift
...