#cuberite

/

      • ibloat joined the channel
      • gh-informant
        [MCServer] madmaxoft pushed 1 new commit to GrownBiomes: http://git.io/fxi6ZA
      • MCServer/GrownBiomes 7d08d34 Mattes D: Removed too advanced C++11 features....
      • [MCServer] madmaxoft pushed 1 new commit to GrownBiomes: http://git.io/wTpuAg
      • MCServer/GrownBiomes a068ebf Mattes D: cIntGen: Added a virtual destructor.
      • Ambushed01 joined the channel
      • Ambushed01
        @archshift how can i remove files from pull request?
      • hanabi joined the channel
      • hanabi has quit
      • Heey bearbin
      • bearbin
        hey
      • Ambushed01
        I have question about github
      • bearbin
        ok
      • Ambushed01
        =D
      • I have to remove 3 files from my PR
      • but i dont know how
      • bearbin
        ok
      • do you have the git cli installeD?
      • or are you using the GH web interface?
      • Ambushed01
        i have windows github
      • bearbin
        ok. I don't know exactly for that.
      • But you should be able to delete some files, commit the changes, and then push them up.
      • That will remove the files.
      • Ambushed01
        ok, because i reopened my PR
      • i got 2 new programs to test .css usage and compressors
      • i tested with 500 rows .css file, it makes loading .css 5~20ms faster when compressed
      • @bearbin, @archshift:
      • Input 4163 bytes
      • Output 2993 bytes
      • You Save 39.09%
      • This is done by compressing css file
      • bearbin
        that's good
      • but make sure to have the uncompressed source files in the repo also - they're much easier to edit.
      • Ambushed01
        i will be making a uncompressed later
      • first need to make this pull request complete
      • then i will add a package for webadmin (Raw)
      • jan64 joined the channel
      • login file has been changed @ PR
      • time to check the style.css now
      • Is it possible to compress .lue and .html also ?
      • Sorry .lua *
      • gh-informant
        [MCServer] bearbin pushed 1 new commit to master: http://git.io/pO3-8A
      • MCServer/master 11a80b5 Alexander Harkness: Pocess?
      • [MCServer] bearbin pushed 1 new commit to master: http://git.io/fdIXlw
      • MCServer/master cbb6371 Alexander Harkness: Fixed typo.
      • bearbin
        .lua is not sent to the client, it is parsed and processed by the server.
      • HTML can be minified like CSS.
      • Ambushed01
        ok
      • jan64
        actually, you could minify lua
      • and, it would speed up parsing of the scripts
      • although, the gain would be measured in something along the lines of 1/1e5 s
      • Ambushed01
        gain would be minimal i guess
      • althrough .css and .html compression makes a huge difference in time loading a website
      • if compression is 39% css takes along ~20ms
      • style.css: Input 7542 bytes, Output 5905 bytes, You Save 27.72%
      • @bearbin whats the mc-team branding name ?
      • bearbin
        wat?
      • Ambushed01
        Archshift told me
      • To change the "Copyright" For webadmin
      • bearbin
        Copyright MCServer Contributors perhaps?
      • Ambushed01
        Copyright © <a href="http://www.mc-server.org" target="_blank">MCServer Team</a> 2014.
      • this is what he wanted
      • But i think he wants me to remove "FusionCare Web Developement" Also
      • bearbin
        But a copyright notice isn't really necessary. Copyright is there by default, so no need to say that there is.
      • Ambushed01
        My intention is not to stop by 1 PR
      • But to keep improving the WebAdmin, Core and other plugin's web parts
      • bearbin
        I would prefer that "FusionCare web development" wasn't there, but it's not really a big issue
      • Ambushed01
        I can remove it
      • bearbin
        BTW, does "FusionCare Web Development" have a website?
      • Ambushed01
      • still building, waiting for scripter to finish his part on multi-domain php cross network
      • bearbin
        cool
      • Ambushed01
        we are going to make a cross network website for web developement, gaming and support centers
      • gh-informant
        [MCServer] bearbin created warningfixes from master (+0 new commits): http://git.io/K9LKxA
      • [MCServer] bearbin pushed 1 new commit to warningfixes: http://git.io/OcEXPw
      • MCServer/warningfixes 8a443c0 Alexander Harkness: Test warning fix.
      • Ambushed01
        both .css files have been cleaned and compressed succesfull. Change added to github
      • you think ppl will be complaining if i compress the html and css files ?
      • jan64
        if you make the uncompressed ones avialable, i doubt it.
      • bearbin
        Yeah.
      • Ambushed01
        i always have the uncompressed ones
      • bearbin
        Having compressed ones as the only ones in the repo is unaccepable, but having both is fine.
      • Ambushed01
        as i sayd, people need have few moments for me to upload that PR after this PR is finished
      • would take max 30min to make it available
      • ^.^
      • @bearbin have more commits to place on my github PR ?
      • Im still not sure about this licence shit. Since i re-created the forum template. I could change it anyways to other codes if needed
      • I thought might be handy to use almost same css pattern
      • jan64
        license?
      • unless you copied the css/html you don't have to worry about any licenses.
      • and, if you want to copyright it or whatever, why bother?
      • bearbin
        If you copied any non-trivial element, then you do have to worry. And design is protected under laws very similar to copyright too.
      • jan64: For open source projects, it's very important to assign the correct license to your copyright. If you don't then other people could be unable to use it, distribute it or modify it, all essential things for projects like MCS.
      • jan64
        i mean, just release it under same one as the mcserver itself.
      • bearbin
        You might not be able to - because the template was CC-BY-SA it means that you have to use the same license if you copy it
      • jan64
        did he copy it? to me, it looks more like a full rewrite.
      • Ambushed01
        it is a full re-write
      • from scratch with the css and html "viewed" not copy pasted
      • thats why i had the file's "Temp.html" from old designs
      • bearbin
        IANAL, but using the same exact colour values and things might be covered. But it's easiest just to say code is CC-BY-SA and be done with it.
      • jan64
        change them by a 3 and be done with it. :}
      • *-a
      • Ambushed01
        lol
      • gh-informant
        [MCServer] bearbin pushed 1 new commit to warningfixes: http://git.io/PWaG9g
      • MCServer/warningfixes c0a9a83 Alexander Harkness: Actually fixed the warning.
      • Ambushed01
        Website van de Theme creator bestaat niet eens meer
      • Lolz
      • Website from the theme creator "Justin S" doesn't even exist anymore...
      • @bearbin can send me a link for the licence the forum design is under?
      • and how to add it to my creation
      • bearbin
        just put a header at the top of the source code saying "Copyright Justin S and MCServer Team, licensed under CC-BY-SA 3.0
      • Ambushed01
        thats all ?
      • O.o
      • Done
      • login.css, style.css, login_template.html, template.lua
      • thats only files i have been re-writing that are public
      • jan64_ joined the channel
      • jan64 has quit
      • gh-informant
        [MCServer] bearbin pushed 1 new commit to warningfixes: http://git.io/F_Cmgw
      • MCServer/warningfixes 6e21897 Alexander Harkness: Fixed remaining warnings.
      • [MCServer] bearbin pushed 1 new commit to warningfixes: http://git.io/UKXnhg
      • MCServer/warningfixes 0cdf262 Alexander Harkness: Fix missing biomes in enum.
      • [MCServer] bearbin pushed 1 new commit to warningfixes: http://git.io/ML01pA
      • MCServer/warningfixes 59ca542 Alexander Harkness: Another switch.
      • [MCServer] bearbin pushed 1 new commit to warningfixes: http://git.io/FNiipg
      • MCServer/warningfixes 7de8757 Alexander Harkness: Fixed more warnings....
      • [MCServer] bearbin opened pull request #1573: Fixed some more warnings. (master...warningfixes) http://git.io/Q2pARg
      • [MCServer] bearbin pushed 1 new commit to warningfixes: http://git.io/zW3HYw
      • MCServer/warningfixes b67eb21 Alexander Harkness: Another one.#
      • [MCServer] bearbin pushed 1 new commit to warningfixes: http://git.io/9TECQw
      • MCServer/warningfixes a4932bb Alexander Harkness: CheckBasicStyle'd
      • [MCServer] bearbin pushed 1 new commit to warningfixes: http://git.io/gYbH9A
      • MCServer/warningfixes dbe7c8b Alexander Harkness: Comment alignment.
      • archshift
        Ambushed01: why are you compressing the CSS?
      • bearbin: design isn't protected under copyright, it's protected under patents :P
      • and patents for software are very difficult to come by, and aren't automatic
      • bearbin
        but it does cover the code required to generate the design
      • archshift
        yes
      • if he copied and pasted anything, chances are he needs to add the proper license
      • bearbin
        and also (although they almost certainly don't apply here) https://www.gov.uk/design-right
      • archshift
        ah, that's UK stuff
      • silly US
      • *UK
      • gh-informant
        [MCServer] bearbin pushed 1 new commit to warningfixes: http://git.io/RZgf0w
      • MCServer/warningfixes 2323430 Alexander Harkness: Fixed compile (typos).
      • Ambushed01
        ok guys
      • I already added licence like bearbin told me ?
      • im compressing to increase speed
      • i will be releasing uncompressed after this pull request is done
      • archshift
        ...