#beets

vin: fwiw pretty sure your question is in the FQ

FAQ

darwin: thanks for the help. O wait...

That was a harsh way of saying thank you. 0_o

Hi! If anyone's curious and likes thinking about the internals of the beets importer, I've done a bunch of refactoring today that might entertain you.

The idea was to make the built-in prompt choices (use as-is, skip, abort, etc.) work more like the plugin-provided PromptChoice callbacks.

This has two benefits: plugins are more powerful (c.f. #2327), and the internals are now more consistent and have less duplication.

I'm particularly delighted that the `choose_candidate` function in `beets.ui.commands` has gotten rid of a *lot* of copypasta.

There are several points there where the set of prompt actions was mostly the same, with a few small differences, and we needed an identical chain of if/elif/elif/elif tests to select between them.

Now, the prompt choices are declared *once* (in _get_choices) and they can be reused across all of the possible prompts that can show up in the importer.

I realize now (belatedly) that I should have used a PR so I could show y'all what was changing easily. But regardless, here's a compare view! https://github.com/beetbox/beets/compare/9b0a86...

Let me know if you have any feedback!

that's great, sampsyo, I recall when looking into adding [P]rint, the person who did had some challenges regarding that area of the code

Yeah, I hope this should be easier to understand now! And more capable, of course.

you say that they can be reused across all possible prompts. does that mean that adding prompt choices when an album exists is now pluggable?

nevermind. looked at the logs and doesn't look like it.

is it samps yo | sam Sio? sampsyo

Hi, is there any way I could ask beets to consider particular tracks to be a different file?

lengtche: That should be possible, using the fields on the `task` passed to the choice handler.

I guess I could just whip out sqlite3 and tweak pathes manually, but I’m hoping for a more manual solution

simukis_: Hmm, I don't think I understand. What exactly are you looking to do?

well, I got myself flac tracks of album I imported previously, but not all of them.

I would like to “upgrade” :D

behaviour-wise I suspect beets would simply find matching tracks that I’ve already imported and just change the `path` column of those to the new flacs

I suppose I’ll just edit the sqlite db directly

simukis_: That's what the "keep new" option does in the importer when a conflict is detected.

sampsyo: do you mean via plugin or modifying the code itself?

sampsyo: that option does not appear for partial album imports?

sampsyo: instead its telling me to pick between keeping either the old album or the new album with partial tracks

no suggestion either

lengtche: Via a plugin.

simukis_: Oh, are you looking to merge together old and new tracks from the same album? https://github.com/beetbox/beets/issues/112

sampsyo: Oh, thank you! I didn't think of doing that. The FAQ's appending prompt choices entry made me think it wasn't possible.