#beets

/

      • r04r is now known as zz_r04r
      • N0S4A2 has quit
      • Joschasa_ joined the channel
      • Joschasa has quit
      • Joschasa_ is now known as Joschasa
      • Vacuity_ joined the channel
      • Vacuity has quit
      • freakout has quit
      • freakout joined the channel
      • beat joined the channel
      • watsonalgas has quit
      • darwin
      • NOTICE: [beets] sampsyo pushed 2 new commits to master: https://github.com/beetbox/beets/compare/74aeb0edbcf8...2515f98dfc06
      • NOTICE: beets/master 06072c5 Christoph Reiter: tests: Fix setup.py test...
      • NOTICE: beets/master 2515f98 Adrian Sampson: Merge pull request #2087 from lazka/fix-setup-py-test...
      • lazka joined the channel
      • jrobeson
        lazka, i liked thed cleanups for the mutagen errors, but is that gonna fly with the various mutagen versions packaged in different distros?
      • excluding rhel/centos 6 of course
      • lazka
        jrobeson, as I noted in the commit message I tested with both 1.27 and master
      • 1.27 being the oldest supported by beets
      • jrobeson
        ah ok.. i guess i didn't get that
      • so can you fix the flake8 bit then?
      • lazka
        I think I did
      • jrobeson
        i didn't get a notification, and i thought github did that now, but mabye it's not rolled out to everybody yet
      • yay
      • lazka
        feedback to the mutagen changes welcome.. I haven't done a release with these changes
      • jrobeson
        i don't know the codebase well enough to comment
      • i'm just glad that you're fixing a python3 test for me :)
      • lazka
        jrobeson, I think I pushed a minute before you posted there
      • jrobeson
        i just don't like being annoying if i can avoid it .. except to sampsyo
      • jrobeson bugs sampsyo again haha
      • lazka
        jrobeson, I mean feedback for the changes from a user POV
      • jrobeson
        which user?
      • lazka
        you ;)
      • jrobeson
        consumer of mutagen or consumer of beets?
      • can you be a little more precise?
      • jrobeson doesn't get it yet
      • Qann has quit
      • Qann joined the channel
      • Qann is now known as Nomads
      • lazka
        jrobeson, the next mutagen release breaks some beets tests, thus the pull request. If you think any of the mutagen changes are wrong/counterproductive -> please complain.
      • Nomads
        With 1.3.19 I'm having trouble with permissions plugin. Somehow what once was working is broken.
      • When I import stuff beets finds them. Matches them. Tries to import them and at the last step it starts throwing out errors like this: http://paste.ee/r/l4gDv
      • jrobeson
        do you actually have the permission plugin enabled?
      • does it work without it?
      • Nomads
        Also, the imported files and folders become inaccessible due to incorrect permissions. Even though I have 755 and 644 set up in the config.
      • Now, I disabled and it works jrobeson
      • jrobeson
        ok, file a bug then
      • Nomads
        But I had to relocate my whole 600+gb to find out which folders weren't actually imported during my previous import. Because it didn't register some of those to database as well.
      • jrobeson
        i have my own problems with the permission handling in beets
      • i kinda don't think that the permissions plugin should be a plugin .. or at least not one you have to enable at all
      • Nomads
        Well, may be. You should at least specify user name to write the files with . Or maybe for those who're in need of specific permissions it should be useful.
      • I'm submitting a bug.
      • jrobeson
        lazka, you mentioned that you tested it against those mutagen versions, but i think that should be in the PR message
      • that is, just put most of mediafile: Cleanup mutagen error handling message in the PR message
      • lazka
        hm, ok
      • jrobeson
        if i wanted you to do even more work, I'd make you split out the alac detetion thing into it's own PR, but sampsyo won't make you do that :)
      • so you don't have to worry about that
      • lazka
        I thought of it more as a patch series
      • I'll split things up later, but busy right now
      • jrobeson
        I wouldn' tworry about it since sampsyo won't make you do it it :)
      • i am happy to see that hack gone, i was gonna get around to it, but py3 stuff was more important
      • that alac hack i mean
      • NOTICE: [beets] nomadturk opened issue #2089: Permission issues with permissions plugin https://github.com/beetbox/beets/issues/2089
      • Nomads
        I have one more issue. Whenever I run beet mv, I always have some files that tries to move themselves to the same folder they are in. This might be related to my renaming syntax (my config is on the upper link as well) but even if I run beet mv 10 times in a row, right now I see the same 200 files at each run.
      • jrobeson
        file that one too
      • Vacuity_ has quit
      • Vacuity_ joined the channel
      • Vacuity_ is now known as Vacuity
      • lazka has quit
      • zz_r04r is now known as r04r
      • Nomads
        Is there a way to let beets import the higher quality version of an existing album in quiet mode? (If possible a it can replace existing tracks in order to avoid track loss on a higher quality version with missing tracks) :P
      • r04r is now known as zz_r04r
      • asdil12 has quit
      • asdil12 joined the channel
      • zz_r04r is now known as r04r
      • watsonalgas joined the channel
      • Vacuity_ joined the channel
      • Vacuity has quit
      • thunderrd_ has quit
      • thunderrd joined the channel
      • lazka joined the channel
      • lazka has quit
      • N0S4A2 joined the channel
      • fredmorcos joined the channel
      • fredmorcos has quit
      • lazka joined the channel
      • NOTICE: [beets] sampsyo closed issue #2089: Permission issues with permissions plugin https://github.com/beetbox/beets/issues/2089
      • NOTICE: [beets] sampsyo pushed 1 new commit to master: https://github.com/beetbox/beets/commit/192dd321f12ddc8c29b1a9037bd5e0a9d3a14dfc
      • NOTICE: beets/master 192dd32 Adrian Sampson: permissions: Add debug logging
      • NOTICE: [beets] jbaiter opened pull request #2090: beatport: Use track numbers from API (#2085) (master...beatport) https://github.com/beetbox/beets/pull/2090
      • NOTICE: [beets] jbaiter closed pull request #2090: beatport: Use track numbers from API (#2085) (master...beatport) https://github.com/beetbox/beets/pull/2090
      • NOTICE: [beets] sampsyo pushed 1 new commit to master: https://github.com/beetbox/beets/commit/4955933670a48f892e27bf41756bd378a8c7440c
      • NOTICE: beets/master 4955933 Adrian Sampson: Update Mutagen dependency (#2088)...
      • NOTICE: [beets] jbaiter opened pull request #2091: beatport: Use track numbers from API (#2085) (master...beatport) https://github.com/beetbox/beets/pull/2091
      • lazka has quit
      • Kabouik joined the channel
      • jrobeson
        well that simplifies things :)
      • NOTICE: [beets] Schweinepriester opened issue #2092: Clarify remote_priority? https://github.com/beetbox/beets/issues/2092
      • sampsyo, the channel message (which I can't remember how to change) still points to radbox
      • NOTICE: [beets] Schweinepriester opened issue #2093: ImageMagick/artresizer fails on windows? https://github.com/beetbox/beets/issues/2093
      • thunderrd has quit
      • thunderrd joined the channel
      • untitaker joined the channel
      • sampsyo
        jrobeson: Huh -- the one when you join #beets? I also don't remember how to change that. :)
      • I think the person (rawsted?) who set up the channel set it up and I never thought about it again.
      • jrobeson
        howdy sampsyo
      • sampsyo
        Yo!
      • jrobeson
        glad somebody was able to figure out that issue!
      • sampsyo
        Yeah, that was truly crazy.
      • jrobeson
        i tried getting help on #python. and got down to debugging the locking, but hten the person had to go
      • comparing the python source though was a good idea :)
      • sampsyo
        Absolutely.
      • jrobeson
        so what's the top 3 items on your todo list? sorted by priority ?
      • sampsyo
        Do you mean about py3, beets in general, or just my whole life? :)
      • jrobeson
        let's stick with beets
      • sampsyo
        Well, in the category of near-term things, py3 and the modularization have bubbled up to the top lately because we have momentum
      • And the third is probably an AURA implementation, which is long overdue
      • jrobeson
        so, how what did you wanna do for py3?
      • sampsyo
        Getting a minimally working `beet version` or whatever on Python 3 would be awesome to do in the near term
      • And then we can grind away at the details one by one
      • jrobeson
        hmm? you mean the command beet version?
      • that's old news
      • i got all the way to the importer screen
      • where it gave me choices .. and tried every option but Apply
      • sampsyo
        Huh, I'm still getting `sys.stdout.write argument bust be str, not bytes`
      • jrobeson
        well it's been a fewe weeks
      • yeah, you need to help me out with what to do with the stdio!
      • that junk PR i have
      • i mean junk commit
      • sampsyo
        Ah, right -- I guess what I meant in terms of priorities was getting your current patch queue transitioned onto master
      • So we get the same level of py3 usability you're currently seeing in a 2/3 way
      • (even if that's not complete)
      • jrobeson
        so how do we do that? :)
      • sampsyo
        Good question! Do you have that link to the compare view again?
      • jrobeson
        1 moment
      • sampsyo
        I guess one place to start with `print_` would be to use `if PY2` to encode to bytes manually, and on py3 use the Unicode string directly.
      • jrobeson
        that one is too easy .. that's why i didn't bother doing it
      • sampsyo
        basically taking the three changes you have here and putting them behind a version check: https://github.com/beetbox/beets/commit/72520f8...
      • Easy but effective? Perhaps!
      • jrobeson
      • sampsyo
        thanks
      • lazka joined the channel
      • jrobeson
        i just wanted to remove one skipped PR cuz of lazka !
      • i mean one skipped test commit
      • then i ran the tests , and it passed, so!
      • sampsyo
        Woohoo!
      • jrobeson
        i just didn't wanna make those kind of decisions, so you can do what you think is best.
      • sampsyo
        Would you mind opening a PR with those changes to ui/__init__.py and I'll take it from there?
      • lazka
        if you ignore windows, getattr(sys.stdout, "buffer", sys.stdout).write(b"bytes")