#beets

/

      • asdil12 joined the channel
      • r04r is now known as zz_r04r
      • oldtopman has quit
      • oldtopman joined the channel
      • jrobeson
        uggh.. what to do now
      • we can't actually prove anything :(
      • hmm unicodenazi is less useful if the python stdlib itself is raising warnings
      • untitaker, this is the idioms for sorted i was referring to https://docs.python.org/2/library/2to3.html#2to...
      • untitaker
        jrobeson: that's not the same thing though
      • jrobeson
        hmm how so?
      • untitaker
        the two code pieces on that page do the same thing: They create a new list from an iterable and sort it
      • the code in beets creates a list, then copies the list, sorts that copy and returns it, then throws the first list away
      • darwin
        that seems likely to be.. not maximally efficient
      • jrobeson
        well using python isn't maximally efficient :)
      • in anycase though, i was just pointing out what i saw, not whether i was right or not
      • while skimming over the changes from py 2to3
      • darwin, this just came up because untitaker tried converting it in the same PR, and i was against it.
      • i'm certainly in favor of implementing it if it makes things better
      • darwin, in any case, it's a microoptimization compared to the bigger issues that could be solved for performance :)
      • some of these fixers could be smarter ..
      • nonzero
      • Renames __nonzero__() to __bool__().
      • tcollins has quit
      • except it doesn't check if __bool__ already exists
      • tcollins joined the channel
      • so ti'll break your code if you had tried to stay 2/3 compatible beforehand
      • i'm suprised 2to3 didn't handle the logger rename
      • thunderrd joined the channel
      • ah, because of the from logging import *
      • ok.. who knows mediafile ?
      • lansiir joined the channel
      • lansiir has quit
      • Joschasa_ joined the channel
      • Vacuity joined the channel
      • Joschasa has quit
      • Vacuity_ has quit
      • Joschasa_ is now known as Joschasa
      • freakout has quit
      • freakout joined the channel
      • interesting, even though u'' is supported in python 3.3, ur'' isn't
      • NOTICE: [beets] jrobeson pushed 1 new commit to master: https://github.com/beetbox/beets/commit/ce8d7bf9f10353ac1b1150934952b4a25ad587ce
      • NOTICE: beets/master ce8d7bf Johnny Robeson: remove unittest2 import (py < 2.7)
      • my favorite assertion
      • AssertionError: False is not true
      • beets makes it difficult to pull in single modules due to the code in beets/__init__.py
      • the way it is now, everything breaks on py3 before you even get to the tests
      • jrobeson has quit
      • jrobeson joined the channel
      • anybody about with a copy of the code and know why this line is in beets/__init__.py ? Library = beets.library.Library
      • i removed it, and all the tests still pass
      • NOTICE: [beets] jrobeson opened pull request #2024: Remove library import from __init__.py (master...remove-unnecessary-library-import) https://github.com/beetbox/beets/pull/2024
      • opatel99
        jrobeson: Have you checked https://github.com/beetbox/beets/commit/8fe53fe...
      • jrobeson
        that's from so long ago that it's unlikely to be valid now
      • opatel99
        oops true
      • jrobeson
        almost all that code is gone now
      • or rather, moved
      • opatel99
        In that case, nice catch!
      • jrobeson
        i'm trying hard to at least make the testsuite boot for python3
      • it pulling in library there was causing things to fail way before they should
      • I also think the config line should be removed from there
      • we shouldn't be doing that at import time, but at runtime
      • it's not causing anything to break though, because the config library at least passes all tests on python 3.4
      • maybe i'll revisit that when i get frustrated with this
      • i wish i would have figured that out 10-20 hours ago :(
      • i kept trying different approaches for running various levels of automatic python 3 conversion scripts/helpers to just get the thing to run the testsuite
      • DissonantGu1le joined the channel
      • DissonantGuil3 has quit
      • axion has left the channel
      • ok.. i'm not good at python, so what's up with this
      • beets/util/pipeline.py:if __name__ == b'__main__':
      • beat joined the channel
      • can somebody please please explain wny?
      • https://github.com/beetbox/beets/commit/9c41c39...
      • lazka joined the channel
      • DissonantGu1le
        Ever have beet import freeze up and not accept input?
      • DissonantGu1le has quit
      • jrobeson
        not accept what kinda input?
      • like there's a prompt for input, but you can't do anything?
      • if so, no
      • beat has quit
      • beat joined the channel
      • The_Freso joined the channel
      • lazka has quit
      • Freso has quit
      • The_Freso is now known as Freso
      • beat- joined the channel
      • beat has quit
      • opatel99 has quit
      • The_Freso joined the channel
      • Freso has quit
      • The_Freso is now known as Freso
      • zz_r04r is now known as r04r
      • lazka joined the channel
      • Vacuity has quit
      • Vacuity joined the channel
      • opatel99 joined the channel
      • lazka has quit
      • qpdb is now known as Guest59146
      • Guest59146 has quit
      • qpdb joined the channel
      • lazka joined the channel
      • lazka has quit
      • Freso
        jrobeson | if you have to use the word " and " in a PR, then you're doing too much -- I agree 120%!
      • untitaker_ joined the channel
      • DexterLB has quit
      • DexterLB joined the channel
      • jrobeson
        Freso, of course i take it way more seriously when contributing to someone elses code than my own personal junk :)
      • but i'm still mostly ok at it
      • DissonantGuile joined the channel
      • xsteadfastx has quit
      • xsteadfastx joined the channel
      • so i was browsing beets codecov and see this " Unable to retrieve commit from GitHub API. Please check that your bot user has authroization to beetbox/beets. "
      • just clicked on the view list in style icon https://codecov.io/gh/beetbox/beets/list/6230ea...
      • ah, i see it here too https://codecov.io/gh/beetbox/beets
      • thunderrd_ joined the channel
      • thunderrd has quit
      • NOTICE: [beets] jrobeson pushed 1 new commit to master: https://github.com/beetbox/beets/commit/9b2e12613269ddd6dddde7fb3dec7a448523971e
      • NOTICE: beets/master 9b2e126 Johnny Robeson: remove __future__ import from py3 native release.py
      • i didn't even know this was something to be concerned about in this day and age
      • _windows_long_path_name(
      • thunderrd joined the channel