hey maggie_s looking at the timing issue in the editor you just filed
maggie_s
sylvainc: thanks a lot! it is a YT-specific issue, just in the editor
sylvainc
very strange, it actually does play after the 3:56 mark, but it looks very strange
do you knnow if it is new?
maggie_s
the first report was filed 11 hours ago
janeted
oh cool - we are all in here
maggie_s
this is something that users would notice almost instantly
janeted
sylvainc, it's OK in the Old editor too
sylvainc
so far it seems like popcorn's returned duration is wrong, but we do not use it outside the new editor... still investigating
maybe it is a consequence of the youtube API deprecation
it is using version 2 apparently, inside popcorn
janeted
ugh -
i suppose popcorn hasn't updated
sylvainc
very low activity on popcorn
janeted
can we workaround?
I noticed that
last commit was months ago
we should probably start thinking about alternatives for the future
sylvainc
janeted: I think I get a fix
we actually do not need that call to the api
and can get the duration from the player
janeted
oh greate
sylvainc
so I will push that fix (in popcorn) directly into staging
then we'll see on how to make it cleaner (should push it to popcorn)
or shall I put it into a branch? janeted? shall we do a pass of test before deploying it?
maybe it is cleaner and we might have a little bit of time before US wakes up?
janeted
I can do some testing first
sylvainc
janeted: just pushed to gh-2210
it displays the wrong timing for like a second, until the player is fully loaded and gets it right
hopefully that is enough for now until we make popcorn completely fixed
janeted
sylvainc, if you wanted - can merge this to production and we could deploy prod with just this change
sylvainc
sure, but right now this is based on staging
do you think i should base the change on produciton?
as I think staging is different than prod
janeted
can't you just merge the 1 commit to prod?
sylvainc
al least because of the styling changes
yes, sure
janeted
I think that would be best -
we could merge the styling changes but I'd prefer just to do the 1 fix here and let rest follow our usual process
but if we wait - then we disrupt the whole European morning for subtitling
sylvainc
i agree 100%
ok janeted, just added that commit on production
janeted
ok sylvainc maggie_s : just started production deploy with this initial workaround fix. I'll leave the 2210 ticket open and drop the priority to important for the longer-term better fix.
maggie_s
awesome, thanks!
janeted
I'll let you know when it's done, usually takes about 20mins for the deploy to complete
maggie_s
ok
janeted
maggie_s, sylvainc production deploy is completed
as sylvain said, maggie_s , you'll initially see the incorrect value, and then it will update to the real value