0:19 AM
willkg has quit
1:14 AM
DarrenBridenbeck has quit
4:22 AM
janeted has quit
4:40 AM
janeted joined the channel
6:46 AM
sylvainc joined the channel
10:52 AM
maggie_s_ has quit
12:53 PM
willkg joined the channel
13:14 PM
janeted
ehazlett, have you and bendk been able to figure out what's up with the youtube linking on staging yet?
13:21 PM
ehazlett
janeted: we updated the api keys and i updated the allowed IPs -- i'm not sure what to look for after this
13:22 PM
the error above is different that before
13:22 PM
so i'm not sure that key was the issue
13:22 PM
janeted
hey bendk what do you think is the next thing to check with staging?
13:23 PM
bendk
ehazlett: it's definitely allowed IPs
13:23 PM
I just changed it to empty (all IPs allowed) and things seem to be working
13:23 PM
ehazlett
hmm which instance were you testing from?
13:23 PM
bendk
the IPs should be both the IPs of the servers and the workers
13:23 PM
staging
13:23 PM
ehazlett
i added all of the servers
13:23 PM
staging where?
13:23 PM
bendk
weird
13:23 PM
13:23 PM
ehazlett
from one of the new util instances?
13:23 PM
did you start a new one?
13:24 PM
bendk
nope
13:24 PM
just the current staging
13:24 PM
ehazlett
or update the settings with the new key?
13:24 PM
bendk
13:24 PM
yeah, updated the settings
13:24 PM
ehazlett
hmm ok
13:24 PM
bendk
I can change it back to the old settings if you want, seems like there's some IP missing
13:24 PM
ehazlett
well i had both docker hosts and the builder host
13:24 PM
which is the only place the containers run
13:24 PM
(and 127.0.0.1 for testing)
13:24 PM
bendk
that's really weird
13:25 PM
ehazlett
ok well is there an easy way to test the setting?
13:25 PM
so i can hammer on the IPs to figure out what it's blocking?
13:26 PM
bendk
yeah, just add a youtube video
13:26 PM
if the title is correct then the setting is correct
13:26 PM
otherwise the title will be the URL and there will be no description or other metadata from youtube
13:26 PM
you can do subnets too if that helps
13:31 PM
ehazlett
ok
13:31 PM
yeah we can't do subnets or it will allow all of AWS
13:42 PM
ok so i think i know what it may be
13:42 PM
the request was probably coming via the ELB
13:42 PM
and it's IP can change dynamically
13:42 PM
so...
13:42 PM
ugh
13:43 PM
i think the only thing we can do is to either limit it to AWS subnets (which still may break) or leave it open and try some type of key rotation or something
13:43 PM
bendk: ^
13:43 PM
janeted has quit
13:45 PM
janeted joined the channel
13:59 PM
bendk
ehazlett: so I guess AWS subnets is better than open
13:59 PM
and if someone wanted to do some sort of attack on our key they would still need to get access to it
13:59 PM
I think it should be okay
14:00 PM
the worst that happens is that someone gets our key, uses an AWS instance to get some public youtube data, then we generate a new one
14:08 PM
ehazlett
the only problem would be if the subnet changed -- because most of time it's 54.x.x.x but can be others
14:08 PM
if it did change, we would get random fails for YT until we noticed and added the new one
14:08 PM
i'm thinking the key rotation would be safer from an application standpoint
14:08 PM
if we have retries or something then we could do the subnets
14:11 PM
janeted
bendk, did you see my comments regarding the syncing-triggers branch?
14:11 PM
14:13 PM
oh and bendk looks like the commits you mentioned last night for the newmedia branch didn't get pushed.
14:13 PM
14:14 PM
bendk
ehazlett: key rotation is great for me as well
14:14 PM
and then we just allow all IPs
14:15 PM
janeted: yeah, I'll work on those issues in syncing-triggers
14:15 PM
I didn't push any commits yesterday, I think it might have been previous commits
14:15 PM
did you try running the webdriver tests?
14:17 PM
janeted
no I didn't I was looking for the changes.
14:17 PM
it's the watch_page tests that fail the most
14:21 PM
bendk
yeah, so when I ran that I only saw 1 failure
14:21 PM
the add_youtube_feed test
14:22 PM
ehazlett
ok sounds good
14:23 PM
bendk
janeted: well, in any case I'll take a bit more time with the tests today
14:23 PM
there were a couple things I think I can improve
14:23 PM
be back in a bit
14:23 PM
janeted
thanks, appreciate it
14:23 PM
bendk has quit
16:10 PM
bendk joined the channel
17:20 PM
franontanaya joined the channel
17:29 PM
franontanaya
is it ok if I start a repository in pculture for greasemonkey UI enhancements? I've got a caption duration/length checker ready to upload
18:12 PM
bendk
franontanaya: fine w/ me
18:13 PM
janeted: just pushed some changes to the newmedia branch
18:13 PM
turns out the error from selenium was a real issue
18:13 PM
the search page wasn't working, it would just keep the loading icon there forever
18:13 PM
I think I fixed that and a bunch of other JS issues
18:13 PM
janeted
oh - weird because I could search running locally
18:13 PM
bendk
hmm
18:13 PM
I couldn't
18:13 PM
it really shouldn't have worked
18:13 PM
maybe some sort of caching issue
18:14 PM
ahh, maybe it worked before some of my other changes
18:14 PM
I made a change to how STATIC_URL worked
18:14 PM
it fixed a bunch of things ,but maybe messed up the javascript includes on the search page
18:14 PM
anyways give it a try
18:14 PM
I'm going to make a dev branch with just dev-commands in it
18:17 PM
janeted
ok sounds good bendk - i'm actually heading out for a bit, but I'll let you know how it goes tomorrow
18:17 PM
bendk
janeted: is it okay to remove docker-dev-environment? Do you use it for anything still?
18:18 PM
no problem, you're not blocking me at all
18:18 PM
janeted
no - not using it anymore
18:19 PM
bendk, ehazlett - are we close on getting the yt stuff sorted on staging?
18:19 PM
nigel_bot has quit
18:19 PM
nigel_bot joined the channel
18:19 PM
bendk
janeted: I think it might be working now
18:20 PM
ahh, nope :(
18:20 PM
but we have a plan to fix it
18:20 PM
ehazlett: I think you have all the info you need to set things up right?
18:20 PM
janeted
ok - plans are good + there are still the issues in the syncing-triggers branch that we'll need
18:21 PM
ehazlett
bendk: everything is setup
18:21 PM
the key is changed and the allowed ips are good
18:21 PM
sorry -- i still have to test
18:22 PM
bendk
I see the same keywhen I log in
18:22 PM
when I add youtube videos I don't see the metadata coming in
18:22 PM
janeted: sylvainc: okay, the dev branch is set up
18:23 PM
right now it's dev-commands merged with staging
18:23 PM
if you have code that you want to put in the deploy after the next one, dev is the place for it
18:23 PM
hopefully this extra branch is short-lived
18:24 PM
sylvainc
bendk: so we should work on new tickets on branches taken from that dev branch, right?
18:25 PM
bendk
yeah, unless it's pretty urgent and/or trivial
19:12 PM
bendk has quit
19:28 PM
bendk joined the channel
19:45 PM
michelled joined the channel
20:53 PM
sylvainc has left the channel
20:59 PM
maggie_s joined the channel
21:33 PM
michelled has quit
22:16 PM
franontanaya has quit
22:56 PM
maggie_s_ joined the channel