#amara

/

      • willkg has quit
      • DarrenBridenbeck has quit
      • janeted has quit
      • janeted joined the channel
      • sylvainc joined the channel
      • maggie_s_ has quit
      • willkg joined the channel
      • janeted
        ehazlett, have you and bendk been able to figure out what's up with the youtube linking on staging yet?
      • ehazlett
        janeted: we updated the api keys and i updated the allowed IPs -- i'm not sure what to look for after this
      • the error above is different that before
      • so i'm not sure that key was the issue
      • janeted
        hey bendk what do you think is the next thing to check with staging?
      • bendk
        ehazlett: it's definitely allowed IPs
      • I just changed it to empty (all IPs allowed) and things seem to be working
      • ehazlett
        hmm which instance were you testing from?
      • bendk
        the IPs should be both the IPs of the servers and the workers
      • staging
      • ehazlett
        i added all of the servers
      • staging where?
      • bendk
        weird
      • ehazlett
        from one of the new util instances?
      • did you start a new one?
      • bendk
        nope
      • just the current staging
      • ehazlett
        or update the settings with the new key?
      • bendk
        I logged into the console for administrator@pculture.org and changed the settings there
      • yeah, updated the settings
      • ehazlett
        hmm ok
      • bendk
        I can change it back to the old settings if you want, seems like there's some IP missing
      • ehazlett
        well i had both docker hosts and the builder host
      • which is the only place the containers run
      • (and 127.0.0.1 for testing)
      • bendk
        that's really weird
      • ehazlett
        ok well is there an easy way to test the setting?
      • so i can hammer on the IPs to figure out what it's blocking?
      • bendk
        yeah, just add a youtube video
      • if the title is correct then the setting is correct
      • otherwise the title will be the URL and there will be no description or other metadata from youtube
      • you can do subnets too if that helps
      • ehazlett
        ok
      • yeah we can't do subnets or it will allow all of AWS
      • ok so i think i know what it may be
      • the request was probably coming via the ELB
      • and it's IP can change dynamically
      • so...
      • ugh
      • i think the only thing we can do is to either limit it to AWS subnets (which still may break) or leave it open and try some type of key rotation or something
      • bendk: ^
      • janeted has quit
      • janeted joined the channel
      • bendk
        ehazlett: so I guess AWS subnets is better than open
      • and if someone wanted to do some sort of attack on our key they would still need to get access to it
      • I think it should be okay
      • the worst that happens is that someone gets our key, uses an AWS instance to get some public youtube data, then we generate a new one
      • ehazlett
        the only problem would be if the subnet changed -- because most of time it's 54.x.x.x but can be others
      • if it did change, we would get random fails for YT until we noticed and added the new one
      • i'm thinking the key rotation would be safer from an application standpoint
      • if we have retries or something then we could do the subnets
      • janeted
        bendk, did you see my comments regarding the syncing-triggers branch?
      • oh and bendk looks like the commits you mentioned last night for the newmedia branch didn't get pushed.
      • bendk
        ehazlett: key rotation is great for me as well
      • and then we just allow all IPs
      • janeted: yeah, I'll work on those issues in syncing-triggers
      • I didn't push any commits yesterday, I think it might have been previous commits
      • did you try running the webdriver tests?
      • janeted
        no I didn't I was looking for the changes.
      • it's the watch_page tests that fail the most
      • bendk
        yeah, so when I ran that I only saw 1 failure
      • the add_youtube_feed test
      • ehazlett
        ok sounds good
      • bendk
        janeted: well, in any case I'll take a bit more time with the tests today
      • there were a couple things I think I can improve
      • be back in a bit
      • janeted
        thanks, appreciate it
      • bendk has quit
      • bendk joined the channel
      • franontanaya joined the channel
      • franontanaya
        is it ok if I start a repository in pculture for greasemonkey UI enhancements? I've got a caption duration/length checker ready to upload
      • bendk
        franontanaya: fine w/ me
      • janeted: just pushed some changes to the newmedia branch
      • turns out the error from selenium was a real issue
      • the search page wasn't working, it would just keep the loading icon there forever
      • I think I fixed that and a bunch of other JS issues
      • janeted
        oh - weird because I could search running locally
      • bendk
        hmm
      • I couldn't
      • it really shouldn't have worked
      • maybe some sort of caching issue
      • ahh, maybe it worked before some of my other changes
      • I made a change to how STATIC_URL worked
      • it fixed a bunch of things ,but maybe messed up the javascript includes on the search page
      • anyways give it a try
      • I'm going to make a dev branch with just dev-commands in it
      • janeted
        ok sounds good bendk - i'm actually heading out for a bit, but I'll let you know how it goes tomorrow
      • bendk
        janeted: is it okay to remove docker-dev-environment? Do you use it for anything still?
      • no problem, you're not blocking me at all
      • janeted
        no - not using it anymore
      • bendk, ehazlett - are we close on getting the yt stuff sorted on staging?
      • nigel_bot has quit
      • nigel_bot joined the channel
      • bendk
        janeted: I think it might be working now
      • ahh, nope :(
      • but we have a plan to fix it
      • ehazlett: I think you have all the info you need to set things up right?
      • janeted
        ok - plans are good + there are still the issues in the syncing-triggers branch that we'll need
      • ehazlett
        bendk: everything is setup
      • the key is changed and the allowed ips are good
      • sorry -- i still have to test
      • bendk
        I see the same keywhen I log in
      • when I add youtube videos I don't see the metadata coming in
      • janeted: sylvainc: okay, the dev branch is set up
      • right now it's dev-commands merged with staging
      • if you have code that you want to put in the deploy after the next one, dev is the place for it
      • hopefully this extra branch is short-lived
      • sylvainc
        bendk: so we should work on new tickets on branches taken from that dev branch, right?
      • bendk
        yeah, unless it's pretty urgent and/or trivial
      • bendk has quit
      • bendk joined the channel
      • michelled joined the channel
      • sylvainc has left the channel
      • maggie_s joined the channel
      • michelled has quit
      • franontanaya has quit
      • maggie_s_ joined the channel