#amara

hey ehazlett - I'm pretty sure dean was wanting you to deploy his pculture.org changes.

hi sylvain - everything go OK yesterday ??

yes, thanks, was a long-awaited day ;-)

good.

sylvainc, can I get your opinion on this one?

sure janeted, let me have a look

it involves changing how the keyboard shortcuts display and adding some help guidelines

yes, that looks good, I'm just wondering if we should break it into several tickets... but it is actually not that much coding

so it might be ok in one ticket,

however you prefer, I think the style guide doens' t really belong there

one thing is that I'm not sure all shrtcuts are workable, in case there is a conflict with the browser's or OS's shortcutrs

right - but we don't need to implement them all right now

just getting the display to look good, so the UI is more friendly to the user and we can keep the others as proposed.

ok, sounds right,

it may be good to get some community feedback on some of the others from the power users.

one thing, should we add a "+" between keys in the help panel?

when they need to be pressed at the same time?

you don't think that's obvious?

another thing I can't really visualize, is if the buttons should all be the same blue - of if we should use different colors

the old editor had different colors and it was very eye-catching.

maybe we can experiement with that after

sure, I'm not confident with my opinios on appearence ;-)

I'm not either

so let's start with the design you put in the ticket

but if we get something started - it'll be easier to tell or ask for a second opinion

OK - and actually it was this guy Tom who did the mockup - he's a student volunteering some time

so I put the assets in the amara-assets repo

we are so close to doing this switchover,

i saw that, good, I'll assign this ticket to myself,

great thanks

is it in the list in the wiki?

I just added it in the help section

ok, great

I'm going to go cross off all the tickets that are ready for merge.

There's a few more related to the dialogs that ben should be fixing

go cool, I was espceially thinking of https://github.com/pculture/unisubs/issues/1217

from title it does not seem importsnt, but it includes a fix for mp4 videos on firefox

without that one, mp4 videos can't work in editor/embedder on FF

yes - I think we can deploy the changes that are currently merged to staging

basically any of the editor fixes.

as we go along

I think the other security ticket ben did is ready - I just wanted to confirm that

ok, good.

I think we can keep updating, and then once we are ready - the last push will have to be 1121 - which switches over all the dialogs.

so ideally - we just keep improving as usual and merge / deploy 1121 branch for the switchover

right

I think we can add auto-pause to the nice-to-have section

it's a great feature - but I have no idea how complicated.

And I think we should switch the embedder over separately (afterwards)

sylvainc: are you on?

what do you think about making a new branch for making the new editor the primary one?

right now I'm working on gh-1121, but that branch is covering more issues than just 1121

yes, i'm here

shall that branch include everything that should not go on production before we swiutch over to the new editor?

exactly

ok, right, I remember that 1121 branch was "the last one"

yeah, 1121 changes the dialogs and stuff to make the new editor primary, then it contains several more fixes

and now I'm going to work on 1255 and 1239

I could actually make branches just for those issues and base them from staging

but I figure the merging is going to get harder and harder between staging and gh-1121

oh, i see,

how about regularly merge staging back to gh-1121? do you think it'd be workable?

yeah, that's possible

I think it would be a bit harder to merge, but on the other hand we could push the changes incrementally

okay, you've convinced me

I hope I understood you correctly then ;-)

hey ehazlett can you take a look at this pull request please.

janeted: merged

and if it's ok to merge, can you merge it and deploy staging. We have a bunch of stuff on there and before we get any more,

I'd like to run through it and maybe do prod tomorrow

yeah

all: deploying staging

cool thanks

janeted: staging deployed

cool thanks

yw