#amara

janeted: ehazlett: is there anything in Sentry for http://www.amara.org/en/videos/srpaQUga8RFQ? looks like this page is corrupt

Hello maggie_s , are you Margarita?

sylvainc: Hi - yes :)

Cool :) I usually bother janeted, but she does not seem to be around, so I wonder if I can ask you for some help?

got to go too... will ping you or janet later...

Hi janeted , are you around?

sylvainc: sorry, just saw your lines ^^ - you can call me by nickname (maggie_s:) if you need something quickly

no worry, thanks, i'm still a beginner at irc!

sylvainc: not a problem, you'll learn fast!

sylvainc: anything I can help you with now?

I am working on the new editor issues and and i'm a little confused with the difference between the old and new ones, and the content they create

There is an issue about the pararaph "div" tags

do you see what they are?

sylvainc: paragraph breaks, like here: http://www.amara.org/en/videos/QMCEWO0how9s/en/...

sylvainc: at 0:48, 1:06 etc.

If i understand well, they are in the old editor, and can be added by pressing a small "pi" button, which adds something like "startOfParagraph"

I think that's it

sylvainc: yes, exactly

and there is an issue from TED about it

where it gets lost smehow

sylvainc: yes, they use this feature extensively

what I am confused about is that I don't see such thing in the new editor

and neither in the data model associated to it,

sylvainc: because it isn't there yet :)

:)

at least i got that right!

but it seems like one can add html as part of the new content

sylvainc: hmm... I understand the UI, but the data model?

one can add html tags...

is it related?

i mean in the new editor, subtitles only have "content", "starttime" and "endtime"

no "startofparagraph"

sylvainc: I believe div tag in dfxp format corresponds to the paragraph break

do you think i should have an equvalent button in the new editor?

because the problem with having users just type in their html tags is that they might be incorecctly opened/closed

sylvainc: yes, we are moving away from using tag formatting towards a WYSIWYG editor - so it would be best to go with adding a button

ok, cool.

So TED is using the old or current editor now?

sylvainc: users seem to be comfortable with the way it was done in the legacy editor

sylvainc: both

hum... that is why they have probem? When they switch to the new editor, they lose the paragraph formatting?

sylvainc: no, if it is already in the subtitle version, it should hold through an edit in the new editor. But if they start a new translation in the new editor, or continue editing an almost non-existent one, they won't get paragraph marks where the source language has them

ok, that's what i working on, getting cleat now.

Meanwhile, I guess, for now, users can add any tag inside the new editor, which can mess up the page (it is actually a security hole I thing), do you thing these should be escaped (if a user inputs "<div>", it will display "<div>", not create a div tag)?

sylvainc: frankly, I am not very sure if anyone does this - Fran might know better about it

sylvainc: <div> tags can come from uploaded files - but I am not sure they should be typed from inside the new editor

janeted has sent me a doc about the design of the new editor, I'll look at this, it might be explained inside

For now, in the new editor, we only care about these paragraph tags and don't expect other type of rich formatting?

sylvainc: the spec? it should be pretty old, I don't think it covers such details

apparently they (Janet and Nicholas) reviewed it last Friday

sylvainc: there is also markdown formatting for bold/italics, but these should be replaced with UI controls in the future

ok,

sylvainc: and line breaks

you're right it does not seem to talk about formatting

sylvainc: yes, it is about the general layout, and some details are outdated

Thanks for all these, what I don't get now is the technical design: is that we seem to save the html tags in the "content" of each subtitle, but for the paragraph tags, they would be opened and closed in different subtitle, so it is hard to make sure the whole thing is valid HTML, especially as people will insert/delete/edit subtitles...

Maybe I shall talk about this with Ben I guess?

sylvainc: that would be best, I think

ok, thanks a lot again, that was very useful!

And by the way, I was wondering where you are located, you seem to be working at any time on the clock?

sylvainc: no problem, you are welcome

sylvainc: I am in Vancouver BC (Pacific timezone)

sylvainc: actually, already going to hit the hay - it is almost 4 AM here

wow, sorry to keep you up!

sylvainc: no trouble at all!

sylvainc: it was nice to chat with you

sylvainc: ok, going afk now, ttyl!

hey sylvainc:

for the copy timing ticket I chatted with nicholas yesterday and we agree that making a menu there will be the best ui for those

So basically instead of copy subtitles, and hide timeline, we add a Tool menu with a little icon that drops down to show the things we want on there

Hide Timeline, Copy Timings ...

ok, thanks

and I also wanted to ask you about which case one could possibly copy timings? For instance if user inputs the first, primary subtitles, I guess, they should not have this option

right - either on a translation or an edit

basically if there is a reference language available in the left side (with something to copy)

sylvainc ^^

sorry, I was away, thanks! yes, that what I was expecting, but actrually had difficulties being able to detect that...

If you have time, it would be great if you could check my last changes, for 1044. It should be mainly it, expect for the paragraph thing, and also the visibility issue we just mentionnned,

For the paragraph issue, I'll email Ben right now, as I am quite confused with the new data model and the way to convert from the data model of the old editor

janeted: ^^

sylvainc, I'm pretty sure it's stored internally in dfxp format. All the work is done by babelsubs

ehazlett, I think the irc is eating my message.

can you please deploy staging when you get a chance

janeted: yes -- sorry didn't get anything :(

yeah - i really think it ate it

all: staging deployed

hey janeted so it seems like that fix is good to go

to me at least, how does it look to you?

yes - seems fine to me

I checked the things you mentioned

and asked ehazlett to include it in the production deploy

that 404 with the trailing slash seems okay too

I'm pretty sure it will happen on production as well

seems like no big deal for that url

yeah, we probably should remove those urls/views

a video page with or without the slash is fine

it's weird that we had this issue for so long, but no one noticed it

is this possibly related to the errors over the weekend?

no idea -

ehazlett, did you see anything about those save errors that were reported?

janeted: yeah i responded

i saw a few sentry errors but i thought ben said they weren't related

i thought he said he had a fix

oh, I'm not sure if those sentry errors are reported to the save issues... I was just saying they weren't related to the issue where they went to the video page and no content was on it

the problem with the save issues, is we have 1 screenshot (old editor) showing that it says they can't save, and some people complaining on facebook

no useful information

yeah i know

janeted: and i would think if it was an issue we would hear from other channels

janeted: i'm merging staging to production and deploying / migrating

all: deploying prod

janeted: good news— just confirmed that the feed on ondemand040 is working. new videos were added recently!