#amara

Project unisubs-staging build #2076: STILL FAILING in 11 hr: http://dev.universalsubtitles.org:8888/job/unis...

* ben: Order video actions by creation date (#812)

* ben: Remove permissions checks for activity tabs (#869)

* ben: Fix the video activity tab (#869)

* Evan: added PIL dependencies for worker

maggie_s: so that private team video showing up on the site ticket

Seems like it's specific to videos added to the team via a feed - I can't reproduce when I add a single video

janeted: right--same for me

so that may have been like that for a while -

but we should fix it. the attitude team added videos via a feed.

there's another ticket about team feed not associating new videos back to the original team when they update

janeted: team-bound feeds are a relatively new and not too much advertized feature

janeted: but the video privacy thing should definitely get fixed

for sure

yep - that's definitely on production

ok - so it's not a regression with the recent changes that are on staging

did you notice anything else weird on there?

janeted: not really--in fact, staging was pretty backlogged with videos being added in the background, so I didn't do anything except uploading subtitles there

ok

that TED LC postedit bug is fixed on there

we should be able to push those fixes today

483? cool

Project unisubs-staging build #2077: STILL FAILING in 11 hr: http://dev.universalsubtitles.org:8888/job/unis...

* ben: Refactored utils tests.

* ben: New system for tracking hit counts

* ben: Switched to using the new hitcounting system

* ben: fixed JS syntax error

* ben: Removed a couple count columns from videos/languages

* ben: Changed post edit subtitles permissions check (#483)

* ben: Fixed AttributeError in indexing code

* ben: Updated feedback link for the new editor

* ben: Fixed widget download link (#473)

* ben: Display video view counts again

* ben: Don't use INSERT DELAYED

* janet dragojevic: update test data fixtures

* janet dragojevic: remove screenshot and outdated test

* ben: Remove double border on view count

* ben: Fix post edit permissions for language manager (#483)

* ben: Fixed can_add_version() permission

* ben: Fixed get_counts() when there isn't a LastHitCountMigration

ehazlett: I am still getting errors on jenkins trying to kick off the selenium tests.

janeted: ugh ok checking

ehazlett: bendk I did run them locally for the staging branch - and all the fixes that are currently on staging are good to deploy

also made a pull request for the ted api fix

janeted: ok i restarted the jenkins agent on ci-00 -- can you try again?

sure

thx

so if we want to add they - we'll have a pretty good deployment. bendk sound right to you?

migrations are part of it.

ehazlett: ImportError: No module named feedparser

janeted: so the pip install probably failed (or github)

link to the build?

sure

thx

bendk: did you change any module imports or anything recently? one of the jenkins jobs is failing with an import error (feedparser)

ehazlett: I don't think so

feedparser is a 3rd party library

ehazlett: this is on staging?

bendk: yeah

weird

it's in the deploy/requirements.txt file

ah i thought we had that in our libs

ok so maybe it's just a pip error

sorry for the noise

ehazlett: so I'm looking through the youtube syncing code and I was wondering if you understood any of it :)

it's pretty insane as far as I can tell

bendk: not much -- it's insane

anyways, my question it seems like we can either sync the subtitles using our ALWAYS_PUSH_ACCOUNT, or the account that's linked to the team/user

do you have an idea which one we do most of the time?

i was going to try to get the debug working but have been trying to get the last infrastructure issues resolved

ehazlett: I wouldn't worry about that

ok

I'm going to try to fix the youtube system along with the kaltura syncing

well one sec -- let me look at the script i just wrote to sync the cielo stuff

haha

nevermind

bendk: as far as I can tell, we use the accountlinker.models.ThirdPartyAccount.mirror_on_third_party to do the syncing

yeah, so in that method there's 2 ways that we can sync

one is if the YoutubeSyncRule matches the user/team/video, then we try to sync it with our ALWAYS_PULL_ACCOUNT

which I guess is some account that should be able to sync subtitles for any youtube video

but that rule will basically never match

bendk: right it is

so we fall through to the next way, which is using the 3rd-party account that's linked to the video

bendk: what do you mean never gets matched?

bendk: http://d.pr/i/OgVZ

it should if we have YOUTUBE_ALWAYS_PUSH_USERNAME in the settings i believe

and that user is setup (which i think it is for staging and prod)

ehazlett: so a side question: do you know if graphite is working?

i could be wrong -- very wrong :P

bendk: should be

I looked at several graphs and it didn't seem like they were updating

okay 1 sec

bendk: it is for everything i've seen

bendk: but not sure about app side

yeah, so that should log to youtube.push.request and youtube.push.success, but I don't even see youtube.push on the graphite list

bendk: looks like it https://graphite.amara.org/render/?width=586&am...

bendk: production -> all-hosts -> youtube -> push

isn't that production.all-hosts.youtube.api_request.rate-per-second

bendk: smarty pants ;)

so anyways, there's this section of code:

rule = YoutubeSyncRule.objects.all()[0]

should_sync = rule.should_sync(video)

always_push_account = self.always_push_account()

rule.should_sync() tests the video, owner, and team against the teams in the rule

but the only thing I see on production that will match is if team==darrentest

so we don't sync then

but at the bottom, there's another test, which checks if action==UPDATE_VERSION_ACTION

and if that's true we also sync, but this time I think we use the 3rd-party account that's linked to the video, not the always push account

basically insanity

bendk: if team==darrentest is the experiement with the yt api thing that was turned off by yt a few weeks ago

very likely

that makes sense

that's that thing that the debug page button is currently hooked up to

janeted: for that experiment, were we using the youtube user AmaraSubtitleTest?

I really don't know - the person now who'd likely know the most is margarita -

janeted: one more question... Do you know how we get the oath access data for youtube accounts?

bendk: ugh yeah i'm not sure

I'm guessing when you add the account you have to click some link that says you authorize amara to access your youtube data?

and if so, do the users ever need to refresh that?

bendk: correct -- they don't need to refresh unless they remove the authorization from their youtube account

We've had some team account owners needing to resync

bendk: or change their username, etc.

but they had changed their account name on yt

janeted: do you have our secret key for the kaltura stuff?

hey bendk - just had this odd error show up against the staging branch

I think dean should have got it in an email

bendk: I have the login and pw

janeted: okay, I can fix that one

1 sec

janeted: okay that error should be fix on staging

I just added a couple commits, without doing pull requests because it was really simple