#amara

all: wrapping up for today, have a good one and tty tomorrow!

sjl: can you take a look at this pull request when you get the chance?

all: morning

ehazlett: how do?

ehazlett hey

arthurdebert: hey

all: howdy

nicksergeant: how do?

all: errand to run, be back in 40

all: the admin pages on my vagrant vm seem to be lacking css any idea why?

bendk: what branch are you on?

bendk: I always manually symlink the django admin media into the media directory

dev

bendk: yeah that's supposed to be setup in the nginx config -- let me check -- like sjl said you can always symlink to /opt/ve/vagrant/...

symlinking worked perfectly, thanks

Project unisubs build #5320: FAILURE in 21 sec: http://dev.universalsubtitles.org:8888/job/unis...

all: i have a dr appt at 1:15p today so i'll be out from 1p to probably 2:30-ish

Yippie, build fixed!

Project unisubs build #5321: FIXED in 14 min: http://dev.universalsubtitles.org:8888/job/unis...

janet dragojevic: update test description

all: gonna be heading out for a long lunch around 12:15 -- my old boss from back in college is back in town and a bunch of us are getting lunch

all: should we unassign honza's tickets in sifter so they go back in the normal list?

sjl: makes sense to me

Project unisubs build #5322: FAILURE in 9 min 49 sec: http://dev.universalsubtitles.org:8888/job/unis...

Steve Losh: 2199: prefer approve to review tasks when unpublishing

all: at doc appt now and won't be back until later, I'm just taking the day off

arthurdebert: ehazlett just sent an email about the s3 hosting/aspera stuff

deanjansen: ok

it should be pretty high priority – arthurdebert not sure if you want to be in charge of prioritizing?

deanjansen this will be handled by ehazlett right?

arthurdebert: yes

deanjansen ehazlett this is out of band with releases, so I just set it to critical and he can work on it as soon as he has the time

arthurdebert: sounds good to me

ehazlett: if you have a sec to answer the questions via email, I can get back to them about it

arthurdebert: can you add the importing code in that ticket (for the team)

deanjansen: answering now

ehazlett: ty

deanjansen: yw

ehazlett: just sent one follow up q, but generally sounds good

all: brb

deanjansen: ok

Yippie, build fixed!

Project prod_tes build #1745: FIXED in 7 min 45 sec: http://dev.universalsubtitles.org:8888/job/prod...

Arthur Debert: Fixed tests for new signature

all: heading out to dr. appt ; back in a bit

ehazlett later

janeted do you know if there's any info on how to test the youtube syncing stuff ( yt credentials to use, etc)?

all: any one has the creds for amaratester user on yoube?

all: lunch + errands will be back at 15:20

all: back

sjl: I just opened up a pull request for babelsubs for those diff changes we talked about

bendk: ok, I'll take a look in a little while

thanks

all: back

hey sjl - quick question

I was just testing i2199 -

2199 - DMR: unpublishing a language w/o deleting creates a Review task instead of Approve - https://unisubs.sifterapp.com/issue/2199

it's fine and I made a test for it

however there was a comment in there about the flip side when there is no approve required in the workflow - that a review task would be created

however I noticed that when there is no Approval required in the workflow - there is no Unpublish button in the UI. So...

is that a bug - should there be an unpublish button - or is that by design?

what are the rules for when unpublish is displayed?

hmm

I didn't think about that

I'm not entirely sure. Maybe we only show unpublishing when approve is enabled and thus we'll never hit the case I mentioned

hmm, well it seems that the backend at least expects review-only teams to still support unpublishing: https://github.com/pculture/unisubs/blob/dev/ap...

all: back

janeted1: aha, the button is indeed hidden for review-only teams https://github.com/pculture/unisubs/blob/dev/ap...

janeted1: as far as I can tell from reading this novel of a ticket, not showing it when the team has review but not approve is a bug: https://unisubs.sifterapp.com/projects/12298/is...

maybe I'm reading this wrong though

Yippie, build fixed!

Project babelsubs build #57: FIXED in 7.4 sec: http://dev.universalsubtitles.org:8888/job/babe...

* ben: Fixed storeage test.

* ben: Use difflib for diffing.

ok sjl - I will mark this bug as closed and ask Margarita about it later when she's on and open a new bug for that if necessary

janeted1: perfect, thanks!

janeted1: if it turns out to be a bug, assign it to me -- I know how to fix it

ok thanks sjl

but if you change that - surely it will affect 200 other horrible tiny things

of course

arthurdebert: you were looking for me earlier about some youtube stuff?

janeted1 yeah, do you have the creds for the AmaraTester account?

I have to admit that I've barely looked at the syncing stuff

janeted1 if not I just emailed maggie about it

and no - I don't have any creds

janeted1 k, tks

arthurdebert: fyi - margarita is taking Fri and Mon off -

Project unisubs build #5323: STILL FAILING in 10 min: http://dev.universalsubtitles.org:8888/job/unis...

* janet dragojevic: added a test for i2199

* janet dragojevic: some minor test case cleanup

janeted1 k

ehazlett so for the youtube link to work the django Site thing must be link.demo… ?

arthurdebert: yeah -- launchpad should take care of it

ehazlett tks!

arthurdebert: I think I fixed 1582 at a low level, but the way the visual layout of that page really bugs me, so I added some comments/code to the ticket. What do you think about my comment?

1582 - DMR: Email Diffs - https://unisubs.sifterapp.com/issue/1582

bendk I'm with you on the visual layout, it bugs me too

bendk I think we can call it resolved ;)

ok so what's the process for changing the layout of a page? Is there someone who approves the changes?

also, what's the right way to add CSS?

bendk ha, good question, craig used to be in charge of this

I'll resolve the bug in any case