#jenkins-community

/

      • gilesgas has quit
      • jfemia_ joined the channel
      • jfemia has quit
      • gilesgas joined the channel
      • gilesgas has quit
      • gilesgas joined the channel
      • jfemia joined the channel
      • jfemia_ has quit
      • gilesgas has quit
      • ogondza joined the channel
      • gilesgas joined the channel
      • gilesgas has quit
      • gilesgas joined the channel
      • gilesgas has quit
      • gilesgas joined the channel
      • fredg02 joined the channel
      • gilesgas has quit
      • deepakt joined the channel
      • deepakt has left the channel
      • abayer joined the channel
      • sunshinekitty[m] has quit
      • sunshinekitty[m] joined the channel
      • ogondza has quit
      • ogondza joined the channel
      • ogondza has quit
      • jenkins-io
        [13jenkins.io] 15bitwiseman pushed 3 new commits to 06master: 02https://github.com/jenkins-infra/jenkins.io/c...
      • 13jenkins.io/06master 14243860b 15Liam Newman: Added event creation section
      • 13jenkins.io/06master 14dbb20b3 15Liam Newman: Updated based on feedback
      • 13jenkins.io/06master 1469dfbd1 15Liam Newman: Merge pull request #1213 from bitwiseman/feature/event-template...
      • ogondza joined the channel
      • ogondza has quit
      • jglick
        bitwiseman: so is https://github.com/jenkinsci/jep/pull/23 good to go from your PoV? Is it even kosher to accept a draft JEP before JEP-1 is Final? CC rtyler
      • bitwiseman
        jglick: It is totally reasonable to approve a JEP as Draft.
      • jglick: it will need to be updated to match any changes to JEP-1, but you've already been doing that.
      • jglick: I was going move 23 to Draft status, but I wanted those minor changes first.
      • jglick: which you've done.
      • jglick
        Yup. Was not sure why you ASCIIfied my quotes, but whatever. :-)
      • bitwiseman: hey maybe I am missing something but JEP-1 does not seem to specify any point at which the `jep-nnnn` feature branch actually gets merged into `master`…?
      • bitwiseman
        jglick: just formatting. When viewed on github (which is probably how most will view JEPs), plusses do not show as monospace.
      • jglick
        bitwiseman: yeah I saw why s/+/`/g but not why s/[“”]/"/g
      • bitwiseman
        jglick: Um, fear and loathing on my part. I probably should have changed them to the asciidoc representation of them.
      • jglick
        ick no, UTF-8 is more readable and was explicitly advertised in JEP-1
      • bitwiseman
        jglick: as to the merge to master, you're right. It would make sense for it to be either when the JEP is accepted or when it is made final or active.
      • Feel free to PR.
      • jglick
        bitwiseman: I will file a PR suggesting that, yes
      • already working on it
      • bitwiseman
        as to curly quotes. do you feel strongly about having them in there? I can put them back.
      • I'm about to squash commit JEP-200, so might as well do it now.
      • jglick
        you handle docs, your call
      • just one of my quirks
      • bitwiseman
        And mine goes the other way. (All it takes copying code that looks right but has curly-quotes in it...)
      • rtyler
        curly quotes? you mean smart quotes?
      • jglick
        Let us just call them quotes.
      • rtyler
        asciidoctor converts those to proper ASCII quotes when rendering anyways, I just find them obnoxious since their presence causes search/replaces to fail when inconsistently used, etc
      • jglick
        I do not understand. When you are writing code, use `"`. When you are writing English, use `“”`. Seems pretty simple.
      • Ah well, my lonely crusade will continue.
      • rtyler
        heh
      • ride on Senor Quixote
      • gilesgas joined the channel
      • abayer has quit
      • bitwiseman
        okay, I'm keeping my change, but it is a point we'll want to address in a style guidelines jep.
      • olamy has quit
      • danielbeck
        jglick wait, is your JEP not informational? Do you really want a dependency on the unfinished process?
      • jglick
        I guess?
      • olamy joined the channel
      • gilesgas has quit
      • gilesgas joined the channel
      • bitwiseman
        rtyler: any particular reason the jenkins project uses awestruct instead of some other similar tool such as jekyll? I ask only because awestruct seems to be ... very quiet.
      • rtyler
        because you literally could not build a site with jekyll of any complexity at the time
      • jekyll is super opinionated
      • works really well for blog things
      • at the time (caveat!) it was markdown markdown markdown whereas awestruct is very much bring your own engine, and relies on the tilt gem to basically support every possible format depending on the needs
      • thus haml + asciidoc (one is a templating engine, the other ain't)