NOTICE: [appscale] cdonati opened pull request #1798: Allow tools branch to be specified with dev (master...allow-separate-tools-branch) https://github.com/AppScale/appscale/pull/1798
appscalelovesyou has left the channel
cdonati
meniv: Is this demo-able?
meniv
cdonati: I can cook sth up
something*
cdonati: the question is: do I want to? :p
cdonati
Yeah, I don't know. I'm fine with merging it, but I'm not sure exactly what it does.
meniv
cdonati: so this one customer is checking those headers in their app
that’s why it was brought up
cdonati
So google's sdk does it wrong? Or inconsistently with gae?
shaunj joined the channel
meniv
cdonati: good question
obino
shaunj is here, let's stop talking about him
shaunj
obino: if only i wasn’t short on coffee, i might be able to come up with a witty response to that..
obino
lol well we can fix the lack of coffee for sure
RedRat__ joined the channel
kwe has quit
kwe joined the channel
kwe has quit
kwe joined the channel
meniv joined the channel
meniv has quit
shaunj has quit
meniv joined the channel
shaunj joined the channel
appscalelovesyou joined the channel
NOTICE: [appscale] cdonati opened pull request #1799: If retry_on_except is false, raise exception (master...raise-exception-if-no-retry) https://github.com/AppScale/appscale/pull/1799
appscalelovesyou has left the channel
kwe has quit
RedRat__ joined the channel
kwe joined the channel
appscalelovesyou joined the channel
NOTICE: [appscale] obino pushed 2 new commits to master: https://github.com/AppScale/appscale/compare/dc0a2d324198...9f39dd0051af
NOTICE: appscale/master 66b33d1 Chris Donati: Allow tools branch to be specified with dev...
As far as I can tell, place_error_app just puts the tarball there, but it doesn't deploy it.
Should I then add a call to AppManager to deploy the error app?
meniv
cdonati: looking
cdonati
It looks like it adds the error app files to the live app directory (leaving the old ones too, though). But I don't see where it starts or restarts the appserver process.
meniv
cdonati: I believe that the first code block you linked above is where we delete the app tarball
because we encountered an error
and we swap it with the error app tarball
sound good so far?
cdonati
yeah
meniv
for the restart portion I am still not sure
I think that
for python if you swap the serving directory
it gets picked up right away
because we’re talking about /var/apps here
cdonati
that makes sense since the dev_appserver does that by default.
meniv
so I am not certain if it’s the same for the java dir
cdonati
Even for the python one, though, wouldn't we want to remove whatever was in the old directory, though?
It may not affect the app, but it makes it confusing when looking at the serving dir.
To have a combination of app and error app files, that is.